BST的破坏者

我必须实现我自己的二叉搜索树。据我所知，一切正常，除了析构函数。下面是一些代码（所有析构函数和构造函数）BST的破坏者

Node(){ 
     val = T(); 
     parent=nullptr; 
     lChild = nullptr; 
     rChild = nullptr; 
    } 
    Node(T &valx){ 
     val=valx; 
     parent=nullptr; 
     lChild = nullptr; 
     rChild = nullptr; 
    } 
    Node(const Node &other){ 
     val = other.val; 
     if(other.lChild!=nullptr){ 
      lChild = new Node(*other.lChild); 
      lChild->parent=this; 
     } 
     else 
      lChild=nullptr; 
     if(other.rChild!=nullptr){ 
      rChild= new Node(*other.rChild); 
      rChild->parent=this; 
     } 
     else 
      rChild=nullptr; 
    } 
    ~Node(){ 
     if(lChild!=nullptr){ 
      delete lChild; 
      lChild=nullptr; 
     } 
     if(rChild!=nullptr){ 
      delete rChild; 
      rChild=nullptr; 
     } 
    }

和

Set(){ 
    root = nullptr; 
    sizeOfTree=0; 
} 
Set(const Set &other){ 
    if(other.root!=nullptr){ 
     root = new Node(*other.root); 
     root->parent=nullptr; 
    } 
    else 
     root=nullptr; 
    sizeOfTree=other.sizeOfTree; 
} 
~Set() 
{ 
    if(root!=nullptr){ 
     delete root; 
     //root->~Node(); 
     root=nullptr; 
    } 
}

随着simpliest测试，示出了Valgrind的272个错误。感谢您的帮助

@edit：Valgrind的输出的一部分：

==6981== Invalid read of size 8 
==6981== at 0x405C29: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:53) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4) 
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c34468 is 24 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315) 
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid read of size 8 
==6981== at 0x405C5F: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:57) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4) 
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c34470 is 32 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315) 
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid free()/delete/delete[]/realloc() 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x404790: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4) 
==6981== by 0x4015F0: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c34450 is 0 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315) 
==6981== by 0x4015A6: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:718) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid read of size 8 
==6981== at 0x405C6C: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:58) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x4057AF: Set<Pionek>::clear() (JakbyGomoku4.cpp:222) 
==6981== by 0x40160B: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:731) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c334c0 is 32 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315) 
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid write of size 8 
==6981== at 0x405C89: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:59) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x4057AF: Set<Pionek>::clear() (JakbyGomoku4.cpp:222) 
==6981== by 0x40160B: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:731) 
==6981== by 0x401746: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:745) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c334c0 is 32 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401E27: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:315) 
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid read of size 8 
==6981== at 0x405C36: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:54) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x40479C: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4) 
==6981== by 0x401755: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:748) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c33448 is 24 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401DF0: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:314) 
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== 
==6981== Invalid write of size 8 
==6981== at 0x405C53: Set<Pionek>::Node::~Node() (JakbyGomoku4.cpp:55) 
==6981== by 0x4049EA: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x40479C: Plansza::~Plansza() (in /media/Dokumenty/Workspace/JakbyGomoku4/Debug/JakbyGomoku4) 
==6981== by 0x401755: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:748) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792) 
==6981== Address 0x4c33448 is 24 bytes inside a block of size 40 free'd 
==6981== at 0x4A073CC: operator delete(void*) (vg_replace_malloc.c:480) 
==6981== by 0x4049F2: Set<Pionek>::~Set() (JakbyGomoku4.cpp:152) 
==6981== by 0x401DF0: Plansza::Plansza(Plansza const&) (JakbyGomoku4.cpp:314) 
==6981== by 0x4016DE: generujPlansze(Plansza&, int, bool, Set<Plansza>&) (JakbyGomoku4.cpp:742) 
==6981== by 0x4019D5: main (JakbyGomoku4.cpp:792)

来源

2013-04-13 Krever

请分享Valgrind的输出 – Saqlain

规则三......三规则...三规则... –

你缺少运营商=除复制构造函数和析构函数检查here
也没有必要在析构函数检查nullptr， it is ok to delelete nullptr。
考虑像

Node n1; 
//set children for n1 
{ 
Node n2; 
//set children for n2 
n1 = n2;//Now both n1 and n2 points same children, and initial children of n1 becomes mem leak 
}//n2 destructor deletes its children leaving n1 pointing to the same already freed memory location

来源

2013-04-13 09:06:45 alexrider

For节点，设置或两者兼而有之？任何提示它应该是什么样子？ – Krever

对于两者都具有析构和复制ctor。检查我发布的第一个链接，它已经包含详细的解释和示例。 – alexrider

根据您发布的报告，这是问题所在。您创建节点，将一个节点分配给另一个节点，并且结果有两个节点指向同一个内存位置，一旦其中一个节点被删除，剩下的节点将保存指向已释放内存的指针。 – alexrider

BST的破坏者

回答

相关问题