2011-12-16 61 views
1

我有一个问题,关于一个函数的调用,需要相当长的一段时间,我希望有些人可以看看我是否做了一些犯罪。缓慢的PHP过程

当我在sendletter.php下面的函数中运行函数GetEmailCue时,大约需要一分钟左右才能完成,我找不到原因。

emailcue db表只包含2封电子邮件。

  /****************************************** 
     * Sends a letter from the email cue 
     * 
     * @param int  | The letter id 
     *******************************************/ 
     function SendTheLetter($letter_id) { 

      /*** Find the email cue based on the newsletter uid ***/ 
      $cue = new NewsletterHandler; 
      $cue->GetLetterContent($letter_id); 
      $cue->GetEmailCue($letter_id); 

      $headers = 'MIME-Version: 1.0' . "\r\n"; 
      $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n"; 

      foreach($cue->email_row as $key => $value) { 
       mail($value, "Newsletter - ". date("d-m-Y"), $this->htmlTemplate, $headers); 
       $sql_update = "UPDATE newsletter_emailcue SET time_recieved = NOW() WHERE email = '". $value ."'"; 
       SQLHandling::SQLquery($sql_update);     
      } 
     } 

此功能与其他两个功能

拉数据

GetLetterContent:

  /****************************************** 
     * Find all fields that belongs to a  
     * newsletter. 
     * 
     * @param int  | The letter id 
     *******************************************/ 
     function GetLetterContent($letter_id) { 

      $sql = "SELECT A.template, A.status, B.field_name, B.field_content FROM newsletter_items A, newsletter_fields B WHERE B.field_letter_uid = '". $letter_id ."'";   

      $result = SQLHandling::SQLquery($sql); 

       while($row = mysql_fetch_array($result)) { 

        $this->content_markers["". $row["field_name"] .""] = $row["field_content"]; 
        $template = $row["template"]; 
       } 

       /*** Compile the letter with all the markers ***/ 
       $this->CompileLetter($letter_id, $template, $this->content_markers); 
       return;     
     } 

GetEmailCue:

  /****************************************** 
     * Get an entire email cue based on a 
     * newsletter id. 
     * This functions is called from the send 
     * function. 
     * 
     * @param int  | The letter id 
     *******************************************/ 
     function GetEmailCue($letter_id) { 
      $sql = "SELECT * FROM newsletter_emailcue WHERE mail_to_recieve = '". $letter_id ."' AND time_recieved = '0000-00-00 00:00:00' LIMIT 1"; 
      $result = SQLHandling::SQLquery($sql); 

      if(mysql_num_rows($result) < 1) { 
       $sql_update = "UPDATE newsletter_items SET status = 2 WHERE letter_id = '". $letter_id ."'"; 
       SQLHandling::SQLquery($sql_update); 
      } else {    
       while($row = mysql_fetch_array($result)) { 
        $this->email_row[] = $row["email"]; 
       } 
      } 

      return $this->email_row; 
     } 

似乎GetEmailCue可能是这个问题,因为如果我在SendTheLetter中注释掉它,那么函数会马上执行,如果我直接从文件运行GetEmailCue,这个函数也会立即执行,但是当我在SendTheLetter中运行它时,它永远都会用到。

SendTheLetter功能再次从FindLetterToSend

  /****************************************** 
     * Finds all letters that have send status 1 
     * which is pending to send. 
     *******************************************/ 
     function FindLetterToSend() { 
      $sql = "SELECT * FROM newsletter_items WHERE status = '1'";   
      $result = SQLHandling::SQLquery($sql); 

      if(mysql_num_rows($result) == 0) { 
       Main::txtOutput("Der er ingen nyhedsbreve i udsendelseskøen!", "TXT_ERR");    

       /*** Let's clear the emailcue table - no need for the cue any more ***/ 
       SQLHandling::SQLquery("TRUNCATE TABLE newsletter_emailcue");    
      } else { 
       while($row = mysql_fetch_array($result)) { 
        $this->SendTheLetter($row["letter_id"]); 
       } 
      } 
      return; 
     } 

叫我运行它在我的Ubuntu的本地主机

回答

1

发送电子邮件需要一些时间,但你说,只有两个邮件已发送。这并不多。

此代码可以在任何电子邮件行上进行更新?

foreach($cue->email_row as $key => $value) { 
    mail($value, "Newsletter - ". date("d-m-Y"), $this->htmlTemplate, $headers); 
    $sql_update = "UPDATE newsletter_emailcue SET time_recieved = NOW() WHERE email = '". $value ."'"; 
    SQLHandling::SQLquery($sql_update);     
} 

您是否尝试使用microtime函数来测量单个代码部分的运行时间?

+0

当发送电子邮件时,该电子邮件将获得时间戳,以避免他/她不止一次接收新闻通讯。该foreach更新电子邮件只是发送... 我可以尝试测量运行时间。 – 2011-12-16 10:34:55