我跑Valgrind的,我收到以下错误.. 之前我做了一个备份我固定的,但现在我不记得如何。物通过的malloc产生错误,但在代码Unitialised值(S)的valgrind
>Insert password for admin: ==5720== Conditional jump or move depends on uninitialised value(s)
==5720== at 0x40299EB: strcmp (mc_replace_strmem.c:538)
==5720== by 0x80496C6: adm_log_request (commands_man.c:169)
==5720== by 0x80521CA: main (mmboxman.c:9)
==5720== Uninitialised value was created by a heap allocation
==5720== at 0x4028876: malloc (vg_replace_malloc.c:236)
==5720== by 0x8049683: adm_log_request (commands_man.c:165)
==5720== by 0x80521CA: main (mmboxman.c:9)
==5720==
这是函数 线commands_man我无法找到该错误:165是,如果后(大小> 0)
int adm_log_request(void){
FILE *password;
char *pwdin, *frompwd = NULL;
int primo = 0/*indica se è un primo avvio*/, tentativi = 2, p, size;
if(!(password = fopen(F_PWD_ADM, "rb"))){
primo = 1;
printf("First server boot\n>Insert password for admin: ");
}
else{
primo = 0;
printf(">Insert password for admin: ");
}
p = get_hid_pass(&pwdin);
if(p < 0)
return -1;
switch(primo){
case 0:
if(!(password = fopen(F_PWD_ADM, "r")))
return -1;
fread(&size, sizeof(int), 1, password);
if(size > 0){
frompwd = (char*)malloc(size + 1);
fread(frompwd,sizeof(frompwd),1,password);
}else return 0;
while(tentativi > 0){
if(strcmp(pwdin, frompwd) != 0){
printf("\nIncorrect password\n%d attempts left\n>Insert password for admin: ", tentativi);
tentativi--;
}
else return 1;
p = get_hid_pass(&pwdin);
if(p < 0)
return -1;
}
fclose(password);
break;
case 1: //primo avvio del server
if(!(password = fopen(F_PWD_ADM, "w")))
return -1;
size = strlen(pwdin) + 1;
fwrite(&size, sizeof(int), 1, password);
fwrite(pwdin, sizeof(pwdin), 1, password);
fclose(password);
break;
}
if(tentativi == 0)
return -1;
return 1;
}
莫非有人帮我解决他们?谢谢你的问题
我发现问题..它在 size = strlen(pwdin)+ 1; +1错了!谢谢!! =) – roccocullo 2012-02-09 15:46:53
@roccocullo:这取决于你是否想写空终止符字节或不。并且请注意,'fwrite'调用仍然需要被赋予正确的长度(大小)而不是sizeof结果。 – 2012-02-09 15:49:15