如何检查迭代器的相等性？

Question

在我的llvm代码中，我尝试检查迭代器InsertPos是否指向基本块的最后一条指令，代码如下。

BasicBlock::iterator InsertPos = BB->begin(); 
    LLVMContext &Context = BB->getContext(); 

    while (!(isa<CallInst>(InsertPos) || 
     (InsertPos == BB->getTerminator()))) // <-- Error here 
    ++InsertPos; 

但是，clang给我以下错误。

Basic2.cpp:82:54: error: use of overloaded operator '==' is ambiguous (with operand types 'BasicBlock::iterator' (aka 'ilist_iterator<llvm::Instruction>') 
     and 'llvm::TerminatorInst *') 
    while (!(isa<CallInst>(InsertPos) || (InsertPos == BB->getTerminator()))) 
              ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ 
/home/hmushtaq/llvm/include/llvm/ADT/ilist.h:204:8: note: candidate function 
    bool operator==(const ilist_iterator &RHS) const { 
    ^
Basic2.cpp:82:54: note: built-in candidate operator==(class llvm::Instruction *, class llvm::Instruction *) 
    while (!(isa<CallInst>(InsertPos) || (InsertPos == BB->getTerminator()))) 
                ^
    Basic2.cpp:82:54: note: built-in candidate operator==(restrict class llvm::Instruction *, restrict class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(const restrict class llvm::Instruction *, const restrict class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(volatile class llvm::Instruction *, volatile class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(const volatile class llvm::Instruction *, const volatile class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(volatile restrict class llvm::Instruction *, volatile restrict class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(const class llvm::Instruction *, const class llvm::Instruction *) 
    Basic2.cpp:82:54: note: built-in candidate operator==(const volatile restrict class llvm::Instruction *, const volatile restrict class llvm::Instruction *) 

这样做的正确方法是什么？

Answer 1

BB->getTerminator()返回一个指针（TerminatorInst *），而InsertPos是一个迭代（BasicBlock::iterator）。类型不匹配。

也许你可以尝试

&*InsertPos == BB->getTerminator() 

---

你也可以查看指令是否与the isTerminator() method终止。

InsertPos->isTerminator() 

Answer 2

我解决了这个问题。

BasicBlock::iterator InsertPos = BB->begin(); 
BasicBlock::iterator TermPos = BB->getTerminator(); // <-- Added this variable 

while (!(isa<CallInst>(InsertPos) || (InsertPos == TermPos))) 
    ++InsertPos;