我有下面的基类和派生类。有2点,我觉得我的代码有问题:c#避免拳击和重复代码
public class FieldCollection
{
public FieldCollection()
{
Fields = new List<FieldBase>();
}
public List<FieldBase> Fields { get; set; }
public void InitFieldList()
{
foreach (var item in DbFieldList)
{
if (item.Type == FieldTypes.int)
{
Fields.Add(new Field<int>());
}
else
if (item.Type == FieldTypes.string)
{
Fields.Add(new Field<string>());
}
...
};
}
public void SetFieldValue(string fieldName, object value)
{
FieldBase field = FindField(fieldName);
if ((field as FInt) != null)
{
(field as FInt).SetValue(Convert.ToInt32(value));
}
else
if ((field as FString) != null)
{
(field as FString).SetValue(Convert.ToString(value));
}
else
if ((field as FDate) != null)
{
(field as FDate).SetValue(Convert.ToDateTime(value));
};
}
public FieldBase FindField(string fieldName)
{
FieldBase field = Fields.FirstOrDefault(f => (String.Equals(f.Name, fieldName, StringComparison.CurrentCultureIgnoreCase)));
return field;
}
}
public abstract class FieldBase
{
public string Name { get; set; }
}
public class FInt : FieldBase
{
public void SetValue(int value)
{
}
}
public class FString : FieldBase
{
public void SetValue(string value)
{
}
}
public class FDate : FieldBase
{
public void SetValue(DateTime value)
{
}
}
- 重复:如果未来出现了一个新的派生类,我将有额外的if语句等补充。
if ((field as FInt) != null) { (field as FInt).SetValue(Convert.ToInt32(value)); } else if ((field as FString) != null) { (field as FString).SetValue(Convert.ToString(value)); } else if ((field as FDate) != null) { (field as FDate).SetValue(Convert.ToDateTime(value)); };
- 装箱和取消装箱:我被迫对象值转换为基于派生的类的类型的期望类型:
(field as FInt).SetValue(Convert.ToInt32(value)); (field as FString).SetValue(Convert.ToString(value)); (field as FDate).SetValue(Convert.ToDateTime(value));
我对如何设计这些类以克服上述提及感兴趣编辑问题。
您的帮助非常感谢。
看起来你需要仿制药 –