2016-11-09 129 views
0

我目前有拉从表A说做B表中不存在的所有记录的工作表,然后我有一个插入这些值到表B.更新数据库连接

但是我意识到,如果在插入宏之前查询没有刷新,它会产生重复项。

使用当前的宏,我如何在插入之前和之后包含刷新?

Sub Insert_New_Bills() 

    Dim conn As New ADODB.Connection 
    Dim iRowNo As Integer 
    Dim sBILL_NUM, sROCKTENN_DOC, sACTION, sNOTE1, sNOTE2 As String 

    With Sheets("NEW BILLS") 

     'Open a connection to SQL Server 
     conn.Open "Driver={IBM DB2 ODBC DRIVER};Database=BROWN;Hostname=192.168.100.44;Port=50000;Protocol=TCPIP;Uid=" & "User" & ";Pwd=" & "Maddox2009" & ";CurrentSchema=LYNX;" 

     'Skip the header row 
     iRowNo = 2 

     'Loop until empty cell in COLUMN1 
     Do Until .Cells(iRowNo, 2) = "" 
      sBILL_NUM = .Cells(iRowNo, 2) 
      sROCKTENN_DOC = .Cells(iRowNo, 3) 
      sACTION = .Cells(iRowNo, 4) 
      sNOTE1 = .Cells(iRowNo, 5) 
      sNOTE2 = .Cells(iRowNo, 6) 

      'Generate and execute sql statement to import the excel rows to SQL Server table 
      conn.Execute "INSERT INTO OH_CU_WR_TEMPLATE (BILL_NUMBER, ROCKTENN_DOC, ACTION, NOTE1, NOTE2) values ('" & sBILL_NUM & "','" & sROCKTENN_DOC & "', '" & sACTION & "', '" & sNOTE1 & "', '" & sNOTE2 & "')" 


      iRowNo = iRowNo + 1 
     Loop 

     MsgBox "RECORD UPDATED" 

     conn.Close 
     Set conn = Nothing 

     Selection.ListObject.QueryTable.Refresh BackgroundQuery:=False 

    End With 

End Sub 
+0

我不知道关于'db2'的语法。但我宁愿使用与此类似的解决方案:http://stackoverflow.com/questions/9911659/can-i-use-if-not-exists-to-insert-a-row-if-the-row -s-not-already-in-in-s尤其是如果您允许同一个Excel文件的多个实例,则无法再控制哪些记录已经插入到数据库中,哪些记录仍处于待处理状态。除此之外,我会实施一个工作表事件来跟踪哪些已上传,哪些尚未上传。但是这个解决方案不会像我提出的第一个那样简洁。 – Ralph

回答

0

无论之前或之后有刷新,SQL语句本身都不会避免重复。如果您有一个主键或复合索引限制其中一个插入的单元格值使用重复值,则可能会出现错误并中断代码,因为当前没有设置错误/异常处理。

考虑填充常规清理的临时表(确切的结构副本的最终表)。然后,运行经典LEFT JOIN ... NULL/NOT EXISTS/NOT IN附加查询以插入唯一值。此外,由于我将是不鼓励不负责任的,下面采用ADO parameterization

SQL(运行一次)

CREATE TABLE OH_CU_WR_TEMPLATE_TEMP AS (
    SELECT * FROM OH_CU_WR_TEMPLATE 
) WITH NO DATA 

VBA

Dim cmd As ADODB.Command 
    Dim strSQL As String 
    ... 

    ' CLEAN OUT TEMP TABLE 
    conn.Execute "DELETE FROM OH_CU_WR_TEMPLATE_TEMP" 

    ' PREPARE STATEMENT (INSERTS INTO TEMP TABLE) 
    strSQL = "INSERT INTO OH_CU_WR_TEMPLATE_TEMP (BILL_NUMBER, ROCKTENN_DOC, " _ 
         & " ACTION, NOTE1, NOTE2)" _ 
         & " VALUES (?, ?, ?, ?, ?)" 

    ' ITERATE ROWS 
    Do Until .Cells(iRowNo, 2) = "" 
     ' ASSIGN VALUES 
     sBILL_NUM = .Cells(iRowNo, 2) 
     sROCKTENN_DOC = .Cells(iRowNo, 3) 
     sACTION = .Cells(iRowNo, 4) 
     sNOTE1 = .Cells(iRowNo, 5) 
     sNOTE2 = .Cells(iRowNo, 6) 

     ' UPDATE CMD OBJECT 
     Set cmd = New ADODB.Command 

     With cmd 
      .ActiveConnection = conn 
      .CommandText = strSQL 
      .CommandType = adCmdText 
      .CommandTimeout = 15 
     End With 

     ' BIND PARAMETERS 
     cmd.Parameters.Append cmd.CreateParameter("param1", adVarChar, adParamInput, 255, sBILL_NUM) 
     cmd.Parameters.Append cmd.CreateParameter("param2", adVarChar, adParamInput, 255, sROCKTENN_DOC) 
     cmd.Parameters.Append cmd.CreateParameter("param3", adVarChar, adParamInput, 255, sAction) 
     cmd.Parameters.Append cmd.CreateParameter("param4", adVarChar, adParamInput, 255, sNOTE1) 
     cmd.Parameters.Append cmd.CreateParameter("param5", adVarChar, adParamInput, 255, sNOTE2) 

     ' EXECUTE SQL 
     cmd.Execute 
     iRowNo = iRowNo + 1 
    Loop 

    ' NON-DUPLICATE APPEND QUERY (USE APPROPRIATE JOIN IDs) 
    conn.Execute "INSERT INTO OH_CU_WR_TEMPLATE" _ 
        & " SELECT * FROM OH_CU_WR_TEMPLATE_TEMP temp" _ 
        & " LEFT JOIN OH_CU_WR_TEMPLATE main" _ 
        & " ON temp.ID = main.ID" _ 
        & " WHERE main.ID IS NULL;"