2016-10-11 103 views
1

救星。DatabaseCleaner似乎没有清理套装

我在每个RSpec示例后清理数据库时遇到问题。 问题是,当我运行rspec命令时,users_controller_spec.rb会抱怨存在比示例所期望的更多的记录。事实上,如果我使用rails c进行检查,正在创建记录。 当我单独运行这个套件时,它会成功,所以我认为这是因为DatabaseCleaner不会清除其他规范创建的用户记录(用户记录的数量与记录中的其他记录user_controller_spec示例相匹配)。他们创建在before :all区块(如果有的话)。

这是我rails_helper.rb

# This file is copied to spec/ when you run 'rails generate rspec:install' 
ENV['RAILS_ENV'] ||= 'test' 
require 'spec_helper' 
require File.expand_path('../../config/environment', __FILE__) 
require 'rspec/rails' 

# Add additional requires below this line. Rails is not loaded until this point! 
require 'devise' 
require 'admin/v1/dashboard_controller' 
# Requires supporting ruby files with custom matchers and macros, etc, in 
Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f } 

# Checks for pending migrations before tests are run. 
# If you are not using ActiveRecord, you can remove this line. 
ActiveRecord::Migration.maintain_test_schema! 

RSpec.configure do |config| 
    # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures 
    config.fixture_path = "#{::Rails.root}/spec/fixtures" 

    config.include Devise::Test::ControllerHelpers, type: :controller 
    config.include ControllerMacros, type: :controller 
    # If you're not using ActiveRecord, or you'd prefer not to run each of your 
    # examples within a transaction, remove the following line or assign false 
    # instead of true. 
    config.use_transactional_fixtures = true 

    config.include FactoryGirl::Syntax::Methods 

    config.infer_spec_type_from_file_location! 

    config.before(:suite) do 
    DatabaseCleaner.strategy = :transaction 
    DatabaseCleaner.clean_with(:truncation) 
    end 

    config.around(:each) do |example| 
    DatabaseCleaner.cleaning do 
     example.run 
    end 
    end 
end 

users_controller.rb

describe 'GET #index' do 
    it 'populates an array of users' do 
    user1 = create(:user) 
    user2 = create(:user) 
    get :index 
    expect(assigns(:users)).to match_array([user1, user2]) 
    end 
    it 'renders :index template' do 
    get :index, {} 
    expect(response).to render_template :index 
    end 
end 

UPDATE1:这是额外的user记录创建

require 'rails_helper' 

describe Admin::V1::MessagesController do 
    let(:admin_user) do 
    admin_user = double('admin_user') 
    allow(request.env['warden']).to receive(:authenticate!).and_return(admin_user) 
    allow(controller).to receive(:current_admin_v1_admin_user).and_return(admin_user) 
    p '===' 
    end 
    before { login_admin_user admin_user } 

    describe 'GET #index' do 
    it 'renders :index template' do 
     get :index, {} 
     expect(response).to render_template :index 
    end 
    end 

    describe 'GET #get_users' do 
    before :all do 
     @user1 = create(:user, nickname: 'hiro') 
     @user2 = create(:user, nickname: 'elise') 
    end 
    context 'with params' do 
     it 'populates an array of users matching on nickname' do 
     get :get_users, format: :json, query: 'h' 
     expect(assigns(:users)).to match_array([@user1]) 
     end 
    end 
    context 'without params' do 
     it 'populates an array of all users' do 
     get :get_users, format: :json 
     expect(assigns(:users)).to match_array([@user1, @user2]) 
     end 
    end 
    end 

    describe 'GET #get_messages' do 
    before :all do 
     @user1 = create(:user) 
     @user2 = create(:user) 
     @message1 = create(:message, user_id: @user1.id) 
     @message2 = create(:message, user_id: @user1.id) 
     @message3 = create(:message, user_id: @user2.id) 
    end 
    context 'with user_id' do 
     it 'populates an array of messages with the user_id' do 
     get :get_messages, format: :json, user_id: @user1.id 
     expect(assigns(:messages)).to match_array([@message1, @message2]) 
     end 
    end 
    end 
end 
+0

您的配置看起来OK。其他规格可能存在错误(不在* users_controller_apec.rb *中)。你有多少个规格?尝试按组执行规格以找出创建的记录。 –

+0

我目前有8个控制器规格。并且额外的记录正在前端javascript ajaxes用户信息和api rails检索某些用户记录(因此用户记录分解)的示例中创建。 – Hiro

+0

你可以展示这些规格吗? (将它们添加到您的问题中) –

回答

2

不幸的RSpec的before(:all)不TRAN发挥很好传统测试。 before(:all)中的代码在事务打开之前运行,这意味着在事务中止时任何创建的记录都不会回滚。您有责任在after(:all)中手动清洁这些物品。

rspec-rails#496Using before(:all) in RSpec will cause you lots of trouble unless you know what you are doing

after(:all) do 
    # before/after(:all) is not transactional; see https://www.relishapp.com/rspec/rspec-rails/docs/transactions 
    DatabaseCleaner.clean_with(:truncation) 
    end 
+0

谢谢!有效!从来没有想过会有这个干净而合乎逻辑的答案。毕竟,文件规则.. – Hiro

+0

不错,很高兴它帮助! – gmcnaughton