Bluebird Promise.map无法正常工作

Question

我试图在问题和答案之间建立关联。我正在使用Bluebird的API .map来确保仅在所有question.addAnswers(answer)承诺完成后发生重定向。因此，在我的终端，我看到这样的事情：

done adding a answer to the question 
done adding a answer to the question 
finished 

不过，我看到的是：

finished 
done adding a answer to the question 
done adding a answer to the question 

因此，我假设Promise.map是不工作的。我错过了什么？我怎样才能使它工作？

这里是我的代码：

router.post('/create', function(req, res) { 
    models.Question.create({ 
    content: req.body.question 
    }) 
    .then(function(question) { 
    if (!question) { 
     res.render('questions/new', { 
      error: "Question \"#{req.body.question}\" fails to be created" 
     }); 
    } else { 
     // Update the new question to each user 
     models.User.findAll() 
     .then(function(users) { 
     users.forEach(function(user) { 
      user.addQuestion(question) 
     }); 
     }); 
     Promise.map(req.body.answers, function(answer){ 
     return createAndAddToQuestion(question, answer, res) 
     }) 
     .then(function(){ 
     console.log('finished') 
     res.redirect("https://stackoverflow.com/questions/success/?question_id=" + question.id); 
     }); 
    }; 
    }) 
}) 

var createAndAddToQuestion = function(question, answer, res) { 
    models.Answer.create({ 
    content: answer 
    }) 
    .then(function(ans) { 
    if (ans) { 
     var promise = question.addAnswer(ans) 
     promise.then(function(){ 
     console.log("done adding a answer to the question") 
     }); 
     return question.addAnswer(ans); 
    } else { 
     res.render('questions/new', { 
     error: "Answer \"#{answer}\" fails to be created" 
     }); 
    }; 
    }); 
} 

UPDATE 我刚刚更新createAndAddToQuestion，所以它会返回一个承诺来代替。结果保持不变。 Promise.map不起作用。

var createAndAddToQuestion = function(question, answer, res) { 
    models.Answer.create({ 
    content: answer 
    }) 
    .then(function(ans) { 
    if (ans) { 
     return question.addAnswer(ans).then(function() { 
     console.log('done') 
     }) 
    } else { 
     res.render('questions/new', { 
     error: "Answer \"#{answer}\" fails to be created" 
     }); 
    }; 
    }); 
} 

Answer 1

你最突出的问题是，createAndAddToQuestion不返回一个承诺，所以map不知道等待什么。

此外，您不等models.User.findAll，调用question.addAnswer(ans);两次，可能会尝试多次呈现错误消息，如果答案未能创建，并且没有通用错误处理程序。你应该做的

router.post('/create', function(req, res) { 
    createQuestion(req.body).then(function(question) { 
    console.log('finished') 
    res.redirect("https://stackoverflow.com/questions/success/?question_id=" + question.id); 
    }, function(err) { 
    res.render('questions/new', { 
     error: err.message 
    }); 
    }).catch(function(err) { 
    console.error(err); 
    res.status(500); 
    }); 
}); 

function createQuestion(opts) { 
    return models.Question.create({ 
    content: opts.question 
    }) 
    .then(function(question) { 
    if (!question) { 
     throw new Error("Question \"#{opts.question}\" fails to be created"); 
    } 
    // Update the new question to each user 
    return Promise.all([ 
     models.User.findAll() 
     .then(function(users) { 
     users.forEach(function(user) { 
      user.addQuestion(question) 
     }) 
     }), 
     Promise.map(opts.answers, function(answer){ 
     return createAndAddToQuestion(question, answer) 
     }) 
    ]).return(question); 
    }); 
} 

function createAndAddToQuestion(question, answer) { 
    return models.Answer.create({ 
    content: answer 
    }) 
    .then(function(ans) { 
    if (!ans) { 
     throw new Error("Answer \"#{answer}\" fails to be created"); 
    } 
    return question.addAnswer(ans); 
    }) 
    .then(function(){ 
    console.log("done adding a answer to the question") 
    }); 
}