好的这个程序我工作似乎没有问题,除了有问题。下面是代码从文件读取导致无限循环的问题
#include <iostream>
#include <fstream>
using namespace std;
/*
Function Name: CalculateBinary
CalculateBinary takes a number from the main function and finds its binary form.
*/
void CalculateBinary(long InputNum)
{
//Takes InputNum and divides it down to "1" or "0" so that it can be put in binary form.
if (InputNum != 1 && InputNum != 0)
CalculateBinary(InputNum/2);
// If the number has no remainder it outputs a "0". Otherwise it outputs a "1".
if (InputNum % 2 == 0)
cout << "0";
else
cout << "1";
}
void main()
{
// Where the current number will be stored
long InputNum;
//Opens the text file and inputs first number into InputNum.
ifstream fin("binin.txt");
fin >> InputNum;
// While Input number is not 0 the loop will continue to evaluate, getting a new number each time.
while (InputNum >= 0)
{
if(InputNum > 1000000000)
cout << "Number too large for this program ....";
else
CalculateBinary(InputNum);
cout << endl;
fin >> InputNum;
}
}
这里是文本文件,我在
12
8764
2147483648
2
-1
读书当我到8764,它只是不断在这数了一遍又一遍读。它忽略了2147483648.我知道我可以通过将InputNum声明为long long来解决这个问题。但我想知道它为什么这样做?
是2147483648之前的空间应该在那里? –
看起来很熟悉:http://stackoverflow.com/questions/7397034/infinite-loop-problem – Mysticial
取决于来自binin.txt的输入这个程序可能有UB。 – wilhelmtell