为什么我的存储过程返回true，即使它引发错误？

为什么这个SP返回TRUE，即使我提到如果某些条件满足，那么它应该提高错误，但它仍然返回true。我已经检查了条件，它正在开会，但仍然如此，为什么？为什么我的存储过程返回true，即使它引发错误？

SP：

ALTER PROC [dbo].[usp_UpdateWithdrawal] 
(
    @NITNo int, 
    @WorkNo int, 
    @ContractorID int, 
    @IsWithDrawn bit 
) 

AS 
BEGIN 
    Begin Try 

    Begin Transaction 

     Declare @ExpiryDate date 
     Declare @ExpiryTime time(7) 

     Set @ExpiryDate= (Select convert(varchar(11), ExpiryDate, 106) from Works where NIT_No= @NITNo and WorkNo= @WorkNo) 
     Set @ExpiryTime= (Select CAST(ExpiryTime as TIME(0)) from Works where NIT_No= @NITNo and WorkNo= @WorkNo) 

     IF(CONVERT(varchar(11), @ExpiryDate, 106)+' '+Convert(varchar(8),CAST(@ExpiryTime as TIME(0))) < CONVERT(varchar(11), Getdate(), 106)+' '+Convert(varchar(8),CAST(Getdate() as TIME(0))))  
     Begin 
      RAISERROR('Sorry, Expiry Date and Time has passed', 16, 10); 
      return; 
     End 

     Update AppliedWorks 
     Set Withdrawn= @IsWithDrawn 
     Where NIT_No= @NITNo and Work_No= @WorkNo and Contractor_ID= @ContractorID and 
     CONVERT(varchar(11), @ExpiryDate, 106)+' '+Convert(varchar(8),CAST(@ExpiryTime as TIME(0))) < CONVERT(varchar(11), Getdate(), 106)+' '+Convert(varchar(8),CAST(Getdate() as TIME(0))) 

     --Update Hisotry 

     Declare @AppliedWorkID int 
     Set @AppliedWorkID= (Select AppliedWorkID from AppliedWorks 
          Where NIT_No= @NITNo and Work_No= @WorkNo and Contractor_ID= @ContractorID) 


       Insert into AppliedWorkHistory 
       (
        AppliedWork_ID, 
        FinancialMoney, 
        AboveBelow, 
        EntryDateTime, 

        TwoPercentAmount, 
        TwoPercentBankName, 
        TwoPercentDemandDaftNo, 
        TwoPercentDemandDaftValue, 
        TwoPercentRemarks, 

        EightPercentAmount, 
        EightPercentBankName, 
        EightPercentDemandDaftNo, 
        EightPercentDemandDaftValue, 
        EightPercentRemarks, 
        IsFinalized, 
        Withdrawn 
       ) 
       Select @AppliedWorkID, aw.FinancialMoney, aw.AboveBelow, Getdate(), aw.TwoPercentAmount, aw.TwoPercentBankName, aw.EightPercentDemandDaftNo, 
         aw.TwoPercentDemandDaftValue, aw.TwoPercentRemarks, aw.EightPercentAmount, aw.EightPercentBankName, 
         aw.EightPercentDemandDaftNo, aw.EightPercentDemandDaftValue, aw.EightPercentRemarks, aw.IsFinalized, @IsWithDrawn 
       from AppliedWorks aw where aw.AppliedWorkID= @AppliedWorkID 



    Commit Transaction 

    End Try 
    Begin Catch 
       Rollback transaction 
    End Catch 


END;

C＃：

公共静态布尔UpdateWithdrawal（INT NitNo，INT WorkNo，INT ContractorID，布尔IsWithDrawn） { 布尔结果;

ClsDatabaseManager dbManager = ClsDatabaseManager.InitializeDbManager(Constants.Databases.TendersConnection); 
try 
{ 
    dbManager.CreateParameters(4); 
    dbManager.AddParameters(0, "@NITNo", NitNo); 
    dbManager.AddParameters(1, "@WorkNo", WorkNo); 
    dbManager.AddParameters(2, "@ContractorID", ContractorID); 
    dbManager.AddParameters(3, "@IsWithDrawn", IsWithDrawn); 
    dbManager.Open(); 
    Result = dbManager.ExecuteNonQuery("usp_UpdateWithdrawal", CommandType.StoredProcedure).ToBool(); 
} 
catch (Exception ex) 
{ 
    throw ex; 
} 
finally 
{ 
    dbManager.Close(); 
    dbManager.Dispose(); 
} 

return Result;

}

来源

2017-03-06 Covert

您在'TRY..CATCH'中引发错误，并且没有在'CATCH'中处理它，您需要将错误抛入您的'CATCH'部分以及 – Stephen

。在答案框中写下你的留言，这样我就可以标记它 – Covert

正如发表评论。

如果您在TRY..CATCH内发生错误，并且在CATCH中未处理该错误，则需要将错误也列入您的CATCH部分。

来源

2017-03-06 06:39:58 Stephen

取出放置在RAISERROR语句后return声明。
因为如果使用tryCatch块，Error会抛出catch块。
所以在raiseError之后，在您的存储过程中删除return语句。

来源

2017-03-06 06:31:33 Mansoor

是的，但不能正常工作 – Covert

为什么我的存储过程返回true，即使它引发错误？

回答

相关问题