2014-08-29 71 views
3

我想从一个数组中删除项目,然后添加到另一个。在某个阶段,我会将它们添加回原始数组。当我第10次运行数组10次时,不会返回完整数组= 0的预期结果。任何人都知道为什么会这样?阵列之间交换元素

var fullArr = [];//contains all items 
var remArr = [];//contains removed items 
var userAnswer = true;//this would be user input 

populateArray(); 
runTenTimes(); 
//getting the answer right 10 times should result in fullArr.length = 0; remArr.length = 100; 

function runTenTimes(){ 
    for(var i=0;i<10;i++){ 
    //console.log(i); 
    checkUserAnswer(); 
    } 
} 
function populateArray(){ 
    for(var i=0;i<100;i++){ 
     fullArr.push(i); 
    } 
} 

function checkUserAnswer(){ 
    if(userAnswer){//only if true 
     for(i=0;i<10;i++){//10 because I remove 10 at a time 
      removeShape(fullArr,fullArr[i],remArr); 
     } 
    }else{ 
      // add elements from remove arr 
      // back into full array 
    } 
    console.log("full array : " + fullArr.length); 
    console.log("remove array : " + remArr.length); 
    console.log("------------------") 
} 

function removeShape(arr,item,rem){ 
     for(var i = 0;i<arr.length; i++) { 
      if(arr[i] === item) { 
      rem.push(arr[i]); 
      arr.splice(i, 1); 
      } 
     } 
} 

http://jsfiddle.net/non_tech_guy/vy671jv4/

+2

你改变阵列,同时在遍历它。解决这个问题的一个简单方法是使用'forEach',它会复制数组。 – 2014-08-29 09:04:54

+0

谢谢,它仍然产生了一个错误,直到我添加了arr.shift()。现在它按预期工作。 – 2014-08-29 09:37:37

回答

3

请使用此代码

var fullArr = [];//contains all items 
var remArr = [];//contains removed items 
var userAnswer = true;//this would be user input 

populateArray(); 
runTenTimes(); 
//getting the answer right 10 times should result in fullArr.length = 0; remArr.length = 100; 

function runTenTimes(){ 
    for(var i=0;i<10;i++){ 
    //console.log(i); 
    checkUserAnswer(); 
    } 
} 
function populateArray(){ 
    for(var i=0;i<100;i++){ 
     fullArr.push(i); 
    } 
} 

function checkUserAnswer(){ 
    if(userAnswer){//only if true 
     var arrCopy = fullArr.slice(0); 
     for(i=0;i<10;i++){//10 because I remove 10 at a time 
      removeShape(fullArr,arrCopy[i],remArr); 
     } 
    }else{ 
      // add elements from remove arr 
      // back into full array 
    } 
    console.log("full array : " + fullArr.length); 
    console.log("remove array : " + remArr.length); 
    console.log("------------------") 
} 

function removeShape(arr,item,rem){ 
     for(var i = 0;i<arr.length; i++) { 
      if(arr[i] === item) { 
      rem.push(arr[i]); 
      arr.splice(i, 1); 
      } 
     } 
} 
+0

那正是我想要做的。它不会对数组中的对象产生任何引用错误。非常感谢!!!! – 2014-08-29 10:27:36

0

改变到的forEach仍然产生的误差,直到我改变arr.shift()而不是arr.splice(I,0)。

function removeShape(arr,item,rem){ 
     arr.forEach(function(){ 
     if(arr[i] === item) { 
      rem.push(arr.shift()); 
      } 
     }) 
}