计算字符串中字符的频率C++

Question

我正在计算字符串输入中字母的频率。我遇到了一些麻烦，我不完全知道我做错了什么。我收到奇怪的输出，比如笑脸。我希望我的代码做这样的事情，如果字符串是 “abcdc” 一个 - 1 b - 1 ç - 2 d - 1

 #include <iostream> 
using namespace std; 




class moose 
{ 
    char inputbuffer[132]; 
    char countbuffer[122]; 
    long count; 
    short index = 0; 
public: 
    char charcount(); 
    char charinput(); 
    char initialize(); 

}; 

int main() 
{ 
    moose obj; 
    obj.initialize(); 
    obj.charinput(); 
    obj.charcount(); 
    system("pause"); 

} 


char moose::initialize() 
{ 
    for (int i = 0; i < 122; i++) 
     countbuffer[i] = 0; 
    return 0; 

} 

char moose::charinput() 
{ 
    cout << "Enter your text and I'll read your characters" << endl; 
    cin.getline(inputbuffer, 132); 
    cin.gcount(); 
    count = cin.gcount(); 
    count--; 
    return 0; 
} 

char moose::charcount() 
{ 
    for (int i = 0; i < count; i++) 
    { 
     if (inputbuffer[i] >= 'a' & inputbuffer[i] <= 'z') { 
      index = inputbuffer[i]; 
      countbuffer[index]++; 

     } 
     for (i = 0; i < count; i++) 
     { 
      cout << inputbuffer[i] << " - " << countbuffer[index] << endl; 
     } 
    } 




    return 0; 
} 

Answer 1

你的代码的几个问题：

1. moose::charinput()方法包含额外的电话gcount()。您只需要这样的陈述：count = cin.gcount();。 count--;也不应该在那里。

2. 内部moose::charcount()条件必须是

   if (inputbuffer[i] >= 'a' && inputbuffer[i] <= 'z') 
   

3. 的moose::charcount()应具有两个不同的循环：

   char moose::charcount() 
       { 
        for (int i = 0; i < count; i++) 
        { 
         if (inputbuffer[i] >= 'a' && inputbuffer[i] <= 'z') { 
          index = inputbuffer[i]; 
          countbuffer[index]++; 
         } 
        } 
        for (i = 0; i < count; i++) 
        { 
         cout << inputbuffer[i] << " - " << countbuffer[inputbuffer[i]] << endl; 
        } 
        return 0; 
       } 
   

4. countbuffer都将被声明为int到正确打印