方法返回后内存被破坏

Question

我知道我只是想念一些愚蠢的东西，但我很沮丧，我只是看不到它。当我对下面的代码运行3个字段的文件“field1; field2; field3”时，这些任务在retrieveTasks方法中正确输出。当该方法返回到主输出已损坏。我知道这很愚蠢，我只是想念它。我已经尝试将CourseName，TaskDescription等改为数组而不是char *。我曾尝试传递fileString作为char *，我已经尝试过使用strcpy而不使用。任何人都可以指出我的方向吗？

const int MAX_STRING_LENGTH = 101; 
const int MAX_TASK_ITEMS = 255; 
const char NEWLINE = '\n'; 
const char DELIMETER[] = ";"; 
const char FILENAME[] = "tasks.txt"; 

struct Task { 
    char* CourseName; 
    char* TaskDescription; 
    char* DueDate; 
    char FileString[300]; 

    void printTask() { 
    cout << CourseName << DELIMETER << TaskDescription << DELIMETER << DueDate << endl; 
    } 

    void initializeFromFileString(char fileString[]) { 
    strcpy(FileString, fileString); 
    CourseName = strtok(FileString, DELIMETER); 
    TaskDescription = strtok(NULL, DELIMETER); 
    DueDate = strtok(NULL, DELIMETER); 
    } 
}; 

struct TaskList { 
    Task Tasks[MAX_TASK_ITEMS]; 
    int TaskCount; 

    void initialize() { 
    TaskCount = 0; 

    return; 
    } 

    void addTask(Task task) { 
    Tasks[TaskCount] = task; 
    TaskCount++; 

    return; 
    } 

    void printTasks() { 
    for(int TaskNum = 0; TaskNum < TaskCount; TaskNum++) { 
     cout << TaskNum + 1 << ".  "; 
     Tasks[TaskNum].printTask(); 
     cout << endl; 
    } 

    return; 
    } 

    // Load data from the file. Will return -1 if it fails for any reason. 
    // Otherwise it returns the number of records read. 
    int retrieveTasks(const char* fileName) { 
    int isSuccessfulOpen = 0; 
    int recordsRead = 0; 
    ifstream inFile; 

    isSuccessfulOpen = openFile(inFile, fileName); 

    if(!isSuccessfulOpen) { 
     return -1; 
    } 

    // Read input file and store in appropriate arrays 
    while(inFile.eof() == false) { 
     char fileLine[MAX_STRING_LENGTH * 3]; 
     Task task; 

     inFile.getline(fileLine, MAX_STRING_LENGTH * 3, NEWLINE); 
     inFile.ignore(UINT_MAX, NEWLINE); 
     task.initializeFromFileString(fileLine); 
     addTask(task); 
     recordsRead++; 
    } 
    inFile.close(); 

    return recordsRead; 
    } 
}; 

int main() { 
    bool isFinished = false; 
    TaskList taskList; 

    taskList.initialize(); 
    taskList.retrieveTasks(FILENAME); 
    taskList.printTasks(); 

    return 0; 
} 



int openFile(ifstream& inFile, const char* fileName) { 
    inFile.open(fileName); 

    // Veryify that the file is valid. If not print error message. 
    if(inFile.is_open() == false) { 
    cout << "File " << fileName << " does not exist. Please provide a valid file path." << endl; 
    return 0; 
    } 

    return 1; 
} 

// Open file for writing 
int openFile(ofstream& outFile, const char* fileName) { 
    outFile.open(fileName); 

    // Veryify that the file is valid. If not print error message and exit. 
    if(outFile.is_open() == false) 
    { 
    cout << "File " << fileName << " does not exist. Please provide a valid file path." << endl; 
    return 0; 
    } 

    return 1; 
} 

Answer 1

CourseName，TaskDescription，DueDate都指向存储器存在于while循环中创建的对象task在数组中。由于这个task对象是本地作用域，因此一旦retrieveTasks已经完成执行，它们就会包含垃圾。

变化需要

1. 你TaskCount始终保持比数多一个 - 因此这需要由1

   for(int TaskNum = 0; TaskNum < TaskCount; TaskNum++) { 
   

   减少改为

   for(int TaskNum = 0; TaskNum < TaskCount -1 ; TaskNum++) { 
   

2. 删除while循环中的任务对象。

3. AddTask需要一个char *而不是Task。 AddTask调用initializeFromFileString以便strcpy完成对数组的Task对象中的字符串。而strtok也叫这个字符串

4. 变化

   while(inFile.eof() == false) { 
   

   到

   while(inFile) { 
   

5. 删除

   inFile.ignore(UINT_MAX, NEWLINE); 
   

固定码

struct Task { 
    char* CourseName; 
    char* TaskDescription; 
    char* DueDate; 
    char FileString[300]; 

    void printTask() { 
    cout << CourseName << DELIMETER << TaskDescription << DELIMETER << DueDate << endl; 
    } 

    void initializeFromFileString(char fileString[]) { 
    strcpy(FileString, fileString); 
    CourseName = strtok(FileString, DELIMETER); 
    TaskDescription = strtok(NULL, DELIMETER); 
    DueDate = strtok(NULL, DELIMETER); 
    } 

}; 



int openFile(ifstream& inFile, const char* fileName) { 
    inFile.open(fileName); 

    // Veryify that the file is valid. If not print error message. 
    if(inFile.is_open() == false) { 
    cout << "File " << fileName << " does not exist. Please provide a valid file path." << endl; 
    return 0; 
    } 

    return 1; 
} 

// Open file for writing 
int openFile(ofstream& outFile, const char* fileName) { 
    outFile.open(fileName); 

    // Veryify that the file is valid. If not print error message and exit. 
    if(outFile.is_open() == false) 
    { 
    cout << "File " << fileName << " does not exist. Please provide a valid file path." << endl; 
    return 0; 
    } 

    return 1; 
} 

struct TaskList { 
    Task Tasks[MAX_TASK_ITEMS]; 
    int TaskCount; 

    void initialize() { 
    TaskCount = 0; 

    return; 
    } 

    void addTask(char * t) { 
    Tasks[TaskCount].initializeFromFileString(t); 
    TaskCount++; 

    return; 
    } 

    void printTasks() { 
    for(int TaskNum = 0; TaskNum < TaskCount - 1; TaskNum++) { 
     cout << TaskNum + 1 << ".  "; 
     Tasks[TaskNum].printTask(); 
     cout << endl; 
    } 

    return; 
    } 

    // Load data from the file. Will return -1 if it fails for any reason. 
    // Otherwise it returns the number of records read. 
    int retrieveTasks(const char* fileName) { 
    int isSuccessfulOpen = 0; 
    int recordsRead = 0; 
    ifstream inFile; 

    isSuccessfulOpen = openFile(inFile, fileName); 

    if(!isSuccessfulOpen) { 
     return -1; 
    } 

    // Read input file and store in appropriate arrays 
    while(inFile) { 
     char fileLine[MAX_STRING_LENGTH * 3]; 

     inFile.getline(fileLine, MAX_STRING_LENGTH * 3, NEWLINE); 

     addTask(fileLine); 
     printTasks(); 

     recordsRead++; 
    } 
    inFile.close(); 

    return recordsRead; 
    } 
}; 

很明显，如果你在C++写的，而不是在C inside classes写它的这整个程序将更简单且不易出错。