Segmentation Fault 11，C

Question

我一直试图在C中实现一个LinkedList以实际实现我在C中学到的理论。我一直得到一个Segmentation fault: 11.任何有关如何解决这个问题的帮助将不胜感激。这里是我的代码：

#include <stdio.h> 
#include <stdlib.h> 

struct Element { 
    int value; 
    struct Element *nextElement; 
}; 

struct LinkedList { 
    struct Element *firstElement; 
}; 

void add(struct LinkedList *list, int value) { 
    if(list->firstElement == NULL) { 
     struct Element *newElement; 
     newElement = malloc(sizeof(struct Element)); 

     newElement->value = value; 

     list->firstElement = newElement; 
    } else { 
     struct Element *lastElement; 

     lastElement = list->firstElement; 

     while(lastElement->nextElement != NULL) { 
      lastElement = lastElement->nextElement; 
     } 

     struct Element *newElement; 
     newElement = malloc(sizeof(struct Element)); 

     newElement->value = value; 

     lastElement->nextElement = newElement; 
    } 
} 

void showAllElements(struct LinkedList *list) { 
    struct Element *lastElement = list->firstElement; 

    while(lastElement != NULL) { 
     printf("%d\n", lastElement->value); 
     lastElement = lastElement->nextElement; 
    } 
} 

int main() 
{ 
    struct LinkedList list; 
    add(&list, 5); 
    add(&list, 10); 
    add(&list, 15); 
    showAllElements(&list); 

    return 0; 
} 

Answer 1

所以，你的代码有几个问题。 struct LinkedList list未分配。当你做list->firstElement时它会出错。与

struct LinkedList list = {NULL}

而且newElement初始化它不会给nextElement。您还需要将其设置为NULL，否则在访问时会出错。

struct Element *newElement; 
    newElement = malloc(sizeof(struct Element)); 

    newElement->value = value; 
    newElement->nextElement = NULL;