while ...循环在if语句公用静态方法后结束C＃

Question

我在循环“while”的公共静态方法中编写了一些代码。但是这个循环在“if”语句之后结束，并且应用程序不会抛出任何异常。这里是代码：

public static void ShortcutDetect() 
{ 
    ShortkeyIndex = 0; 
    while(ShortkeyIndex < 1000) 
    { 
     File.WriteAllText(@"C:\Users\OEM\Desktop\log.txt", 
      File.ReadAllText(@"C:\Users\OEM\Desktop\log.txt") + Convert.ToString(ShortkeyIndex)); 
     if(Program.key.Replace("LShiftKey","Shift") 
      .Replace("RShiftKey","Shift").Replace("RMenu","Alt") 
      .Replace("LMenu","Alt").Replace("RControlKey","Ctrl") 
      .Replace("LControlKey","Ctrl").EndsWith(RawShortkeys[ShortkeyIndex])) 
     { 
      MessageBox.Show(RawShortkeys[ShortkeyIndex]); 
     } 
     ShortkeyIndex++; 
    } 
} 

事先感谢。

Answer 1

我们只是实现它的权利：

public static void ShortcutDetect() { 
    // Take loop independent code out of the loop: 
    // and, please, format it out: 
    var source = Program.key 
    .Replace("LShiftKey", "Shift") 
    .Replace("RShiftKey", "Shift") 
    .Replace("RMenu", "Alt") 
    .Replace("LMenu", "Alt") 
    .Replace("RControlKey", "Ctrl") 
    .Replace("LControlKey", "Ctrl"); 

    // Wrong type of loop (while): what is ShortkeyIndex? 
    // where has it been declared, why 1000? 
    // Please, have a look how the right loop easy to implement and read 
    foreach (var item in RawShortkeys) { 
    // Debug: let's output item onto Console 
    // Console.WriteLine(item); 
    // Debug: ...or in the file 
    // File.AppendAllText()@"C:\Users\OEM\Desktop\log.txt", " " + item); 

    if (source.EndsWith(item)) // <- put a break point here, inspect item's 
     MessageBox.Show(item); 
    } 
}