我有一个方法是从sqlite数据库中读取一些信息并初始化一个名为Achievement的类。当我分析这段代码时,我得到的反馈是“对象多次发送autorelease”。我真的不明白我的错在哪里 - 为什么retval对象在第225行释放,而不是第229行的return语句?iOS - 对象发送autorelease太多次
有人可以解释我在下面的代码中犯了什么错误,以及我如何解决它?
功能代码(这样回答者可以轻松地复制/粘贴):
- (Achievement *)getAchievement:(int)Id
{
Achievement *retval = [[Achievement alloc] autorelease];
NSString *query = [NSString stringWithFormat:@"SELECT * FROM Achievements where ID = %d", Id];
sqlite3_stmt *statement;
if (sqlite3_prepare_v2(_database, [query UTF8String], -1, &statement, nil)
== SQLITE_OK) {
while (sqlite3_step(statement) == SQLITE_ROW) {
int Id = sqlite3_column_int(statement, 0);
char *name = (char *) sqlite3_column_text(statement, 1);
char *title = (char *) sqlite3_column_text(statement, 2);
char *description = (char *) sqlite3_column_text(statement, 3);
Boolean Achieved;
char *com = (char *) sqlite3_column_text(statement, 4);
NSString *c1 = [[[NSString alloc] initWithUTF8String:com] autorelease];
Achieved = [c1 isEqualToString:@"1"];
NSDate *CompletedDate = (NSDate *) sqlite3_column_text(statement, 5);
char *icon = (char *) sqlite3_column_text(statement, 6);
int New = sqlite3_column_int(statement, 7);
NSString *Title = [[[NSString alloc] initWithUTF8String:title] autorelease];
NSString *Description = [[[NSString alloc] initWithUTF8String:description] autorelease];
NSString *Name = [[[NSString alloc] initWithUTF8String:name] autorelease];
NSString *Icon = [[[NSString alloc] initWithUTF8String:icon] autorelease];
retval = [retval initDetails:Id :Name :Title: Description : Achieved : CompletedDate: Icon: New];
}
sqlite3_finalize(statement);
}
return retval;
}
分析反馈的图像:
一如往常的任何反馈非常感谢。
感谢Max,while只会被迭代一次(SQL将只返回一行)。我在循环中初始化它,因为从db调用返回的值在那里可用。你如何建议我重新安排功能? – MattStacey 2012-02-19 13:46:05