VBA代码效率 - 优秀范围

我有一个代码，我在下面运行，这工作正常。VBA代码效率 - 优秀范围

问题：是否有更高效的方法来编写此代码？（短）

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean) 
    If Not Intersect(Target, Range("D24")) Is Nothing Then 
       Sheet2.Range("D24") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D20")) Is Nothing Then 
       Sheet2.Range("D20") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D25")) Is Nothing Then 
       Sheet2.Range("D25") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D27")) Is Nothing Then 
       Sheet2.Range("D27") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D28")) Is Nothing Then 
       Sheet2.Range("D28") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D30")) Is Nothing Then 
       Sheet2.Range("D30") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D31")) Is Nothing Then 
       Sheet2.Range("D31") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 
    End If 
    If Not Intersect(Target, Range("D32")) Is Nothing Then 
       Sheet2.Range("D32") = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 

End Sub

来源

2017-09-01 James

您可以存储地址D20，D24，D25 ..在数组中。然后遍历数组。 –

这应该在codereview中发布，而不是作为代码工作。 –

假设文本不在同一张纸上，这个？

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean) 

If Intersect(Target, Range("D20,D24,D25,D27,D28,D30,D31,D32")) Is Nothing Then Exit Sub 
'Cancel=True 
Sheet2.Range(Target.Address).Value = "Prepared By" & " " & Environ("Username") & " " & Format(Now(), "yyyy-MM-dd hh:mm:ss") 

End Sub

来源

2017-09-01 11:11:43 SJR

非常感谢你完美的作品 – James

另一种选择，而无需使用交集：

Option Explicit 

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean) 

    With Target 
     If .Column = 4 Or .Column = 5 Then 
      Select Case .Row 
       Case 20, 24, 25, 27 To 28, 30 To 32 

        Application.EnableEvents = False 

        .Value2 = "Prepared By" & " " & Environ("Username") 
        .Value2 = .Value2 & " " & Format(Now, "yyyy-MM-dd hh:mm:ss") 

        Application.EnableEvents = True 

      End Select 
     End If 
    End With 
End Sub

来源

2017-09-01 11:39:02

我喜欢那样，它比我的更优雅（而且更高效？）。 – SJR

我喜欢它运作良好。还有一个问题。我如何将这段代码应用到第4列和第5列？ @paulbica – James

@James - 我将它更新为'If .Column = 4或.Column = 5 Then' –

VBA代码效率 - 优秀范围

回答

相关问题