日期时间变量的动态sql语法问题

Question

对于此代码，当我引入2个日期变量时出现错误代码错误。

错误是

Msg 137, Level 15, State 1, Line 8 
Must declare the scalar variable "@STARTDATE". 
Msg 137, Level 15, State 1, Line 9 
Must declare the scalar variable "@ENDDATE". 

任何想法如何克服这个作为我的大脑现在是正式死了吗？

DECLARE 
    @Query1 AS NVARCHAR(MAX), 
    @Startdate DATETIME, 
    @Enddate DATETIME 

SET @STARTDATE = '10-JAN-2012' 
SET @ENDDATE = '11-JAN-2012' 

SET @Query1 = ' 

;WITH CTE AS 
(
    select COALESCE(PT.[description] , ''Grand Total'') AS [Transaction Type], 
      Sum (AI.PRICE_INC_VAT) AS [AMOUNT (ú) CREDIT], 
      P.[DESCRIPTION] AS [PRODUCT TYPE] 

From [dbo].[T1] C 
join [dbo].[T2] S on S.[Customer_ID]=C.[Customer_ID] 
join [dbo].[T3] SO on SO.[SITE_ID]=S.[SITE_ID] 
join [dbo].[T4] OI on OI.[ORDER_ID]=SO.[SITE_ORDER_ID] 
left join [dbo].[T5] P on P.[PRODUCT_ID]=OI.[PRODUCT_ID] 
JOIN [dbo].[T6] AI ON AI.ORDER_ITEM_ID = OI.ORDER_ITEM_ID 
JOIN [T7] JBAI ON JBAI.ACTION_ITEM_ID = AI.ACTION_ITEM_ID 
JOIN T8 JB ON JB.JOB_BATCH_ID = JBAI.JOB_BATCH_ID 
JOIN [T9] PA on PA.PAYMENT_ID=JB.PAYMENT_ID 
LEFT JOIN [T10] CU ON JB.CUSTOMER_USER_ID = CU.CUSTOMER_USER_ID 
JOIN [T11] PT ON PT.PAYMENT_TYPE_ID=PA.PAYMENT_TYPE_ID 
LEFT JOIN [T12] ON SU.SYS_USER_ID=JB.SYS_USER_ID 

where P.[PRODUCT_CATEGORY_ID]= ''PADS'' 
    and C.COMPANY_ID= ''19992'' 
    and PA.DATE_RECEIVED BETWEEN @Startdate AND @Enddate 

group by PT.DESCRIPTION, P.DESCRIPTION 
)' 

Answer 1

您的参数超出了您的SQL查询范围。您需要将参数传递给sql字符串。你会发现，你还必须投下的参数作为varchar所以它可以连接在一起字符串：

DECLARE 
    @Query1 AS NVARCHAR(MAX), 
    @Startdate DATETIME, 
    @Enddate DATETIME 

SET @STARTDATE = '10-JAN-2012' 
SET @ENDDATE = '11-JAN-2012' 

SET @Query1 = ' 

;WITH CTE AS 
(
    select COALESCE(PT.[description] , ''Grand Total'') AS [Transaction Type], 
      Sum (AI.PRICE_INC_VAT) AS [AMOUNT (ú) CREDIT], 
      P.[DESCRIPTION] AS [PRODUCT TYPE] 

From [dbo].[T1] C 
join [dbo].[T2] S on S.[Customer_ID]=C.[Customer_ID] 
join [dbo].[T3] SO on SO.[SITE_ID]=S.[SITE_ID] 
join [dbo].[T4] OI on OI.[ORDER_ID]=SO.[SITE_ORDER_ID] 
left join [dbo].[T5] P on P.[PRODUCT_ID]=OI.[PRODUCT_ID] 
JOIN [dbo].[T6] AI ON AI.ORDER_ITEM_ID = OI.ORDER_ITEM_ID 
JOIN [T7] JBAI ON JBAI.ACTION_ITEM_ID = AI.ACTION_ITEM_ID 
JOIN T8 JB ON JB.JOB_BATCH_ID = JBAI.JOB_BATCH_ID 
JOIN [T9] PA on PA.PAYMENT_ID=JB.PAYMENT_ID 
LEFT JOIN [T10] CU ON JB.CUSTOMER_USER_ID = CU.CUSTOMER_USER_ID 
JOIN [T11] PT ON PT.PAYMENT_TYPE_ID=PA.PAYMENT_TYPE_ID 
LEFT JOIN [T12] ON SU.SYS_USER_ID=JB.SYS_USER_ID 

where P.[PRODUCT_CATEGORY_ID]= ''PADS'' 
    and C.COMPANY_ID= ''19992'' 
    and PA.DATE_RECEIVED BETWEEN '+ convert(varchar(10), @Startdate, 120) 
    + ' AND '+ convert(varchar(10), @Enddate, 120) +' 

group by PT.DESCRIPTION, P.DESCRIPTION 
)' 

我不知道为什么你使用动态SQL这个过程虽然。

;WITH CTE AS 
(
    select COALESCE(PT.[description] , 'Grand Total') AS [Transaction Type], 
      Sum (AI.PRICE_INC_VAT) AS [AMOUNT (ú) CREDIT], 
      P.[DESCRIPTION] AS [PRODUCT TYPE] 

From [dbo].[T1] C 
join [dbo].[T2] S on S.[Customer_ID]=C.[Customer_ID] 
join [dbo].[T3] SO on SO.[SITE_ID]=S.[SITE_ID] 
join [dbo].[T4] OI on OI.[ORDER_ID]=SO.[SITE_ORDER_ID] 
left join [dbo].[T5] P on P.[PRODUCT_ID]=OI.[PRODUCT_ID] 
JOIN [dbo].[T6] AI ON AI.ORDER_ITEM_ID = OI.ORDER_ITEM_ID 
JOIN [T7] JBAI ON JBAI.ACTION_ITEM_ID = AI.ACTION_ITEM_ID 
JOIN T8 JB ON JB.JOB_BATCH_ID = JBAI.JOB_BATCH_ID 
JOIN [T9] PA on PA.PAYMENT_ID=JB.PAYMENT_ID 
LEFT JOIN [T10] CU ON JB.CUSTOMER_USER_ID = CU.CUSTOMER_USER_ID 
JOIN [T11] PT ON PT.PAYMENT_TYPE_ID=PA.PAYMENT_TYPE_ID 
LEFT JOIN [T12] ON SU.SYS_USER_ID=JB.SYS_USER_ID 

where P.[PRODUCT_CATEGORY_ID]= 'PADS' 
    and C.COMPANY_ID= '19992' 
    and PA.DATE_RECEIVED BETWEEN @Startdate AND @Enddate 

group by PT.DESCRIPTION, P.DESCRIPTION 
) 

Answer 2

如果确实需要动态SQL，你应该做到以下几点：这可以在不使用动态SQL可以容易地进行

-- USE UNAMBIGUOUS FORMATS PLEASE! 

SET @STARTDATE = '20120110'; 
SET @ENDDATE = '20120111'; 

SET @Query1 = ';WITH CTE AS 
... 
    and PA.DATE_RECEIVED BETWEEN @STARTDATE AND @ENDDATE 
    group by PT.DESCRIPTION, P.DESCRIPTION 
)'; 

EXEC sp_executesql 
    @Query1, 
    N'@STARTDATE DATETIME, @ENDDATE DATETIME', 
    @STARTDATE, @ENDDATE; 

但是除非我失去了一些东西没有必要在这里为动态SQL。