2016-10-30 98 views
0

所以我想创建一个改变记录时间戳的触发,我有这个迄今为止的Oracle SQL触发错误:ORA-00933

create or replace TRIGGER job_date_set 
     AFTER INSERT OR UPDATE OF start_date, closing_date ON jobs 
     FOR EACH ROW 
    BEGIN 
     IF UPDATING THEN 
     CASE 
      WHEN :OLD.closing_date != :NEW.closing_date THEN 
      UPDATE jobs 
      SET closing_date = to_date(to_date(:NEW.closing_date,'DD/MON/YYYY')||' 23:59:59','DD/MON/YYYY HH24:MI:SS') 
      WHERE :OLD.job_id = job_id; 
      WHEN :OLD.start_date != :NEW.start_date THEN 
      UPDATE jobs 
      SET start_date = to_date(to_date(:NEW.start_date,'DD/MON/YYYY') ||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
      WHERE :OLD.job_id = job_id; 
     END CASE; 
     END IF; 
     IF INSERTING THEN 
     UPDATE jobs 
     SET closing_date = to_date(to_date(:NEW.closing_date,'DD/MON/YYYY') ||' 23:59:59','DD/MON/YYYY HH24:MI:SS') 
     SET start_date = to_date(to_date(:NEW.start_date,'DD/MON/YYYY')||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
     WHERE :OLD.job_id = job_id; 
     END IF; 
    END; 

这里是错误的描述: 编译失败,第17行(16:54:27)与编译错误关联的行号与第一个BEGIN语句相关。这只影响数据库触发器的编译。 PL/SQL:ORA-00933:SQL命令未正确结束编译失败,第15行(16:54:27)与编译错误关联的行号与第一个BEGIN语句相关。这只影响数据库触发器的编译。 PL/SQL:SQL语句忽略

通过它的声音,它不认为我的if语句已经关好,但我不知道在哪里,我出了错

+1

它看起来像jobs.closing_date和jobs.start_date是'日期'列。如果是这样,你的'to_date(to_date('应该是'to_date(to_char(' - 你想把日期转换成DD/MON/YYYY格式的字符串以便追加''23:59:59'并将其转换回日期(可能更容易“trunc”它,加1并减去'interval'1'秒。) –

回答

1

相反的:

UPDATE jobs 
    SET closing_date = to_date(to_date(:NEW.closing_date,'DD/MON/YYYY') ||' 23:59:59','DD/MON/YYYY HH24:MI:SS') 
    SET start_date = to_date(to_date(:NEW.start_date,'DD/MON/YYYY')||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
    WHERE :OLD.job_id = job_id; 

是:

UPDATE jobs 
    SET closing_date = to_date(to_date(:NEW.closing_date,'DD/MON/YYYY') ||' 23:59:59','DD/MON/YYYY HH24:MI:SS'), 
     start_date = to_date(to_date(:NEW.start_date,'DD/MON/YYYY')||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
    WHERE :OLD.job_id = job_id; 

即有一个逗号而不是第二个SET关键字。

+0

这是错误。谢谢 – Zachary

1

当你修改在触发器定义的表格上,您需要在更新触发器之前的。所以,这样的事情:

create or replace TRIGGER job_date_set 
    BEFORE INSERT OR UPDATE OF start_date, closing_date ON jobs 
    FOR EACH ROW 
BEGIN 
    IF UPDATING THEN 
    CASE 
     WHEN :OLD.closing_date <> :NEW.closing_date THEN 
     SELECT to_date(to_date(:NEW.closing_date,'DD/MON/YYYY')||' 23:59:59','DD/MON/YYYY HH24:MI:SS') 
     INTO :NEW.closing_date 
     FROM dual; 
     WHEN :OLD.start_date <> :NEW.start_date THEN 
     SELECT to_date(to_date(:NEW.start_date,'DD/MON/YYYY') ||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
     INTO :NEW.start_date 
     FROM dual; 
    END CASE; 
    END IF; 
    IF INSERTING THEN 
    SELECT to_date(to_date(:NEW.closing_date,'DD/MON/YYYY') ||' 23:59:59','DD/MON/YYYY HH24:MI:SS'), 
      to_date(to_date(:NEW.start_date,'DD/MON/YYYY')||' 00:00:00','DD/MON/YYYY HH24:MI:SS') 
    INTO :NEW.closing_date, :NEW.start_date; 
    END IF; 
END; 
+0

我想我的计划是在插入之前有一个触发器插入一个自动增量,所以我不得不编辑日期后,你认为将这些代码合并到触发器中还是有两个单独的触发器执行两项不同的任务会更好? – Zachary