更好的处理字典的名单或改善我的代码

Question

方式我有一个字典

my_dict = 
    { '123@com' : [ { 'event': 'event1', 'oldval' = 1, 'newval = 2}, { 'event': 'event2', 'oldval' = 11, 'newval': 22}, { 'event': 'event3', 'oldval' = 33, 'newval': 44}] 
    {'1234@com' : { 'event1': 'oldval': 45, 'newval': 66}, 
    {'12345@com': [ {'event':'event2', 'oldval': 77, 'newval': 99}, { 'event': 'event3', 'oldval': '99', 'newval': 100'}] 

所以基本上我的目标是建立一个列表

[ ['123@com', (2,1,True), (22,11, True), (44,33,True)], ['1234@com', (66,45,True), ('','',False),('','',False)], ['12345@com', ('',''False), (99,77,True), (100,99)]] 

所以我的目标是夺取如果该值事件被更改并获取值并标记为true。

所以其我写的代码如下：

for key,value in my_dict.items(): 
    if str(my_dict).find('event1') >- 1 or str(my_dict).find('even2') > 1 or str(my_dict).find('event3') > -1: 
    tmp_list = [] 
    tmp_list.append(key) 
    if type(value) is dict: 
    if value['event'] == 'event1': 
     @ get all the value and append to tmp_list 
    if value['event'] == 'event2': 
     @ do the same thing as above 
    else: 
    for val in value: 
     if val['name'] == 'event': 
     @ do the same stuff. 
     @do the same stuff again for rest of event. 

所以基本上我能够按照上面的代码模式来实现我的目标。

所以任何人都可以帮助我更好地编码，我会非常感激。 我不喜欢我编码的方式。

感谢

Answer 1

具有异质名单像['123@com', (2,1,True), (22,11, True), (44,33,True)]是一个代码味道。它几乎总是意味着你试图用简单的数据类型做太多事情，并且实际上使用一个类可能会更好。假设Python的2.X：

class Event(object): 
    def __init__(self, event, oldval, newval): 
     self.event = event 
     self.oldval = oldval 
     self.newval = newval 

class EventThing(object): 
    def __init__(self, key, event_list): 
     self.key = key 
     self.event_list = [Event(**e) for e in event_list] 

    def produceCondensedList(self): 
     return [(e.oldval, e.newval, True) for e in self.event_list] 

thing_list = [EventThing(key, event_list) for key, event_list in my_dict.items()] 

这是不完全一样的，你给的例子，但不知道更多关于你的确切使用情况下，很难精确提示答案。上面的内容应该足以让你开始。

Answer 2

这是我可以考虑编码的最佳方式。

def value_finder(val): 
    return lambda ev,li: next((di[val] for di in li if di['event']==ev),'') 

def event_finder(ev,li): 
    return any(di['event']==ev for di in li) 

def tuple_return(ev,li,nv,ov): 
    return (nv(ev,li),ov(ev,li),event_finder(ev,li)) 

def main(my_dict): 
    lis = [] 
    nv = value_finder('newval') 
    ov = value_finder('oldval') 
    events = ['event1','event2','event3'] 
    for key,value in my_dict.items(): 
     temp_list = [key] 
     temp_list += [tuple_return(ev,value) for ev in events] 
     lis.append(temp_list) 
    print lis 

my_dict = {'123@com':[{'event':'event1','oldval':1,'newval':2}, 
         {'event':'event2','oldval':11,'newval':22}, 
         {'event':'event3','oldval':33,'newval':44}], 
      '1234@com':[{'event':'event1','oldval':45,'newval':66}], 
      '12345@com':[{'event':'event2','oldval': 77,'newval': 99}, 
         {'event':'event3','oldval':'99','newval':100}]} 
main(my_dict)