2011-02-07 54 views
1

以下是带脚本的页面链接。 http://signsourceak.com/index1.html一些简单的脚本。可以看到有什么问题

这是我的脚本,由于某些原因,所有的功能用鼠标放在外面。谁能告诉我我的脚本有什么问题

window.onload = sliding; 
var tags = new Array('tag1','tag2','tag3','tag4','tag5','tag6','tag7','tag8');// List of headings 
var pics = new Array('popout1','popout2','popout3','popout4','popout5','popout6','popout7','popout8');// list of images that slide out 

function sliding(){ // assing event 
    for(var i=0; i< tags.length; i++){ 
     document.getElementById(tags[i]).onmouseover = slideout(tags[i],pics[i]); // <-- The Problem is Here Function runs with out the actual event 
     document.getElementById(tags[i]).onmouseout = slidein(tags[i],pics[i]); 
    //alert('this worked,'+ tags[i] + pics[i]); 
    } 
} 

function slideout(hid,picid){ 
    document.images[picid].style.visibility = "visible"; 
    document.images[picid].style.MozOpacity = 0.7;// need browser compatability 
    moveout(hid,picid); 
} 

function moveout(hid,picid){ 
    if(currpos(picid) > 0){ 
     document.images[picid].style.top = currpos(picid) - 1 + "px"; 
     setTimeout(moveout,10); 
    }else{ 
     clearTimeout(moveout); 
    } 

    function currpos(element){ 
     return document.getElementById(element).offsetTop; 
    } 
} 

function slidein(hid,picid){ 
    document.images[picid].style.MozOpacity = 0.5;// need browser compatability 
    movein(hid,picid); 
} 

function movein(hid,picid){ 
    if(currpos(picid) < 210){ 
     document.images[picid].style.top = currpos(picid) + 1 + "px"; 
     setTimeout(movein,10); 
    }else{ 
     clearTimeout(movein); 
     document.images[picid].style.visibility = "hidden"; 
    } 

    function currpos(element){ 
     return document.getElementById(element).offsetTop; 
    } 
} 
+0

在每行之前使用4个空格,您的代码在stackoverflow中突出显示它。 – Syl 2011-02-07 16:43:48

回答

0

您正在将slideout()和slidein()的结果分配为处理程序。您还需要隔离闭包变量;自我调用函数将确保i循环变量不被所有事件处理程序共享

function sliding(){ // assing event 
    for(var i=0; i< tags.length; i++){ 

     document.getElementById(tags[i]).onmouseover =(function(index){ 
      return function() { 
       slideout(tags[index],pics[index]); 
      } 
     })(i); 

     document.getElementById(tags[i]).onmouseout = (function(index){ 
      return function() { 
       slidein(tags[index],pics[index]); 
      } 
     })(i); 
    } 
} 
+0

什么是闭包变量 – Ross 2011-02-08 18:49:30

1

那不是如何使用clearTimeOut。

的setTimeout返回要传递给clearTimeOut定时器ID:

var timer = setTimeout(fn, 10); 
clearTimeout(timer); 
0

的一个问题是在这里:

function sliding(){ // assing event 
    for(var i=0; i< tags.length; i++){ 
     document.getElementById(tags[i]).onmouseover = slideout(tags[i],pics[i]); // <-- The Problem is Here Function runs with out the actual event 
     document.getElementById(tags[i]).onmouseout = slidein(tags[i],pics[i]); 
    //alert('this worked,'+ tags[i] + pics[i]); 
    } 
} 

在这种循环中,你调用的 “滑出式”和“滑动”功能,但显然这不是你想要做的。你想想要是分配一个函数,调用“滑出”或“滑入”适当的方式。要做到这一点,你需要的功能另一层:

function makeHandlers(index) { 
    return { 
    'out': function() { slideout(tags[index], pics[index]; }, 
    'in': function() { slidein(tags[index], pics[index]; } 
    }; 
} 

function sliding() { 
    for (var i = 0; i < tags.length; ++i) { 
    var handlers = makeHandlers(i), tag = document.getElementById(tags[i]); 
    tag.onmouseover = handlers.in; 
    tag.onmouseout = handlers.out; 
    } 
} 

由于@BiAiB笔记,你的电话到“的setTimeout”和“clearTimeout”需要一定的关注了。