我可以简化这个VB.net代码吗，所以我不必重复这么多？

Question

我正在创建一个调度算法。我的代码变得很长。任何人都可以建议我怎样才能让我的代码更短，因为我必须在下面多次重复相同的事情，而外部的其他位置是4或5，我必须重复更多：

下面是我的部分示例代码：

ElseIf Val(jobs_txt.Text) = 3 Then 
      If (a < b And b < c) Then 
       awt1_lbl.Text = Val(0) 
       awt2_lbl.Text = a 
       awt3_lbl.Text = a + b 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (a < c And c < b) Then 
       awt1_lbl.Text = Val(0) 
       awt2_lbl.Text = a + b 
       awt3_lbl.Text = a 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (b < a And a < c) Then 
       awt1_lbl.Text = a 
       awt2_lbl.Text = Val(0) 
       awt3_lbl.Text = a + b 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (b < c And c < a) Then 
       awt1_lbl.Text = a + b 
       awt2_lbl.Text = Val(0) 
       awt3_lbl.Text = a 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (c < a And a < b) Then 
       awt1_lbl.Text = a 
       awt2_lbl.Text = a + b 
       awt3_lbl.Text = Val(0) 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (c < b And b < a) Then 
       awt1_lbl.Text = a + b 
       awt2_lbl.Text = a 
       awt3_lbl.Text = Val(0) 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      End If 

Answer 1

是的，有几件事情，你可以做：

• 的y计算是在任何情况下是相同的，所以您不必重复。
• 最后ElseIf永远是真实的，所以只需使用一个Else
• 使用Val(0)会造成大量的隐式转换的，它实际上将最终被CStr(Val(Cstr(0)))，所以只需使用"0"。

代码：

ElseIf Val(jobs_txt.Text) = 3 Then 
    If (a < b And b < c) Then 
    awt1_lbl.Text = "0" 
    awt2_lbl.Text = a 
    awt3_lbl.Text = a + b 
    ElseIf (a < c And c < b) Then 
    awt1_lbl.Text = "0" 
    awt2_lbl.Text = a + b 
    awt3_lbl.Text = a 
    ElseIf (b < a And a < c) Then 
    awt1_lbl.Text = a 
    awt2_lbl.Text = "0" 
    awt3_lbl.Text = a + b 
    ElseIf (b < c And c < a) Then 
    awt1_lbl.Text = a + b 
    awt2_lbl.Text = "0" 
    awt3_lbl.Text = a 
    ElseIf (c < a And a < b) Then 
    awt1_lbl.Text = a 
    awt2_lbl.Text = a + b 
    awt3_lbl.Text = "0" 
    Else 
    awt1_lbl.Text = a + b 
    awt2_lbl.Text = a 
    awt3_lbl.Text = "0" 
    End If 
    y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
    awt_ans.Text = y 

其实，如果值没有被转换为字符串，然后返回到数字，你可以简单地计算y这样的：

y = (a * 2 + b)/3 

Answer 2

首先，看起来你可以移动最后两行

y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
awt_ans.Text = y 

以外的if-then-else，因为他们在所有六种情况下做同样的事情。

接下来，因为它看起来像你的代码分配瓦尔（0）与最小的关键，a+b在中间值的项目，a到最大的一个，你可以把a，b和c在键阵列，awt1_lbl，awt2_lb，和awt3_lbl入值的阵列，并且对它们进行排序，例如：

Dim keys() As String = { a, b, c } 
Dim labels() As LabelType = { awt1_lbl, awt2_lb, awt3_lbl } // put real label type there 
Array.Sort(keys, labels) 
labels(0).Text = Val(0) 
labels(1).Text = a+b 
labels(2).Text = a 

Answer 3

除了其他的答案，这：

If (a < b And b < c) Then 

应该是一样的：

If (a < b < c) Then 

为您节省几个大字！

编辑：MetaKnight是对的，这是无效的语法。但编译器不抱怨，我不知道它做了什么。

Answer 4

你应该做一个类的话，那么它更易于阅读，再使用维护和扩展：

Dim awt = New AWT(a, b, c) 
awt1_lbl.Text = awt.GetAWT1().ToString 
awt2_lbl.Text = awt.GetAWT2().ToString 
awt3_lbl.Text = awt.GetAWT3().ToString 
awt_ans.Text = awt.GetY().ToString 

这里是一个可能的实现，我将它Option Strict，以便它可以很容易地被翻译到C＃并且也不太容易出错。

Public Class AWT 
    Public Property A As Int32 
    Public Property B As Int32 
    Public Property C As Int32 

    Public Sub New(a As Int32, b As Int32, c As Int32) 
     Me.A = a 
     Me.B = b 
     Me.C = c 
    End Sub 

    Public Function GetY() As Int32 
     Return GetAWT1() + GetAWT2() + GetAWT3() 
    End Function 

    Public Function GetAWT1() As Int32 
     If (A < B AndAlso B < C) OrElse (A < C AndAlso C < B) Then 
      Return 0 
     ElseIf (B < A AndAlso A < C) OrElse (C < A AndAlso A < B) Then 
      Return A 
     Else 
      Return A + B 
     End If 
    End Function 

    Public Function GetAWT2() As Int32 
     If (A < B AndAlso B < C) OrElse (C < B AndAlso B < A) Then 
      Return A 
     ElseIf (A < C AndAlso C < B) OrElse (C < A AndAlso A < B) Then 
      Return A + B 
     Else 
      Return 0 
     End If 
    End Function 

    Public Function GetAWT3() As Int32 
     If (A < B AndAlso B < C) OrElse (B < A AndAlso A < C) Then 
      Return A + B 
     ElseIf (A < C AndAlso C < B) OrElse (B < C AndAlso C < A) Then 
      Return A 
     Else 
      Return 0 
     End If 
    End Function 

End Class