我有一个通过RabbitMQ发送AMQP消息的应用程序。消息发送是通过http请求触发的。最近我注意到一些消息似乎正在迷失(如从未交付)。我还注意到服务器管理的频道列表正在稳步增加。我已经纠正的第一件事是在不再需要频道后关闭频道。不过,我仍然不确定我的代码的结构是否正确,以确保交付。以下两段代码;第一个是管理连接的单例的一部分(不会在每次调用时重新创建),第二个是发送代码。任何意见/指导将不胜感激。RabbitMQ的可靠消息传递
@Service
public class PersistentConnection {
private static Connection myConnection = null;
private Boolean blocked = false;
@Autowired ApplicationConfiguration applicationConfiguration;
@Autowired ConfigurationService configurationService;
@PostConstruct
private void init() {
}
@PreDestroy
private void destroy() {
try {
myConnection.close();
} catch (IOException e) {
e.printStackTrace();
}
}
public Connection getConnection() {
if (myConnection == null) {
start();
}
else if (!myConnection.isOpen()) {
log.warn("AMQP Connection closed. Attempting to start.");
start();
}
return myConnection;
}
private void start() {
log.debug("Building AMQP Connection");
ConnectionFactory factory = new ConnectionFactory();
String ipAddress = applicationConfiguration.getAMQPHost();
String password = applicationConfiguration.getAMQPUser();
String user = applicationConfiguration.getAMQPPassword();
String virtualHost = applicationConfiguration.getAMQPVirtualHost();
String port = applicationConfiguration.getAMQPPort();
try {
factory.setUsername(user);
factory.setPassword(password);
factory.setVirtualHost(virtualHost);
factory.setPort(Integer.parseInt(port));
factory.setHost(ipAddress);
myConnection = factory.newConnection();
}
catch (Exception e) {
e.printStackTrace();
}
myConnection.addBlockedListener(new BlockedListener() {
public void handleBlocked(String reason) throws IOException {
// Connection is now blocked
blocked = true;
}
public void handleUnblocked() throws IOException {
// Connection is now unblocked
blocked = false;
}
});
}
public Boolean isBlocked() {
return blocked;
}
}
/*
* Sends ADT message to AMQP server.
*/
private void send(String routingKey, String message) throws Exception {
String exchange = applicationConfiguration.getAMQPExchange();
String exchangeType = applicationConfiguration.getAMQPExchangeType();
Connection connection = myConnection.getConnection();
Channel channel = connection.createChannel();
channel.exchangeDeclare(exchange, exchangeType);
channel.basicPublish(exchange, routingKey, null, message.getBytes());
// Close the channel if it is no longer needed in this thread
channel.close();
}
getConnection()从更多线程中调用吗?如果是,代码不是线程安全的。 – Gabriele 2014-10-02 08:20:36
一个http请求最终会调用getConnection()调用。所以我想它可以。我想通过把它作为一个单例来解决这个问题。什么是改进代码的最佳方式? – skyman 2014-10-02 09:08:23