使用ADO.net中的事务SQL

Question

我是ADO的新手，所以我想问一下我是否正确使用事务。 下面的代码段

string SQL1 = "INSERT INTO tbl_cust(cust_id,cust_name) values ('000001','YoungMcD') "; 
string SQL2 = "UPDATE tbl_cust SET custname='OldMcDonald' WHERE cust_id='000001'"; 
string SQL3 = "SELECT * FROM tbl_supplier WHERE supplier_code ='000001'"; 

// write connstring 
string conn = System.Configuration.ConfigurationManager.ConnectionStrings["connstr"].ConnectionString; 
// end of connection string 

// setting connection 
SqlConnection db = new SqlConnection(conn); 
SqlTransaction transaction1; 

db.Open(); 
transaction1 = db.BeginTransaction(); 

try 
{ 
    // insert to table 
    SqlCommand Com1 = new SqlCommand(SQL1, db, transaction1); 
    Com1.ExecuteNonQuery(); 

    SqlCommand Com2 = new SqlCommand(SQL2, db, transaction1); 
    Com2.ExecuteNonQuery(); 

    SqlCommand Com3 = new SqlCommand(SQL3, db, transaction1); 
    Com3.ExecuteNonQuery(); 

    transaction1.Commit(); 

    db.Close(); 
} 
catch 
{ 
    transaction1.Rollback(); 
    db.Close(); 
    msg = "error"; 
    goto endret; 
} 

对于事务，我应该使用

SqlCommand Com1 = new SqlCommand(SQL1, db, transaction1); 

，而不是

SqlCommand Com1 = new SqlCommand(SQL1, db); 

因为我已经状态之前try{}声明

编辑开始交易：

我明白了，第一种语法是适用的，但是如何有效地使用ADO？我发现这种方式太简单了。

我发现自己继续这样做插入参数，例如：

string SQL1 = "INSERT INTO tbl_cust(cust_id,cust_name) values ('" + param1 +"','"+ param2 +"') "; 

Answer 1

您应该使用一个命令，也因此其妥善处置包装在使用块的连接。此外，您应该在通过执行SqlDataReader提交事务后从tbl_supplier读取。我假设你只是想知道事务提交后有多少行受到影响。

这是您的代码的简化版本。

var conn = System.Configuration.ConfigurationManager.ConnectionStrings["connstr"].ConnectionString; 
string SQL1 = "INSERT INTO tbl_cust(cust_id,cust_name) values ('000001','YoungMcD') "; 
string SQL2 = "UPDATE tbl_cust SET custname='OldMcDonald' WHERE cust_id='000001'"; 

using (SqlConnection connection = new SqlConnection(conn)) 
{ 
    connection.Open(); 
    SqlTransaction sqlTran = connection.BeginTransaction(); 
    SqlCommand command = connection.CreateCommand(); 
    command.Transaction = sqlTran; 

    try 
    { 
     command.CommandText = SQL1; 
     int rowsAffected = command.ExecuteNonQuery(); 
     command.CommandText = SQL2; 
     rowsAffected += command.ExecuteNonQuery(); 
     transaction.Commit(); 
    } 
    catch (Exception ex1) 
    { 
     // Attempt to roll back the transaction. 
     try 
     { 
      transaction.Rollback(); 
     } 
     catch (Exception ex2) 
     { 
      // This catch block will handle any errors that may have occurred 
      // on the server that would cause the rollback to fail, such as 
      // a closed connection. 
     } 
    } 
}