2015-10-13 49 views
6

我想使用下面的代码上传图像并更新数据库集合中图像的url。TypeError:任务不是异步js中的函数平行

Controller.prototype.handle = function (req, res, next) { 
    var id = req.params.id, 
     controller = req.params.controller, 
     optionalController; 

    optionalController = _.clone(controller); 

    // handle optional controller 
    if (controller === 'newboat') { 
    controller = 'boat'; 
    } else if (controller === 'newcrew') { 
    controller = 'crew'; 
    } 

    var files = req.files.files || {}, 
     monthYear = new Date(),   
     monthYear = [monthYear.getFullYear(), monthYear.getMonth()],  
     filename = files[0].originalFilename, 
     path = files[0].path, 
     extension = filename.match(EXPRESSION_EXTENSION)[1], 
     destFolder = [ROOT, monthYear[0], '/', monthYear[1] ].join(''), 
     destination = [ROOT, monthYear[0], '/', monthYear[1] ,'/', id, '.', extension ].join('');  

    // log info 
    //console.log(id, controller, filename, extension, destination, path); 

    var opts = JSON.stringify({id: id, photo: ['/uploads/',monthYear[0], '/', monthYear[1] ,'/', id, '.', extension ].join('') }); 

    async.series([ 
       uploadImage(path,destFolder,destination), 
       ProcessUpload(optionalController, opts, res) 
       ]); 
}; 

// write file 
var uploadImage = function(path,destFolder, destination) { 
    // The land of callbacks ------>>>>>> inception within inception 
    mkdirp(destFolder,777,function (err) {  
     fs.readFile(path, function (err, data) { 
      fs.writeFile(destination, data, function (err) { 
       if (err) { 
        console.log('image not uploaded..'); 
        return false; 
       }else { 
        return true; 
       } 
      }); 
     }); 
    }); 

}; 


var ProcessUpload = function(optionalController, opts, res) { 

    opts = JSON.parse(opts); 

    if (optionalController === 'boat') {  
    updateBoatDatabase(opts);  
    } 

}; 

/** 
* Update boat photo to database 
*/ 
var updateBoatDatabase = function (opts, callback) { 
    // save to database 
    return dbServices.dbBoat.updatePhoto(opts, callback); 
}; 

这里是被称为

/** 
    * Update image 
    */ 
    updatePhoto: function (opts, callback) { 
    var id = opts.id; 

    // find boat by id 
    this.modelClass.findById(id, function (err, model) { 
     if (err || !model) 
     return callback(err);  

     // set update value 
     model.photo = opts.photo; 

     // save 
     model.save(callback); 
    }); 
    }, 

我收到以下错误上传图像数据库服务,但图像被上传在服务器上,其网址更新数据库集合,以及。我假设它与我的回调有关,但我不确定我的错在哪里。任何提示如何调试这将不胜感激。

TypeError: task is not a function 
    at /home/work/bluewatertracks/node_modules/async/lib/async.js:689:13 
    at iterate (/home/work/bluewatertracks/node_modules/async/lib/async.js:265:13) 
    at async.forEachOfSeries.async.eachOfSeries (/home/work/bluewatertracks/node_modules/async/lib/async.js:284:9) 
    at _parallel (/home/work/bluewatertracks/node_modules/async/lib/async.js:688:9) 
    at Object.async.series (/home/work/bluewatertracks/node_modules/async/lib/async.js:710:9) 
    at Controller.handle (/home/work/bluewatertracks/server/routers/photoUploader.js:56:9) 
    at Layer.handle [as handle_request] (/home/work/bluewatertracks/node_modules/express/lib/router/layer.js:82:5) 
    at next (/home/work/bluewatertracks/node_modules/express/lib/router/route.js:110:13) 
    at Form.<anonymous> (/home/work/bluewatertracks/node_modules/connect-multiparty/index.js:101:9) 
    at emitNone (events.js:72:20) 
    at Form.emit (events.js:166:7) 
    at maybeClose (/home/work/bluewatertracks/node_modules/connect-multiparty/node_modules/multiparty/index.js:557:10) 
    at endFlush (/home/work/bluewatertracks/node_modules/connect-multiparty/node_modules/multiparty/index.js:552:3) 
    at WriteStream.<anonymous> (/home/work/bluewatertracks/node_modules/connect-multiparty/node_modules/multiparty/index.js:617:5) 
    at emitNone (events.js:72:20) 
    at WriteStream.emit (events.js:166:7) 

回答

1

你也可以简化这个有点通过传递一个空对象bind()

async.series([ 
    uploadImage.bind(null, path, destFolder, destination), 
    ProcessUpload.bind(null, optionalController, opts, res) 
]); 
10

async.series和大部分async控制流的功能预期要返回功能或功能的阵列,例如

async.series([ 
    function() {}, 
    function() {} 
]) 

你的两个函数调用uploadImageProcessUpload的返回值是功能。 async出错。

相反,你会写这样的东西,如:

async.series([ 
    function (callback) { 
     // callback has to be called by `uploadImage` when it's done 
     uploadImage(path,destFolder,destination, callback); 
    }, 
]);