崩溃与shared_ptr

Question

有人可以向我解释为什么在这里崩溃？

#include <memory> 
#include <functional> 

struct Teacher : std::enable_shared_from_this<Teacher> { 
    struct Timetable; 
    std::shared_ptr<Timetable> timetable; 
    Teacher (int n) : timetable(std::make_shared<Timetable>(*this, n)) {} 
}; 

struct Period { 
    std::shared_ptr<Teacher> teacher; 
    Period (const std::shared_ptr<Teacher>& t) : teacher(t) {} 
}; 

struct Teacher::Timetable { 
    Teacher& teacher; 
    std::shared_ptr<Period> homeForm; 
    Timetable (Teacher& t, int n) : teacher(t), // Assume something is done with n. 
     homeForm(std::make_shared<Period>(teacher.shared_from_this())) {} // Crashes. 
//  homeForm(std::make_shared<Period>(std::shared_ptr<Teacher>(&teacher))) {} // Also crashes. 
}; 

int main() { 
    std::shared_ptr<Teacher> teacher = std::make_shared<Teacher>(3); 
} 

是不是teacher.shared_from_this()这里不允许因为std::shared_ptr<Teacher> teacher是一个shared_ptr了吗？如果不是，我该如何正确初始化homeForm？

Answer 1

问题是您的代码在std::shared_ptr<Teacher>完全构建之前调用shared_from_this。不知何故，在智能指针完全构建之前，必须构造Teacher子对象。

如果改变这样的代码，

struct Teacher : std::enable_shared_from_this<Teacher> { 
    struct Timetable; 
    std::shared_ptr<Timetable> timetable; 
    Teacher() {} 
    void init(int n) { this->timetable = std::make_shared<Timetable>(*this, n); } 
}; 

// Everything else unchanged 

int main() { 
    std::shared_ptr<Teacher> teacher = std::make_shared<Teacher>(); 
    teacher->init(3); 
} 

它将会运行得很好。

请注意，我不建议将此作为重构。只要有可能，构造函数应该完全初始化对象。看看你的代码，在我看来，你可能想考虑重新构造它更激进。你真的需要所有这些交叉引用共享指针吗？