内存泄漏类

Question

我有内存泄漏问题。在名为“Deleaker”的程序中进行测试。 如果我注释掉析构函数的内容，它正确地处理这些内存泄漏。 谢谢你的帮助。

Inventory.h

#ifndef INVENTORY_H 
#define INVENTORY_H 

#include "Item.h" 

class InventoryOfItems { 
public: 
    InventoryOfItems(int c = 10); 
    ~InventoryOfItems(); 

    bool Add(Item* newItem); 
    Item* Remove(int itemIndex); 
    int Size() const; 
    int Items() const; 
    int Weapons() const; 
    int Potions() const; 
    Item::item_t GetItemType(int invIndex) const; 

    void DisplayWeapons(); 
    void DisplayPotions(); 
    void DisplayInfo(); 
private: 
    Item** items; 
    int itemCount; 
    int capacity; 
}; 

#endif /* INVENTORY_H */ 

Inventory.cpp

#include "Inventory.h" 
#include "Weapon.h" 
#include "Potion.h" 

#include <iostream> 
using std::cout; 
using std::endl; 

#include <iomanip> 
using std::setw; 
using std::setiosflags; 
using std::ios; 

#include <string> 

InventoryOfItems::InventoryOfItems(int cap) { 
    itemCount = 0; 
    capacity = cap; 
    items = new Item*[capacity]; 

    for (int i = 0; i < capacity; i++) { 
     items[i] = 0; 
    } 
} 

InventoryOfItems::~InventoryOfItems() { 

    for (int i = 0; i < itemCount; i++) { 
     delete items[i]; 
    } 

    delete [] items; 
} 

bool InventoryOfItems::Add(Item* newItem) { 
    if (newItem == 0) 
     return false; 

    for (int i = 0; i < capacity; i++) 
     if (items[i] == 0) { // empty 
      switch (newItem->GetType()) { 

       case Item::Weapon: 
       { 

        Weapon* originalWeapon = (Weapon*) newItem; 
        Weapon* newWeapon = new Weapon(originalWeapon); 

        items[i] = newWeapon; 
        itemCount++; 
        break; 
       } 
       case Item::Potion: 
       { 
        Potion* originalPotion = (Potion*) newItem; 
        Potion* newPotion = new Potion(originalPotion); 
        items[i] = newPotion; 
        itemCount++; 
        break; 
       } 
      } 
      return true; 
     } 

    return false; 
} 

Item* InventoryOfItems::Remove(int itemIndex) { 
    if (items[itemIndex - 1] == 0) 
     return 0; 
    else { 
     Item* itemToReturn; 
     itemToReturn = items[itemIndex - 1]; 
     items[itemIndex - 1] = 0; 
     itemCount--; 
     return itemToReturn; 
    } 
} 

int InventoryOfItems::Size() const { 
    return capacity; 
} 

int InventoryOfItems::Items() const { 
    return itemCount; 
} 

int InventoryOfItems::Weapons() const { 
    int count = 0; 
    for (int i = 0; i < capacity; i++) 
     if (items[i] != 0) 
      if (items[i]->GetType() == Item::Weapon) 
       count++; 

    return count; 
} 

int InventoryOfItems::Potions() const { 
    int count = 0; 
    for (int i = 0; i < capacity; i++) 
     if (items[i] != 0) 
      if (items[i]->GetType() == Item::Potion) 
       count++; 

    return count; 
} 

Item::item_t InventoryOfItems::GetItemType(int invIndex) const { 
    if (items[invIndex - 1] == 0) 
     return Item::Undefined; 
    else 
     return items[invIndex - 1]->GetType(); 
} 

void InventoryOfItems::DisplayWeapons() { 
    cout << " WEAPONS" << endl; 
    for (int i = 0; i < capacity; i++) 
     if (items[i] != NULL) 
      if (items[i]->GetType() == Item::Weapon) { 
       cout << " " << setiosflags(ios::right) << setw(2) << i + 1 << ": "; 
       items[i]->DisplayInfo(); 
       cout << endl; 
      } 
} 

void InventoryOfItems::DisplayPotions() { 
    cout << " POTIONS" << endl; 
    for (int i = 0; i < capacity; i++) 
     if (items[i] != NULL) 
      if (items[i]->GetType() == Item::Potion) { 
       cout << " " << setiosflags(ios::right) << setw(2) << i + 1 << ": "; 
       items[i]->DisplayInfo(); 
       cout << endl; 
      } 
} 

void InventoryOfItems::DisplayInfo() { 
    cout << endl; 
    cout << " ----------------------------------" << endl; 
    cout << " Inventory (carrying " << itemCount << " of " << capacity << " items)" << endl; 
    cout << " ----------------------------------" << endl; 

    DisplayWeapons(); 
    DisplayPotions(); 
} 

调用remove：

void Hero::equip() 
{ 
    int item = 0; 

    if(inv.Items() == 0) 
    { 
     cout << "Your inventory is empty!" << endl; 
    } 
    else 
    { 
     inv.DisplayWeapons(); 
     cout << "Choose a weapon: " << endl; 
     cin >> item; 

     if(weapon != NULL) 
     { 
      inv.Add(weapon); 
     } 

     Weapon *selected = (Weapon*) inv.Remove(item); 
     weapon = new Weapon(selected); 
     delete selected; 
    } 
} 

武器是指向武器（英雄的手）

Answer 1

你”不是在覆盖它之前，先写入-ing weapon。请注意添加一行：

inv.DisplayWeapons(); 
    cout << "Choose a weapon: " << endl; 
    cin >> item; 

    if(weapon != NULL) 
    { 
     inv.Add(weapon); 
     delete weapon; // Added 
    } 

    Weapon *selected = (Weapon*) inv.Remove(item); 
    weapon = new Weapon(selected); // `weapon` would be overwritten here 
    delete selected; 

话虽如此，我还建议使用std::vector代替所有这些指针，因为我们在这个问题评论说，因为搞乱了内存管理是很容易。