2011-12-31 97 views
0

我试图验证我的用户服务器端与PHP和它说我得到一个致命错误:调用未定义的函数reGenPassHash()在/ home/xtremer/public_html/kowmanager/application/models /第13行的loggedin.php现在我有包含reGenPassHash函数自动加载的模型,所以我认为它可以使用,但由于某种原因它不是因为这个消息。有人解释为什么?验证与php

型号:

public function check_login($username, $password) 
{ 
    $generated_password = reGenPassHash($password); 
    $query = "SELECT user_id WHERE username = ? AND password = ?"; 
    $result = $this->db->query($query, array($username, $generated_password)); 

    if ($result->num_rows == 1) 
    { 
     return $result->row(0)->user_id; 

    } 
    else 
    { 
     return false; 
    } 

} 

控制器:

<?php if (! defined('BASEPATH')) exit('No direct script access allowed'); 

class Usermanagement extends CI_Controller { 

public function __construct() 
{ 
    parent::__construct(); 
} 

public function index() 
{ 
    //Config Defaults Start 
    $msgBoxMsgs = array();//msgType = dl, info, warn, note, msg 
    $cssPageAddons = '';//If you have extra CSS for this view append it here 
    $jsPageAddons = '';//If you have extra JS for this view append it here 
    $metaAddons = '';//Sometimes there is a need for additional Meta Data such in the case of Facebook addon's 
    $siteTitle = '';//alter only if you need something other than the default for this view. 
    //Config Defaults Start 


    //examples of how to use the message box system (css not included). 
    //$msgBoxMsgs[] = array('msgType' => 'dl', 'theMsg' => 'This is a Blank Message Box...'); 

    /**********************************************************Your Coding Logic Here, Start*/ 

    if(!$this->session->userdata('logged_in')) 
    { 
     $bodyContent = "login";//which view file 
    } 
    else 
    { 
     $bodyContent = "cpanel/index";//which view file 
    } 

    $bodyType = "full";//type of template 

    /***********************************************************Your Coding Logic Here, End*/ 

    //Double checks if any default variables have been changed, Start. 
    //If msgBoxMsgs array has anything in it, if so displays it in view, else does nothing.  
    if(count($msgBoxMsgs) !== 0) 
    { 
     $msgBoxes = $this->msgboxes->buildMsgBoxesOutput(array('display' => 'show', 'msgs' =>$msgBoxMsgs)); 
    } 
    else 
    { 
     $msgBoxes = array('display' => 'none'); 
    } 

    if($siteTitle == '') 
    { 
     $siteTitle = $this->metatags->SiteTitle(); //reads 
    } 

    //Double checks if any default variables have been changed, End. 

    $this->data['msgBoxes'] = $msgBoxes; 
    $this->data['cssPageAddons'] = $cssPageAddons;//if there is any additional CSS to add from above Variable this will send it to the view. 
    $this->data['jsPageAddons'] = $jsPageAddons;//if there is any addictional JS to add from the above variable this will send it to the view. 
    $this->data['metaAddons'] = $metaAddons;//if there is any addictional meta data to add from the above variable this will send it to the view. 
    $this->data['pageMetaTags'] = $this->metatags->MetaTags();//defaults can be changed via models/metatags.php 
    $this->data['siteTitle'] = $siteTitle;//defaults can be changed via models/metatags.php 
    $this->data['bodyType'] = $bodyType; 
    $this->data['bodyContent'] = $bodyContent; 
    $this->load->view('usermanagement/index', $this->data); 
} 

function login() 
{ 
    $this->form_validation->set_rules('username', 'Username', 'trim|required|max_length[50]|xss_clean'); 
    $this->form_validation->set_rules('password', 'Password', 'trim|required|max_length[12]|xss_clean'); 

    if ($this->form_validation->run() == FALSE) 
    { 
     $this->index(); 
    } 
    else 
    { 
     $username = $this->input->post('username'); 
     $password = $this->input->post('password'); 

     $user_id = $this->loggedin->check_login($username, $password); 

     if(! $user_id) 
     { 
      redirect('/'); 
     } 
     else 
     { 
      $this->session->set_userdata(array(
       'logged_in' => TRUE, 
       'user_id' => $user_id 
      )); 
      redirect('cpanel/index'); 
     } 
    } 
} 

function logout() 
{ 
    $this->session->sess_destroy(); 
    $this->index(); 
}  

} 

/* End of file usermanagement.php */ 
/* Location: ./application/controllers/usermanagement.php */ 

编辑:

我想确保我的逻辑是正确的。我应该在我的控制器中使用regenPassHash函数调用吗?

编辑2:

这是我的密码功能如何看待(getfunc模型)的例子:

<?php 
function GenPassHash($logPass) 
{ 
    $usersalt = substr(md5(uniqid(rand(), true)), 0, 11); 
    $encPass = sha1($logPass); 
    $sltPass = $encPass . $usersalt;$encSPass = sha1($sltPass); 
    $passArray = array($encSPass,$usersalt); 
    return $passArray; 
} 
function reGenPassHash($postDpass, $storeSalt) 
{ 
    $logPass = $postDpass; 
    $encPass = sha1($logPass); 
    $sltPass = $encPass . $storeSalt; 
    $encSPass = sha1($sltPass); 
    return $encSPass; 
} 

//useage 
$logPass = "catcher05";//this could be your posted variable from registration 

$passforDB = GenPassHash($logPass); 
echo "<pre>"; 
print_r($passforDB); 
echo "</pre>"; 
echo "Encrypted Password: " . $passforDB[0] . "<br />"; 
echo "Salted Value: " . $passforDB[1] . "<br />"; 

echo "----------------------------------<br />"; 
//in this example I post $passforDB[1] with the below function to stimulate having pulled it from a DB 
echo reGenPassHash($logPass, $passforDB[1]); //you would query based on your username being posted and only pull the salt and encrypted pass you would use the salt in this function 

?> 

控制器:

function login() 
{ 
    $this->form_validation->set_rules('username', 'Username', 'trim|required|max_length[50]|xss_clean'); 
    $this->form_validation->set_rules('password', 'Password', 'trim|required|max_length[12]|xss_clean'); 

    if ($this->form_validation->run() == FALSE) 
    { 
     $this->index(); 
    } 
    else 
    { 
     $username = $this->input->post('username'); 
     $password = $this->input->post('password'); 
     $generated_password = $this->getfunc->reGenPassHash($password); 

     $user_id = $this->loggedin->check_login($username, $password); 

     if(! $user_id) 
     { 
      redirect('/'); 
     } 
     else 
     { 
      $this->session->set_userdata(array(
       'logged_in' => TRUE, 
       'user_id' => $user_id 
      )); 
      redirect('cpanel/index'); 
     } 
    } 
} 

型号:

public function check_login($username, $password) 
{ 
$query = "SELECT * WHERE username = ".$username.""; 
$result = $this->db->query($query); 

if ($result->num_rows == 1) 
{ 
    $passwordDB = $result->row(0)->password; 
    $passwordDB2 = $result->row(0)->password2; 


    return $result->row(0)->user_id; 

} 
else 
{ 
    return false; 
} 

} 
+0

你能告诉我们reGenPassHash()函数的模型代码吗?你确定在check_login函数中包含该文件吗? – 2011-12-31 18:02:52

+0

如果它的自动加载不意味着它包含在这个模型之上。 – 2011-12-31 18:04:05

回答

1

自动加载只能用于对象方法。您在调用regen函数时没有使用对象表示法,因此它被当作常规函数调用来处理 - 并且此函数未定义。

+0

我可以从这个模型中的另一个模型调用一个函数吗? – 2011-12-31 18:05:15

+0

所以你说它应该是$ generated_pa​​ssword = $ this-> model-> getfunc-> reGenPassHash($ password);而不是$ generated_pa​​ssword = reGenPassHash($ password); – 2011-12-31 18:06:47

+0

请查看我的帖子编辑。 – 2011-12-31 18:13:19

1

你需要通过你的模型对象调用你的reGenPassHash功能,如:

$this->your_model_with_pass_function->reGenPassHash() 
+0

请查看我的帖子编辑。 – 2011-12-31 18:14:02

+0

您的代码应该像您现在编辑它一样工作,但正如其他帖子所说,如果您需要多个控制器才能访问这些功能,则应将密码功能移动到您的模型或其他库中。真的,你的模型是一个图书馆。只要将它移动到库中,并将其自动加载为库,并且将按照新代码显示的方式调用它。它还没有工作吗? – davidethell 2012-01-01 03:13:45

1

我与您的代码看到的唯一错误,是你在呼唤你的方法错误的方式。对于任何类方法,您需要一个对象来访问这些方法。

这可能是$ this。在你的情况下或其他情况下的其他情况。

尝试使用$this -> reGenPassHash()只有在模型中使用方法或者您需要各自的对象修饰符。

UPDATE:

  1. 包括您的控制器上GenPassHash()& reGenPassHash()。
  2. 代替$this->getfunc->reGenPassHash()使用$this->reGenPassHash()
+0

请查看我的帖子编辑。 – 2011-12-31 18:13:42

+1

是的,逻辑上,您的模型只应包含与数据库相关的逻辑。 ....函数reGenPassHash()仅与开发散列代码有关,与数据库无关...所以代码应该放置在控制器中:) – Starx 2011-12-31 18:17:49

+0

谢谢您的澄清。 – 2011-12-31 18:28:54

3

reGenPassHash()函数是不将check_login()方法可见。用对象调用reGenPassHas。

ex:$object->reGenPassHas()

这是一个范围问题

+0

请检查我的文章编辑。 – 2011-12-31 18:14:20

+1

是的,最好的做法是在控制器中使用'reGenPassHas()',因为它没有与数据库一起玩。如果你的方法与数据库一起工作,最好的做法是将它们移动到模型中。 [Model-view-controller](http://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93controller) – 2011-12-31 18:39:31

+0

再次更新我的文章。 – 2011-12-31 18:47:07