如何清理我的if/else LINQ代码

Question

我有这样的事情：

 if (sort == "Customer") 
     { 
      if (sortDirection == SortDirection.Descending) 
       myList = myList.OrderByDescending(e => e.SiteOrganization.Organization.Name).ToList(); 
      else 
       myList = myList.OrderBy(e => e.SiteOrganization.Organization.Name).ToList(); 
     } 
     if (sort == "RequestType") 
     { 
      if (sortDirection == SortDirection.Descending) 
       myList = myList.OrderByDescending(e => e.TypeId).ToList(); 
      else 
       myList = myList.OrderBy(e => e.TypeId).ToList(); 
     } 
     if (sort == "RequestedByShort") 
     { 
      if (sortDirection == SortDirection.Descending) 
       myList = myList.OrderByDescending(e => e.RequestedByUser.ShortName).ToList(); 
      else 
       myList = myList.OrderBy(e => e.RequestedByUser.ShortName).ToList(); 
     } 

我想打扫一下有类似

if (sortDirection == SortDirection.Descending) 
       myList = myList.OrderByDescending(e => e.RequestedByUser.ShortName).ToList(); 
      else 
       myList = myList.OrderBy(e => e.RequestedByUser.ShortName).ToList(); 

所以，我只有一个LINQ查询不管它是什么“排序”。有什么建议么？

Answer 1

如果将排序逻辑移动到方法中，可以直接将谓词传递给

public IList<TSource> SortBy<TSource, TMember>(IEnumerable<TSource> list, Func<TSource, TMember> selector, SortDirection direction) 
{ 
    if (direction == SortDirection.Descending) 
     return list.OrderByDescending(selector).ToList(); 
    else 
     return list.OrderBy(selector).ToList(); 
} 
... 
if (sort == "Customer") { 
    list = SortBy(list, x => x.SiteOrganization.Organization.Name, SortDirection.Descending); 
} else if (sort == "RequestType") { 
    list = SortBy(list, x => x.TypeId, SortDirection.Ascending); 
} else if (sort == "RequestedByShort") { 
    list = SortBy(list, x => x.RequestedByUser.ShortName, SortDirection.Descending); 
} 

Live demo

---

如果你想使用它作为一个通用的解决方案的所有列表，您可以创建它作为一个扩展方法

public static class ListExt 
{ 
    public static IList<TSource> SortBy<TSource, TMember>(this IEnumerable<TSource> list, Func<TSource, TMember> selector, SortDirection direction) 
    { 
     if (direction == SortDirection.Descending) { 
      return list.OrderByDescending(selector).ToList(); 
     } else { 
      return list.OrderBy(selector).ToList(); 
     } 
    } 
} 
... 
list = list.SortBy(x => x.TypeId, SortDirection.Ascending);