如何让RadioButton播放音乐

Question

所以我有一个班会通过MediaPlayer播放一些歌曲。我有下面的代码，当选择一个Radiobutton应播放一首歌曲，但这不起作用，有谁能告诉我为什么？

我没有得到任何错误，音乐只是不玩。从OnCheckedChange方法

代码：

 break;   
    case R.id.rFolk1: //setting up sub radiogroup buttons 
     if(fsong1.isPlaying() == false) 
      fsong1.start(); 
     break; 
    case R.id.rFolk2: //setting up sub radiogroup buttons 
     if(fsong2.isPlaying() == false) 
      fsong2.start(); 
     break; 

的歌曲其他代码：

fsong1 = MediaPlayer.create(this, R.raw.folk1); 
    fsong2 = MediaPlayer.create(this, R.raw.folk2); 

Fullcode：

public class Music extends Activity implements OnCheckedChangeListener, OnClickListener{ 

Button playpause; 
RadioGroup selectionList, Folk, Rock, Pop, NewWave, Pipe;//define the radiogroup 
RadioButton folk1, folk2, rock1, rock2, pop1, pop2, newwave1, newwave2, pipe1, pipe2; //define radiobuttons 
MediaPlayer fsong1, fsong2, rsong1, rsong2, psong1, psong2, nwsong1, nwsong2, pisong1, pisong2; 

@Override 
protected void onCreate(Bundle savedInstanceState) { 
    super.onCreate(savedInstanceState); 
    //set fullscreen 
    requestWindowFeature(Window.FEATURE_NO_TITLE); 
    getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,WindowManager.LayoutParams.FLAG_FULLSCREEN); 

    setContentView(R.layout.music); //set layout 

    initialize(); //call this method 
} 

public void initialize(){ 
    // set up the radiogroups 
    selectionList = (RadioGroup) findViewById(R.id.rgMusic); 
    Folk = (RadioGroup) findViewById(R.id.rgFolk); 
    Rock = (RadioGroup) findViewById(R.id.rgRock); 
    Pop = (RadioGroup) findViewById(R.id.rgPop); 
    Pipe = (RadioGroup) findViewById(R.id.rgPipe); 

    folk1 = (RadioButton) findViewById(R.id.rFolk1); 
    folk2 = (RadioButton) findViewById(R.id.rFolk2); 
    rock1 = (RadioButton) findViewById(R.id.rRock1); 
    rock2 = (RadioButton) findViewById(R.id.rRock2); 
    pipe1 = (RadioButton) findViewById(R.id.rPipe1); 
    pipe2 = (RadioButton) findViewById(R.id.rPipe2); 
    pop1 = (RadioButton) findViewById(R.id.rPop1); 
    pop2 = (RadioButton) findViewById(R.id.rPop2); 
    newwave1 = (RadioButton) findViewById(R.id.rNewWave1); 
    newwave2 = (RadioButton) findViewById(R.id.rNewWave2); 

    NewWave = (RadioGroup) findViewById(R.id.rgNewWave); 

    //settting up on check changed 
    selectionList.setOnCheckedChangeListener(this); 

    playpause = (Button) findViewById(R.id.bPlayPause); 
    playpause.setOnClickListener(this); 

    fsong1 = MediaPlayer.create(this, R.raw.folk1); 
    fsong2 = MediaPlayer.create(this, R.raw.folk2); 


} 

@Override 
public void onCheckedChanged(RadioGroup arg0, int arg1) { 
    //case statement for onCheckChange to open a new class/layout 
    // 
    //This also hides radiogroups and shows others 
    switch(arg1){ 
    case R.id.rFolk: 
     Folk.setVisibility(View.VISIBLE); //shows rg for folk 
     //hides all the rest of the radiogroups if visible 
      if(Pipe.getVisibility() == View.VISIBLE){ 
       Pipe.setVisibility(View.GONE); 
       } 
      if(Rock.getVisibility() == View.VISIBLE){ 
      Rock.setVisibility(View.GONE); 
       } 
      if(Pop.getVisibility() == View.VISIBLE){ 
      Pop.setVisibility(View.GONE); 
       } 
      if(NewWave.getVisibility() == View.VISIBLE){ 
      NewWave.setVisibility(View.GONE); 
       } 

     break; 
    case R.id.rPipe: 
     Pipe.setVisibility(View.VISIBLE);//shows rg for pipe 
     //hides all the rest of the radiogroups if visible 
     if(Folk.getVisibility() == View.VISIBLE){ 
      Folk.setVisibility(View.GONE); 
      } 
     if(Rock.getVisibility() == View.VISIBLE){ 
     Rock.setVisibility(View.GONE); 
      } 
     if(Pop.getVisibility() == View.VISIBLE){ 
     Pop.setVisibility(View.GONE); 
      } 
     if(NewWave.getVisibility() == View.VISIBLE){ 
     NewWave.setVisibility(View.GONE); 
      } 

     break; 
    case R.id.rRock: 
     Rock.setVisibility(View.VISIBLE);//shows rg for rock 
     //hides all the rest of the radiogroups if visible 
     if(Folk.getVisibility() == View.VISIBLE){ 
      Folk.setVisibility(View.GONE); 
      } 
     if(Pipe.getVisibility() == View.VISIBLE){ 
     Pipe.setVisibility(View.GONE); 
      } 
     if(Pop.getVisibility() == View.VISIBLE){ 
     Pop.setVisibility(View.GONE); 
      } 
     if(NewWave.getVisibility() == View.VISIBLE){ 
     NewWave.setVisibility(View.GONE); 
      } 

     break; 
    case R.id.rPop: 
     Pop.setVisibility(View.VISIBLE);//shows rg for pop 
     //hides all the rest of the radiogroups if visible 
     if(Folk.getVisibility() == View.VISIBLE){ 
      Folk.setVisibility(View.GONE); 
      } 
     if(Pipe.getVisibility() == View.VISIBLE){ 
     Pipe.setVisibility(View.GONE); 
      } 
     if(Rock.getVisibility() == View.VISIBLE){ 
     Rock.setVisibility(View.GONE); 
      } 
     if(NewWave.getVisibility() == View.VISIBLE){ 
     NewWave.setVisibility(View.GONE); 
      } 

     break; 
    case R.id.rNewWave: 
     NewWave.setVisibility(View.VISIBLE);//shows rg for newwave 
     //hides all the rest of the radiogroups if visible 
     if(Folk.getVisibility() == View.VISIBLE){ 
      Folk.setVisibility(View.GONE); 
      } 
     if(Pipe.getVisibility() == View.VISIBLE){ 
     Pipe.setVisibility(View.GONE); 
      } 
     if(Rock.getVisibility() == View.VISIBLE){ 
     Rock.setVisibility(View.GONE); 
      } 
     if(Pop.getVisibility() == View.VISIBLE){ 
     Pop.setVisibility(View.GONE); 
      } 

     break;   
    case R.id.rFolk1: //setting up sub radiogroup buttons 
     if(fsong1.isPlaying() == false){ 
      fsong1.start(); 
     } 
     break; 
    case R.id.rFolk2: //setting up sub radiogroup buttons 
     if(fsong2.isPlaying() == false){ 
      fsong2.start(); 
     } 
    } 
} 

@Override 
public void onClick(View view) { 
    // setting the onclick listener for the buttons for play/pause stop 

    // check for already playing 
    if(fsong1.isPlaying()){ 

      fsong1.pause(); 
      // Changing button image to play button 
      playpause.setBackgroundResource(R.drawable.play_button); 

    }else{ 
     // Resume song 
      fsong1.start(); 
      // Changing button image to pause button 
      playpause.setBackgroundResource(R.drawable.pause_button); 
    } 

} 

}

Answer 1

I'd advise against creating so many MediaPlayers。他们很可能是你的麻烦的原因：当你实例太多时，他们不能很好地工作。

你也应该看看lifecycle of MediaPlayer。

其中您可以找到一种方法来移除MediaPlayers的多个实例。你可以，比如改变你玩到：

Boolean fsong1, fsong2, rsong1, rsong2, psong1, psong2, nwsong1, nwsong2, pisong1, pisong2; 
    Boolean isPlaying=false; 

//很多更多的代码

case R.id.rFolk1: //setting up sub radiogroup buttons 
    if ((isPlaying) && !fsong1){ 
     mediaPlayer.stop(); 
     mediaPlayer.release(); 
     mediaPlayer = null; 
    } 
    if (!fsong1){ 
     //reset all other types of songs! 
     fsong1=true; 
     isPlaying = true;   
     mediaPlayer=MediaPlayer.create(this, R.raw.folk1); 
     mediaPlayer.start(); 
    } 

    break; 

警告：我不会给你你就必须申请全部改变！