乌龟和野兔模拟终止问题

Question

#include<iostream> 
#include<cstdlib> 
#include<time.h> 
#include<ctime> 
#include<iomanip> 
using namespace std; 

const int End=70; //constant fixed integer for the entire game. 

void MoveTurtoise (int *); 
void MoveHare (int *); 
void PrintPosition (int *, int*); 



int main() 
{ 
int Tortoise = 1; 
int Hare = 1; 
int Time = 0; 

srand(time(0)); 

cout<<"BANG!!!!!\n" 
    <<"AND THEY'RE OFF !!!!!\n"; 

while(Tortoise != End && Hare != End) 
{ 
    srand(time(0)); 
    MoveTurtoise (&Tortoise); 
    MoveHare (&Hare); 
    PrintPosition (&Tortoise,&Hare); 
    Time++; 

} 

if (Tortoise==Hare) 
     cout<<"It's a tie."<<endl; 
    else if (Tortoise>Hare) 
     cout<<"Tortoise wins."<<endl; 
    else if (Hare>Tortoise) 
     cout<<"Hare wins."<<endl; 

system("PAUSE"); 
return 0; 
} 

void MoveTurtoise (int *Tortoise) 
{ 
srand(time(0)); 
int p = 1+ rand()%10; // 1 <= i <= 10 

if (1<=p && p<=5) //Fast plod 
    Tortoise+=3; //3 squares right 
else if (p>=6 && p<=7) //Slip 
    Tortoise-=6;//6 squares left 
else //Slow plod 
    ++Tortoise; //1 square right 

if (*Tortoise<1) 
    *Tortoise=1; 



} 

void MoveHare (int *Hare) 
{ 
srand(time(0)); 
int p = 1+ rand()%10; // 1 <= p <= 10 

if (1<= p && p<=2); //Sleep 
        //No move 
else if (p>=3 && p<=4) //Big hop 
    Hare+=9;//9 squares right 
else if (p==5) //Big Slip 
    Hare-=12;// 12 squares left 
else if (p>=6 && p<=8) // Small hop 
    ++Hare;// 1 square right 
else if (p>=9 && p<=10)// Small Slip 
    Hare-=2; // 2 squares left 

if (*Hare<1) 
    *Hare=1; 


} 

void PrintPosition (int *Tortoise, int *Hare) 
{ 
if (Tortoise==Hare) 
    cout<<"OUCH!!!"<<endl; 
else if (Tortoise<Hare) 
    { 
    cout<<setw(*Tortoise)<<"T"<<endl; 
    cout<<setw(Hare-Tortoise)<<"H"<<endl; 
    } 
else if (Hare<Tortoise) 
{ 
    cout<<setw(Tortoise-Hare)<<"T"<<endl; 
    cout<<setw(*Hare)<<"H"<<endl; 

} 




} 

大家好。我只是用C++编写了一个用于Tortoise和Hare模拟游戏的代码。我有一个问题发现是什么导致我的程序“不”终止。它一直在继续，并取得了相同的结果。我假设有一个循环错误和错误的使用srand（）..但我仍然没有线索...

Answer 1

在函数MoveTurtoise和MoveHare，您正在增加指针而不是它们的值。

void MoveTurtoise (int *Tortoise) 
{ 
    srand(time(0)); 
    int p = 1+ rand()%10; // 1 <= i <= 10 

    if (1<=p && p<=5) //Fast plod 
     Tortoise+=3; //3 squares right 
     // This makes Tortoise point to a different location. 
     // It does not change the value of what Tortoise points to. 
     // Similarly for the next two clauses. 

    else if (p>=6 && p<=7) //Slip 
     Tortoise-=6;//6 squares left 
    else //Slow plod 
     ++Tortoise; //1 square right 

    if (*Tortoise<1) 
     *Tortoise=1; 
} 

你需要什么：

void MoveTurtoise (int *Tortoise) 
{ 
    srand(time(0)); 
    int p = 1+ rand()%10; // 1 <= i <= 10 

    if (1<=p && p<=5) //Fast plod 
     (*Tortoise) += 3; //3 squares right 
    else if (p>=6 && p<=7) //Slip 
     (*Tortoise) -= 6;//6 squares left 
    else //Slow plod 
     ++(*Tortoise); //1 square right 

    if (*Tortoise<1) 
     *Tortoise=1; 
} 

MoveHare需要被固定在一个类似的方式。

这是更好的解决方案。更改更改参数类型为int&，然后代码将更喜欢你所拥有的。

​​3210

而且，你的PrintPosition实现是，如果参数为：

void PrintPosition (int Tortoise, int Hare); 

这是一个比你有什么更好的。更改

void PrintPosition (int *Tortoise, int *Hare); 

到

void PrintPosition (int Tortoise, int Hare); 

Answer 2

是，user3543568198 你忘了使用std ::运输及工务局局长添加页眉库;并且您在打印语句中添加了一个else if（Hare < = Tortoise），因为如果... else执行相同的操作，但您的代码通过引用传递，除了您的Tortoise函数缺少raceEnd =外，其他所有代码都很好。 ..在头发和乌龟功能....只是通过用下面的功能替换你的程序功能，它实际上会移动屏幕上的单位......哦一定要添加 const int RACE_END = 70; in header

void MoveTurtoise (int *Tortoise) 
{ 
int x = 1 + rand() % 10; 
// determine which move to make 
if (x >= 1 && x <= 5)  // fast plod 
    *Tortoise += 5; 

else if (x == 9) // slip 
    *Tortoise -= 12; 

else       // slow plod 
    ++(*Tortoise); 
if (*Tortoise < 1) 
    *Tortoise = 1; 

else if (*Tortoise > RACE_END) 
    *Tortoise = RACE_END; 

} 



void MoveHare(int *Hare) 
{ 
int y = 1 + rand() % 10; 
/* Write statements that move hare */ 
// determine which move to make 
if (y >= 1 && y <= 5)  // fast plod 
    *Hare += 3; 

else if (y == 6 || y == 7) // slip 
    *Hare -= 6; 
else       // slow plod 
    ++(*Hare); 

/* Write statements that test if hare is before 
the starting point or has finished the race */ 
if (*Hare < 1) 
    *Hare = 1; 

else if (*Hare > RACE_END) 
    *Hare = RACE_END; 
}