CI路由问题无法获得变量

Question

我遇到此路由的问题，不确定我的问题究竟是什么。

我的页面位于http://www.kansasoutlawwrestling.com/kowmanager/pmsystem/viewmessage/1其中1是消息ID。

我成立了一个路线，看起来像

$route['pmsystem/viewmessage/(:num)'] = 'pmsystem/viewmessage/$1'; 

，我仍然得到一个错误消息像这样

A PHP Error was encountered 

Severity: Warning 

Message: Missing argument 1 for Pmsystem::viewmessage() 

Filename: controllers/pmsystem.php 

Line Number: 76 


// View A Message 
function viewmessage($message_id) 
{ 
    //Config Defaults Start 
    $msgBoxMsgs = array();//msgType = dl, info, warn, note, msg 
    $cssPageAddons = '';//If you have extra CSS for this view append it here 
    $jsPageAddons = '<script src='.base_url().'../assets/js/cpanel/personalmessages.js></script><script src='.base_url().'assets/js/mylibs/jwysiwyg/jquery.wysiwyg.js></script>';//If you have extra JS for this view append it here 
    $metaAddons = '';//Sometimes there is a need for additional Meta Data such in the case of Facebook addon's 
    $siteTitle = '';//alter only if you need something other than the default for this view. 
    //Config Defaults Start 


    //examples of how to use the message box system (css not included). 
    //$msgBoxMsgs[] = array('msgType' => 'dl', 'theMsg' => 'This is a Blank Message Box...'); 

    /**********************************************************Your Coding Logic Here, Start*/ 

    // Checks to see if a session is active for user and shows corresponding view page 
    if (!$this->loggedin->chkLoginStatus() === FALSE) 
    { 
     if(! $this->uri->segment(3)) 
     { 
      redirect('error', 'refresh'); 
     } 
    } 
    else 
    { 
     redirect('login', 'refresh'); 
    } 
    $bodyContent = 'viewpm';//which view file 
    $bodyType = "full";//type of template     

    /***********************************************************Your Coding Logic Here, End*/ 

    //Double checks if any default variables have been changed, Start. 
    //If msgBoxMsgs array has anything in it, if so displays it in view, else does nothing.  
    if(count($msgBoxMsgs) !== 0) 
    { 
     $msgBoxes = $this->msgboxes->buildMsgBoxesOutput(array('display' => 'show', 'msgs' =>$msgBoxMsgs)); 
    } 
    else 
    { 
     $msgBoxes = array('display' => 'none'); 
    } 

    if($siteTitle == '') 
    { 
     $siteTitle = $this->metatags->SiteTitle(); //reads 
    } 

    //Double checks if any default variables have been changed, End. 

    $this->data['msgBoxes'] = $msgBoxes; 
    $this->data['cssPageAddons'] = $cssPageAddons;//if there is any additional CSS to add from above Variable this will send it to the view. 
    $this->data['jsPageAddons'] = $jsPageAddons;//if there is any addictional JS to add from the above variable this will send it to the view. 
    $this->data['metaAddons'] = $metaAddons;//if there is any addictional meta data to add from the above variable this will send it to the view. 
    $this->data['pageMetaTags'] = $this->metatags->MetaTags();//defaults can be changed via models/metatags.php 
    $this->data['siteTitle'] = $siteTitle;//defaults can be changed via models/metatags.php 
    $this->data['bodyType'] = $bodyType; 
    $this->data['bodyContent'] = $bodyContent; 
    $this->data['user_data'] = $this->users->getUserByUserId($this->session->userdata('user_id')); 
    $this->data['users'] = $this->loggedin->getUserList(); 
    $this->data['personal_messages'] = array($this->pmmodel->getTotalMessages($this->session->userdata('user_id')), $this->pmmodel->getTotalUnreadMessages($this->session->userdata('user_id')), $this->pmmodel->getLast5Messages($this->session->userdata('user_id'))); 
    $this->data['messages'] = array($this->pmmodel->getInboxMessages($this->session->userdata('user_id')), $this->pmmodel->getSentMessages($this->session->userdata('user_id'))); 
    //$this->data['message_data'] = $this->pmmodel->getPmMessage($this->uri->segment(3)); 
    $this->load->view('cpanel/index', $this->data); 
} 

UPDATE

// Checks to see if a session is active for user and shows corresponding view page 
    if (!$this->loggedin->chkLoginStatus() === FALSE) 
    { 
     if (!is_numeric($this->uri->segment(3))) 
     { 
      $this->data['message_data'] = 'Invalid message id!'; 
     } 
     else 
     { 
      $this->data['message_data'] = $this->pmmodel->getPmMessage($this->uri->segment(3)); 
     } 
     $bodyContent = 'viewpm';//which view file 
    } 
    else 
    { 
     redirect('login', 'refresh'); 
    } 

    $bodyType = "full";//type of template 

Answer 1

这条路线是不必要的 - 它不会改变任何东西。

$route['pmsystem/viewmessage/(:num)'] = 'pmsystem/viewmessage/$1'; 

您可以删除该路线。问题在于：

function viewmessage($message_id) // no default value means it's required 
{ 
    // your code 
} 

您的控制器方法从字面上接受用户输入作为参数（无论在地址栏中）。您始终必须考虑那些在CI控制器方法中不存在的必需参数。

function viewmessage($message_id = NULL) 
{ 
    if (! $message_id) show_404(); 
    // your code 
} 

如果所需的$message_id不存在，这将消除错误并显示404。另外，$this->uri->segment(3)是不必要的，因为它应该具有与$message_id相同的值。

我非常不喜欢重定向到一个错误页面，当你真的想要一个404，但这取决于你。这肯定不会帮助用户在重定向后地址丢失时意识到他们的错误，并且通过这样做发送错误的HTTP标头。