2016-07-25 107 views
0

我有一个方法来返回一个对象数组。 catalogVersion变量绑定到OECATVER实体。出于某种原因,我无法理解,当我们返回这个Object []时,代码在OECATVER上调用更新查询。我看不到任何会引起这种情况的事情,并且在返回此对象后它会立即发生。我在这个方法中看到的唯一查询是findOne(id)。这不应该导致更新,如果它?休眠/弹簧JPA findOne()调用更新命令

public Object[] getPrefixCatalogVersion(String itemPrefix, int itemBusinessUnit) { 
    CatalogVersion catalogVersion = null; 
    String prefixReplacementReason = null; 
    Object[] versionAndReason = new Object[2]; 

    CatalogPrefixKey prefixKey = new CatalogPrefixKey(); 
    prefixKey.setBusinessUnit(itemBusinessUnit); 
    prefixKey.setCatalogPrefix(itemPrefix); 
    CatalogPrefix catPrefix = catalogPrefixRepository.findOne(prefixKey); 

    CatalogVersionKey versionKey = new CatalogVersionKey(); 
    versionKey.setBusinessUnit(catPrefix.getKey().getBusinessUnit()); 
    versionKey.setCatalogNumber(catPrefix.getCatalogNumber()); 
    versionKey.setCatalogVersion(catPrefix.getCatalogVersion()); 
    catalogVersion = catalogVersionRepository.findOne(versionKey); 

    if (catalogVersion != null) { 
     // We have the version, make sure it's still valid... 
     // If it's not dead... 
     if (!isCatalogDead(catalogVersion)) { 
      // If it's active and not expired, add to the map. 
      if (isCatalogActive(catalogVersion, itemBusinessUnit)) { 
       if (!isCatalogExpired(catalogVersion)) { 
        // Do Nothing 
       } else { 
        prefixReplacementReason = CommonConstants.PREFIX_REPLACEMENT_REASON_EXPIRED; 
       } 
      } else { 
       prefixReplacementReason = CommonConstants.PREFIX_REPLACEMENT_REASON_NOT_ACTIVE; 
      } 
     } else { 
      prefixReplacementReason = CommonConstants.PREFIX_REPLACEMENT_REASON_END_LIFE; 
     } 
    } else { 
     prefixReplacementReason = CommonConstants.PREFIX_REPLACEMENT_REASON_INVALID; 
    } 

    versionAndReason[0] = catalogVersion; 
    versionAndReason[1] = prefixReplacementReason; 
    return versionAndReason; 
} 

这些是我在运行此方法时看到的日志。

Hibernate: select catalogpre0_.BUSUNTNBR as BUSUNTNB1_41_0_, catalogpre0_.CATPFX as CATPFX2_41_0_, catalogpre0_.lstupdjob as lstupdjo3_41_0_, catalogpre0_.lstupdnbr as lstupdnb4_41_0_, catalogpre0_.lstupdpgm as lstupdpg5_41_0_, catalogpre0_.lstupdtsp as lstupdts6_41_0_, catalogpre0_.lstupdusr as lstupdus7_41_0_, catalogpre0_.CATNBR as CATNBR8_41_0_, catalogpre0_.CATVER as CATVER9_41_0_ from OECATPFX catalogpre0_ where catalogpre0_.BUSUNTNBR=? and catalogpre0_.CATPFX=? 
Hibernate: select catalogver0_.BUSUNTNBR as BUSUNTNB1_43_0_, catalogver0_.CATNBR as CATNBR2_43_0_, catalogver0_.CATVER as CATVER3_43_0_, catalogver0_.lstupdjob as lstupdjo4_43_0_, catalogver0_.lstupdnbr as lstupdnb5_43_0_, catalogver0_.lstupdpgm as lstupdpg6_43_0_, catalogver0_.lstupdtsp as lstupdts7_43_0_, catalogver0_.lstupdusr as lstupdus8_43_0_, catalogver0_.CATVERDSC as CATVERDS9_43_0_, catalogver0_.CURCATPCG as CURCATP10_43_0_, catalogver0_.EFFDAT as EFFDAT11_43_0_, catalogver0_.EXPDAT as EXPDAT12_43_0_, catalogver0_.PSDSALFLG as PSDSALF13_43_0_ from OECATVER catalogver0_ where catalogver0_.BUSUNTNBR=? and catalogver0_.CATNBR=? and catalogver0_.CATVER=? 
Hibernate: select catalog0_.BUSUNTNBR as BUSUNTNB1_40_0_, catalog0_.CATNBR as CATNBR2_40_0_, catalog0_.lstupdjob as lstupdjo3_40_0_, catalog0_.lstupdnbr as lstupdnb4_40_0_, catalog0_.lstupdpgm as lstupdpg5_40_0_, catalog0_.lstupdtsp as lstupdts6_40_0_, catalog0_.lstupdusr as lstupdus7_40_0_, catalog0_.CATEOLDAT as CATEOLDA8_40_0_, catalog0_.CATNAM as CATNAM9_40_0_, catalog0_.CATTHMCLF as CATTHMC10_40_0_, catalog0_.CATTYPCLF as CATTYPC11_40_0_ from OECATMST catalog0_ where catalog0_.BUSUNTNBR=? and catalog0_.CATNBR=? 
Hibernate: select orderentry0_.BUSUNTNBR as BUSUNTNB1_6_0_, orderentry0_.lstupdjob as lstupdjo2_6_0_, orderentry0_.lstupdnbr as lstupdnb3_6_0_, orderentry0_.lstupdpgm as lstupdpg4_6_0_, orderentry0_.lstupdtsp as lstupdts5_6_0_, orderentry0_.lstupdusr as lstupdus6_6_0_, orderentry0_.AREMLPMP as AREMLPMP7_6_0_, orderentry0_.ALWNTLACT as ALWNTLAC8_6_0_, orderentry0_.ATOASNCGY as ATOASNCG9_6_0_, orderentry0_.AVLJOBSFY as AVLJOBS10_6_0_, orderentry0_.CASQTYLMT as CASQTYL11_6_0_, orderentry0_.COPITMFLG as COPITMF12_6_0_, orderentry0_.CREPSPCUS as CREPSPC13_6_0_, orderentry0_.VRLCATNBR as VRLCATN14_6_0_, orderentry0_.VRLCATPFX as VRLCATP15_6_0_, orderentry0_.VRLCATVER as VRLCATV16_6_0_, orderentry0_.VRLKEYCOD as VRLKEYC17_6_0_, orderentry0_.DFTQTEDAY as DFTQTED18_6_0_, orderentry0_.DSPOFRPRV as DSPOFRP19_6_0_, orderentry0_.DUPORD as DUPORD20_6_0_, orderentry0_.EMLPMPFLG as EMLPMPF21_6_0_, orderentry0_.EMPKEYCOD as EMPKEYC22_6_0_, orderentry0_.HGHPRCCHK as HGHPRCC23_6_0_, orderentry0_.HGHQTYCHK as HGHQTYC24_6_0_, orderentry0_.IPRCNFAMT as IPRCNFA25_6_0_, orderentry0_."Jobber Safety Threshold" as Jobber26_6_0_, orderentry0_.MAXQTEDAY as MAXQTED27_6_0_, orderentry0_.PFXRQDFLG as PFXRQDF28_6_0_, orderentry0_.PRCOVRCHK as PRCOVRC29_6_0_, orderentry0_.PRCGRCPED as PRCGRCP30_6_0_, orderentry0_.ORDRSNCLF as ORDRSNC31_6_0_, orderentry0_.RQROPBFLG as RQROPBF32_6_0_, orderentry0_.SPLTABRQD as SPLTABR33_6_0_, orderentry0_.USEKEYCGY as USEKEYC34_6_0_, orderentry0_.WGTLMT as WGTLMT35_6_0_ from COBRLORD orderentry0_ where orderentry0_.BUSUNTNBR=? 
Hibernate: update OECATVER set lstupdjob=?, lstupdnbr=?, lstupdpgm=?, lstupdtsp=?, lstupdusr=?, CATVERDSC=?, CURCATPCG=?, EFFDAT=?, EXPDAT=?, PSDSALFLG=? where BUSUNTNBR=? and CATNBR=? and CATVER=? 

更新:

public boolean isCatalogDead(CatalogVersion catalogVersion) { 
    Calendar today = Calendar.getInstance(); 
    CatalogKey key = new CatalogKey(); 
    key.setBusinessUnit(catalogVersion.getKey().getBusinessUnit()); 
    key.setCatalogNumber(catalogVersion.getKey().getCatalogNumber()); 

    Catalog catalog = catalogRepository.findOne(key); 

    if (catalog != null) { 
     Calendar endOfLifeDate = catalog.getEndOfLifeDate(); 
     if (today.after(endOfLifeDate)) { 
      return true; 
     } else { 
      return false; 
     } 
    } else { 
     return false; 
    } 

} 

public boolean isCatalogActive(CatalogVersion catalogVersion, int itemBusinessUnit) { 
    Calendar today = Calendar.getInstance(); 
    // Check to see if the catalog is still available 
    Calendar fromDate = catalogVersion.getEffectiveDate(); 
    int gracePeriodDays = companyService.getPricingGracePeriodDays(itemBusinessUnit); 
    fromDate.add(Calendar.DAY_OF_YEAR, gracePeriodDays * -1); 
    if (today.before(fromDate)) { 
     return false; 
    } else { 
     return true; 
    } 
} 

public boolean isCatalogExpired(CatalogVersion catalogVersion) { 
    Calendar today = Calendar.getInstance(); 
    Calendar toDate = catalogVersion.getExpirationDate(); 
    if (today.after(toDate)) { 
     return true; 
    } else { 
     return false; 
    } 

} 
+0

哇...里面是什么:isCatalogDead; isCatalogActive; isCatalogExpired?如果它在事务内部,任何更改都会保存到db,无论你调用.save(entity)还是不。 – Sarief

+0

只是你知道,你应该重构这个......另外,命名... – Sarief

回答

0

我能够确定的问题。问题出在isCatalogActive()方法中,见下文。当我更新fromDate变量时,它也在更新catalogVersion中的日期。我将其更改为为fromDate创建一个新的Calendar对象,并将时间设置为与catalogVersion.getEffectiveDate()相同;并以这种方式与fromDate合作。

老方法

public boolean isCatalogActive(CatalogVersion catalogVersion, int itemBusinessUnit) { 
    Calendar today = Calendar.getInstance(); 
    // Check to see if the catalog is still available 
    Calendar fromDate = catalogVersion.getEffectiveDate(); 
    int gracePeriodDays = companyService.getPricingGracePeriodDays(itemBusinessUnit); 
    fromDate.add(Calendar.DAY_OF_YEAR, gracePeriodDays * -1); 
    if (today.before(fromDate)) { 
     return false; 
    } else { 
     return true; 
    } 
} 

NEW WAY

public boolean isCatalogActive(CatalogVersion catalogVersion, int itemBusinessUnit) { 
    Calendar today = Calendar.getInstance(); 
    // Check to see if the catalog is still available 
    Calendar fromDate = Calendar.getInstance(); 
    fromDate.setTime(catalogVersion.getEffectiveDate().getTime()); 
    int gracePeriodDays = companyService.getPricingGracePeriodDays(itemBusinessUnit); 
    fromDate.add(Calendar.DAY_OF_YEAR, gracePeriodDays * -1); 
    if (today.before(fromDate)) { 
     return false; 
    } else { 
     return true; 
    } 
}