2012-06-15 47 views
0

我正在尝试在SQLiteDatabase中添加一个新列,但每次尝试运行带有新列的代码时,它都会崩溃。如果我只是添加新列,那么它运行正常,但是当我尝试在代码中使用它时,它会崩溃。有问题的值是KEY_END_TIME以及其中包含单词“end”的任何值。我尝试传递与KEY_DATE_TIME相同的精确值,或多或少地在完全相同的上下文中使用它们,以尝试使其运行,但每次都立即崩溃。任何帮助或建议将不胜感激。为什么我的数据库在添加新列后崩溃?

/** 
* Simple reminder database access helper class. 
* Defines the basic CRUD operations (Create, Read, Update, Delete) 
* for the example, and gives the ability to list all reminders as well as 
* retrieve or modify a specific reminder. 
* 
*/ 
public class RemindersDbAdapter { 

// 
// Databsae Related Constants 
// 
private static final String DATABASE_NAME = "data"; 
private static final String DATABASE_TABLE = "reminders"; 
private static final int DATABASE_VERSION = 4; 

public static final String KEY_TITLE = "title"; 
public static final String KEY_CUSTOMER = "body"; 
public static final String KEY_DATE_TIME = "reminder_date_time"; 
public static final String KEY_END_TIME = "reminder_end_time"; 
public static final String KEY_ROWID = "_id"; 


private static final String TAG = "ReminderDbAdapter"; 
private DatabaseHelper mDbHelper; 
private SQLiteDatabase mDb; 

/** 
* Database creation SQL statement 
*/ 
private static final String DATABASE_CREATE = 
     "create table " + DATABASE_TABLE + " (" 
       + KEY_ROWID + " integer primary key autoincrement, " 
       + KEY_TITLE + " text not null, " 
       + KEY_CUSTOMER + " text not null, " 
       + KEY_DATE_TIME + " text not null);" 
       + KEY_END_TIME + " text not null);"; 



private final Context mCtx; 

private static class DatabaseHelper extends SQLiteOpenHelper { 

    DatabaseHelper(Context context) { 
     super(context, DATABASE_NAME, null, DATABASE_VERSION); 
    } 

    @Override 
    public void onCreate(SQLiteDatabase db) { 

     db.execSQL(DATABASE_CREATE); 
    } 

    @Override 
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { 
     Log.w(TAG, "Upgrading database from version " + oldVersion + " to " 
       + newVersion + ", which will destroy all old data"); 

     db.execSQL("DROP TABLE IF EXISTS " + DATABASE_TABLE); 
     onCreate(db); 
    } 
} 

/** 
* Constructor - takes the context to allow the database to be 
* opened/created 
* 
* @param ctx the Context within which to work 
*/ 
public RemindersDbAdapter(Context ctx) { 
    this.mCtx = ctx; 
} 

/** 
* Open the database. If it cannot be opened, try to create a new 
* instance of the database. If it cannot be created, throw an exception to 
* signal the failure 
* 
* @return this (self reference, allowing this to be chained in an 
*   initialization call) 
* @throws SQLException if the database could be neither opened or created 
*/ 
public RemindersDbAdapter open() throws SQLException { 
    mDbHelper = new DatabaseHelper(mCtx); 
    mDb = mDbHelper.getWritableDatabase(); 
    return this; 
} 

public void close() { 
    mDbHelper.close(); 
} 


/** 
* Create a new reminder using the title, body and reminder date time provided. 
* If the reminder is successfully created return the new rowId 
* for that reminder, otherwise return a -1 to indicate failure. 
* 
* @param title the title of the reminder 
* @param body the body of the reminder 
* @param reminderDateTime the date and time the reminder should remind the user 
* @return rowId or -1 if failed 
*/ 
public long createReminder(String title, String body, String reminderDateTime, String  reminderEndTime) { 
    ContentValues initialValues = new ContentValues(); 
    initialValues.put(KEY_TITLE, title); 
    initialValues.put(KEY_CUSTOMER, body); 
    initialValues.put(KEY_DATE_TIME, reminderDateTime); 
    initialValues.put(KEY_END_TIME, reminderDateTime); 

    return mDb.insert(DATABASE_TABLE, null, initialValues); 
} 

/** 
* Delete the reminder with the given rowId 
* 
* @param rowId id of reminder to delete 
* @return true if deleted, false otherwise 
*/ 
public boolean deleteReminder(long rowId) { 

    return mDb.delete(DATABASE_TABLE, KEY_ROWID + "=" + rowId, null) > 0; 
} 

/** 
* Return a Cursor over the list of all reminders in the database 
* 
* @return Cursor over all reminders 
*/ 
public Cursor fetchAllReminders() { 

    return mDb.query(DATABASE_TABLE, new String[] {KEY_ROWID, KEY_TITLE, 
      KEY_CUSTOMER, KEY_DATE_TIME, KEY_END_TIME}, null, null, null, null, null); 
} 

/** 
* Return a Cursor positioned at the reminder that matches the given rowId 
* 
* @param rowId id of reminder to retrieve 
* @return Cursor positioned to matching reminder, if found 
* @throws SQLException if reminder could not be found/retrieved 
*/ 
public Cursor fetchReminder(long rowId) throws SQLException { 

    Cursor mCursor = 

      mDb.query(true, DATABASE_TABLE, new String[] {KEY_ROWID, 
        KEY_TITLE, KEY_CUSTOMER, KEY_DATE_TIME, KEY_END_TIME}, KEY_ROWID +  "=" + rowId, null, 
        null, null, null, null); 
    if (mCursor != null) { 
     mCursor.moveToFirst(); 
    } 
    return mCursor; 

} 

/** 
* Update the reminder using the details provided. The reminder to be updated is 
* specified using the rowId, and it is altered to use the title, body and reminder  date time 
* values passed in 
* 
* @param rowId id of reminder to update 
* @param title value to set reminder title to 
* @param body value to set reminder body to 
* @param reminderDateTime value to set the reminder time. 
* @return true if the reminder was successfully updated, false otherwise 
*/ 
public boolean updateReminder(long rowId, String title, String body, String reminderDateTime, String reminderEndTime) { 
    ContentValues args = new ContentValues(); 
    args.put(KEY_TITLE, title); 
    args.put(KEY_CUSTOMER, body); 
    args.put(KEY_DATE_TIME, reminderDateTime); 
    args.put(KEY_END_TIME, reminderEndTime); 

    return mDb.update(DATABASE_TABLE, args, KEY_ROWID + "=" + rowId, null) > 0; 
} 

}

06-15 18:11:12.356: E/AndroidRuntime(790): FATAL EXCEPTION: main 
06-15 18:11:12.356: E/AndroidRuntime(790): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.dummies.android.TaskReminder/com.dummies.android.TaskReminder.TaskReminderActivity}: android.database.sqlite.SQLiteException: no such column: reminder_end_time: , while compiling: SELECT _id, title, body, reminder_date_time, reminder_end_time FROM reminders 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1956) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1981) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread.access$600(ActivityThread.java:123) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1147) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.os.Handler.dispatchMessage(Handler.java:99) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.os.Looper.loop(Looper.java:137) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread.main(ActivityThread.java:4424) 
06-15 18:11:12.356: E/AndroidRuntime(790): at java.lang.reflect.Method.invokeNative(Native Method) 
06-15 18:11:12.356: E/AndroidRuntime(790): at java.lang.reflect.Method.invoke(Method.java:511) 
06-15 18:11:12.356: E/AndroidRuntime(790): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784) 
06-15 18:11:12.356: E/AndroidRuntime(790): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551) 
06-15 18:11:12.356: E/AndroidRuntime(790): at dalvik.system.NativeStart.main(Native Method) 
06-15 18:11:12.356: E/AndroidRuntime(790): Caused by: android.database.sqlite.SQLiteException: no such column: reminder_end_time: , while compiling: SELECT _id, title, body, reminder_date_time, reminder_end_time FROM reminders 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteCompiledSql.native_compile(Native Method) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteCompiledSql.<init>(SQLiteCompiledSql.java:68) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteProgram.compileSql(SQLiteProgram.java:143) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteProgram.compileAndbindAllArgs(SQLiteProgram.java:361) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:127) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:94) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteQuery.<init>(SQLiteQuery.java:53) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:47) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1564) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteDatabase.queryWithFactory(SQLiteDatabase.java:1449) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1405) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1485) 
06-15 18:11:12.356: E/AndroidRuntime(790): at com.dummies.android.TaskReminder.RemindersDbAdapter.fetchAllReminders(RemindersDbAdapter.java:144) 
06-15 18:11:12.356: E/AndroidRuntime(790): at com.dummies.android.TaskReminder.TaskReminderActivity.fillData(TaskReminderActivity.java:40) 
06-15 18:11:12.356: E/AndroidRuntime(790): at com.dummies.android.TaskReminder.TaskReminderActivity.onCreate(TaskReminderActivity.java:33) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.Activity.performCreate(Activity.java:4465) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1049) 
06-15 18:11:12.356: E/AndroidRuntime(790): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1920) 
+0

你增加了DATABASE_VERSION吗? –

+1

如果您已经创建了一次数据库和表,那么'SQLiteOpenHelper'的'onCreate(...)'方法将不会再次运行。你确定你已经增加了数据库版本号以确保'onUpgrade()'运行? – Squonk

+0

是的,除非我做错了,你所做的只是将DATABASE_VERSION从3改为4吧? – user1457104

回答

1

你的sql创建字符串是错误的。修改这样的:

...+ KEY_DATE_TIME + " text not null, " 
       + KEY_END_TIME + " text not null);"; 

记住要卸载,然后重新安装应用程序,以便在onCreate方法再次被调用和数据库重建。

+0

在事后看来,它是一个愚蠢的错误。感谢您的帮助,这个网站是一个真正的生活救星! – user1457104

1

我认为问题

"create table " + DATABASE_TABLE + " (" 
     + KEY_ROWID + " integer primary key autoincrement, " 
     + KEY_TITLE + " text not null, " 
     + KEY_CUSTOMER + " text not null, " 
     + KEY_DATE_TIME + " text not null);" 
     + KEY_END_TIME + " text not null);"; 

“);”获得两倍

+0

您可能是对的,但有没有更新它的具体方法?如果我只是更改 DATABASE_VERSION = 4,我是否更新了错误; DATABASE_VERSION = 5; ? – user1457104

1

你的create语句是恶意形成的:

+ KEY_DATE_TIME + " text not null);" 
      + KEY_END_TIME + " text not null);"; 

你必须关闭 “);”两次,所以添加KEY_END_TIME的行不在create语句中,并且未被执行。