2013-03-01 1558 views
3

我使用* .asc文件打开,重新格式化,然后另存为与原始文件同名的Excel文件(带有xls扩展名)。将* .asc文件保存为Excel文件

我用宏记录器和我在网上找到的代码打开个别文件并根据需要重新格式化它们。代码的那部分起作用。

我无法保存为Excel文件。它给了我Run Time error of 1004 Method ‘SaveAs’ of object ‘_Workbook’ failed。我尝试了很多我在网上找到的不同代码(仍然在那里,只是注释掉了),但都没有工作。

两个问题:

  1. 你能提供的建议来解决问题另存为?

  2. 您能否提供关于如何自动打开和保存一个文件夹中所有文件的建议?

这里是我的代码:

Sub OpenFormatSave() 
' 
' OpenFormatSave Macro 
' 

Dim StrFileName As String 
Dim NewStrFileName As String 
    ChDir _ 
     "C:\Users\Owner\Documents\work_LLRS\GoM\NASA_data\Satellite_files_GoM_3Dec2012" 
    StrFileName = Application.GetOpenFilename("NASA Files (*.asc), *.asc") 
    If TypeName(StrFileName) <> "Boolean" Then 
     Workbooks.OpenText Filename:=StrFileName, _ 
     Origin:=437, StartRow:=1, DataType:=xlDelimited, TextQualifier:= _ 
     xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, Semicolon:=False, _ 
     Comma:=False, Space:=True, Other:=False, FieldInfo:=Array(Array(1, 1), _ 
     Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1), Array(7, 1), Array(8, 1), _ 
     Array(9, 1), Array(10, 1)), TrailingMinusNumbers:=True 
    End If 
    Rows("1:1").Select 
    Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove 
    Range("A1").Select 
    ActiveCell.FormulaR1C1 = "Year" 
    Range("B1").Select 
    ActiveCell.FormulaR1C1 = "Day_of_Year" 
    Range("C1").Select 
    ActiveCell.FormulaR1C1 = "Longitude" 
    Range("D1").Select 
    ActiveCell.FormulaR1C1 = "Latitude" 
    Range("E1").Select 
    ActiveCell.FormulaR1C1 = "Chla_mg_m-3" 
    Range("F1").Select 
    ActiveCell.FormulaR1C1 = "POC_mmolC_m-3" 
    Range("G1").Select 
    ActiveCell.FormulaR1C1 = "SPM_g_m-3" 
    Range("H1").Select 
    ActiveCell.FormulaR1C1 = "aCDOM355_m-1" 
    Range("I1").Select 
    ActiveCell.FormulaR1C1 = "DOC_mmolC_m-3" 
    Range("J1").Select 
    ActiveCell.FormulaR1C1 = "L2_flags" 

    Columns("A:B").Select 
    Selection.NumberFormat = "0" 
    Columns("C:D").Select 
    Selection.NumberFormat = "0.0000" 
    Columns("E:E").Select 
    Selection.NumberFormat = "0.000" 
    Columns("F:F").Select 
    Selection.NumberFormat = "0.0" 
    Columns("G:H").Select 
    Selection.NumberFormat = "0.000" 
    Columns("I:I").Select 
    Selection.NumberFormat = "0.0" 
    Columns("J:J").Select 
    Selection.NumberFormat = "0.00E+00" 



'Mid(StrFileName, 1, InStrRev(StrFileName, ".")) = "xlsm" 

'With ActiveWorkbook 
    'NewStrFileName = Replace(.StrFileName, ".asc", ".xls") 
    ' .SaveAs Filename:=FullName, FileFormat:=xlsx, AddToMRU:=False 
    ' .Close SaveChanges:=True 
'End With 

StrFileName = ThisWorkbook.Name 
GetName: 
StrFileName = Application.GetSaveAsFilename(NewStrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

' FileMonth is the Workbook name, filter options to save a older version file 
'If Dir(NewStrFileName) = "" Then 
' ActiveWorkbook.SaveAs NewStrFileName 
'Else 
' If MsgBox("That file exists. Overwrite?", vbYesNo) = vbNo Then GoTo GetName 
    ' Application.DisplayAlerts = False 
    ' ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, AddToMRU:=False 
    'Application.DisplayAlerts = True 
'End If 
    'ActiveWorkbook.Close SaveChanges:=True 


ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, CreateBackup:=False 

'With ThisWorkbook 
    'FullName = Replace(.StrFileName, ".asc", ".xlsx") 
    '.Save 
    '.SaveAs StrFileName, FileFormat:=xlsx 
    '.Close 
    'SaveChanges:=True 
'End With 



'StrFileName = Split(ActiveWorkbook.FullName, ".xls")(0) 

'ActiveWorkbook.SaveAs Filename:="...", FileFormat:=xlsx, AddToMRU:=False 
'ActiveWorkbook.Close SaveChanges:=True 

'ActiveWorkbook.Save 
End Sub 

回答

3

更改你的另存为的方法来此的FileFormat部分:

FileFormat:=xlOpenXMLWorkbook, CreateBackup:=False 
0

要通过的所有文件夹中的迭代,你有两个选择。

  1. 使用built-in VBA Dir function
  2. 使用方法FileSystemObject

我将给出一个Dir的例子,因为它不需要在你的VBA项目中添加一个引用。不幸的是,Dir界面比FileSystemObject更不直观,也不现代。

Dim path As String 

path = Dir("C:\Users\example\Documents\AscFiles\*.asc") 
Do 
    If path = vbNullString Then Exit Do 

    ' do something with path here 
    Debug.Print path 

    path = Dir 
Loop 
0

你有两个变量StrFileName(大概是打算作为当前文件名)和NewStrFileName(大概意欲在新的文件名)。

在这段代码:

StrFileName = Application.GetSaveAsFilename(NewStrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

已全面使用这些变量走错了路。 “另存为”对话框打开时的建议文件名基于NewStrFileName,但从未给出该值,因此为空字符串""。然后由用户选择的值保存到StrFileName

当你保存文件与此代码:

ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, _ 
    CreateBackup:=False 

NewStrFileName变量仍然包含"",因此您要保存文件不给它是一个明显产生错误的名称。

对于一个简单的修复,只是交换的呼叫中的两个变量来GetSaveAsFilename

NewStrFileName = Application.GetSaveAsFilename(StrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

这是不是达到你想要什么是最好的方式,但它至少应该工作