3
我有一个存储过程,更新多个位置的库存项目。我主要试图做的是允许正确记录库位之间的库存转移。更新记录,如果失败,插入记录,然后更新
我遇到的问题是,某些位置没有为大多数类型的库存物品的记录,所以当我尝试更新的数量(-1从开始的位置,+1到新的位置)有没有记录要更新。
这里是我的存储过程:
CREATE procedure dbo.Inv_Transfer (@p_hStock numeric,
@p_sFProp varchar(20), @p_hTProp numeric,
@p_dQuan numeric, @p_Date datetime,
@p_sUser1 varchar(1000),@p_sUser2 varchar(1000))
as
declare
@v_FInvhMy numeric,
@v_TInvhMy numeric,
@v_sStockCode varchar(10),
@v_hFProp numeric,
@v_ibegin int,
@v_iend int
begin
set @v_ibegin = charindex('(', @p_sFProp )
if @v_ibegin <= 0
begin
raiserror('From property string not readable',16,1, @p_sFProp)
return(0)
end
else
begin
set @v_iend = charindex (')',@p_sFProp)
set @v_hFProp = substring(@p_sFProp,@v_ibegin + 1,@v_iend - @v_ibegin -1)
end
select @v_sStockCode = sCode from mm2stock where hMy = @p_hStock
if @@ERROR<> 0
begin
raiserror('Stock read failed ',16,1)
return(0)
end
select @v_FInvhMy = hMy from mm2inventory where hStock = @p_hStock and hStoreProp = @v_hFprop
if @@ERROR<> 0
begin
raiserror('From inventory read failed ',16,1)
return(0)
end
select @v_TInvhMy = hMy from mm2inventory where hstock = @p_hStock and hStoreProp = @p_hTProp
if @@ERROR<> 0
begin
raiserror('To inventory read failed ',16,1)
return(0)
end
update mm2inventory set iQtyonHand = iQtyonHand - @p_dquan where hmy = @v_FInvhMy
if @@ERROR<> 0
begin
raiserror('Update from inventory failed ',16,1)
return(0)
end
update mm2inventory set iQtyonHand = iQtyonHand + @p_dquan where hmy = @v_TInvhMy
if @@ERROR<> 0
begin
raiserror('Update to inventory failed ',16,1)
return(0)
end
else
begin
INSERT INTO mm2inventory (scode, hstock, hstoreprop, dcosteach, dbillprice, ireorderlevel, ireorderqty, iqtyonorder, iqtyonhand, suser1, suser2, suser3, suser4, snotes)
SELECT (SELECT hmy + 1 where hmy in (select max(hmy) from mm2inventory)),@p_hStock,@p_hTProp,(SELECT dcosteach from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT dbillprice from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT ireorderlevel from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT ireorderqty from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),0,0,'','','','','' FROM mm2inventory
update mm2inventory set iQtyonHand = iQtyonHand + @p_dquan where hmy = @v_TInvhMy
end
insert into mm2InvXfer(sStock,hinvfrom,hinvto,dquant,dtdate,sUser1,sUser2)
values (@v_sStockCode,@v_FinvhMy, @v_TInvhMy, @p_dquan,
isnull(@p_Date,getdate()), @p_sUser1, @p_sUser2)
if @@ERROR<> 0
begin
raiserror('Insert into inventoryxfer table failed ',16,1)
return(0)
end
end
摘录我的工作:
update mm2inventory set iQtyonHand = iQtyonHand - @p_dquan where hmy = @v_FInvhMy
if @@ERROR<> 0
begin
raiserror('Update from inventory failed ',16,1)
return(0)
end
update mm2inventory set iQtyonHand = iQtyonHand + @p_dquan where hmy = @v_TInvhMy
if @@ERROR<> 0
begin
raiserror('Update to inventory failed ',16,1)
return(0)
end
else
begin
INSERT INTO mm2inventory (scode, hstock, hstoreprop, dcosteach, dbillprice, ireorderlevel, ireorderqty, iqtyonorder, iqtyonhand, suser1, suser2, suser3, suser4, snotes)
SELECT (SELECT hmy + 1 where hmy in (select max(hmy) from mm2inventory)),@p_hStock,@p_hTProp,(SELECT dcosteach from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT dbillprice from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT ireorderlevel from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),(SELECT ireorderqty from mm2inventory where hstock = @p_hStock and hstoreprop = @v_hFProp),0,0,'','','','','' FROM mm2inventory
update mm2inventory set iQtyonHand = iQtyonHand + @p_dquan where hmy = @v_TInvhMy
end
所以,你可以在上面看到,我试图更新(工作正常如果两个存储位置的库存项目都存在记录),但是如果出现错误,那么我想为该特定库存项目插入新行,然后使用新数量值更新它,但是我做错了某些事情。
谁能告诉我我做错了什么? 感谢
建议:使用交易。当您必须更新多个表并出错时,您应该能够撤消(回滚)所有更改以保持数据有效。 – ZippyV 2013-04-11 20:03:20
另一个建议:使用关键字'EXISTS'来检查一行是否已经存在。 http://msdn.microsoft.com/en-us/library/ms188336.aspx – ZippyV 2013-04-11 20:05:10
感谢您的建议Zippy。至于'EXISTS',可能是这样的: IF(EXISTS(SELECT'record' FROM'table' WHERE' inventory_Item_May_exist'))'UPDATE' ELSE'INSERT_THEN_UPDATE'? – reubenCanowski 2013-04-11 20:14:02