2013-03-23 91 views
-3

我目前很难理解为什么下面的脚本将成功返回给浏览器,但实际上并没有将数据插入到数据库中。 我知道我使用旧的MySQL指令,但我怀疑这应该是造成这个问题。 由于提前阿利斯泰尔PHP没有插入到MySQL数据库中

<?php 

ob_start(); 
$host="localhost"; // Host name 
$username="XXXXXX"; // Mysql username 
$password="XXXXXXXXXXXXXXXXXXX"; // Mysql password 
$db_name="XXXXXXXX"; // Database name 
$tbl_name="XXXXXXXXXX"; // Table name 

// Connect to server and select databse. 
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB"); 

// Define Variables 
$myusername=$_POST['username']; 
$password1=$_POST['password1']; 
$password2=$_POST['password2']; 
$emailadd=$_POST['emailadd']; 

if($password1==$password2){ 
    //Ecnrypt Password Using SHA512 
    $password1 = hash("sha512", $password1); 
} 

else { 
    //Passwords don't match return user to form with parameter 
    header("location:adduser.php?pwnomatch"); 
} 

//Check user doesn't already exist 
$sqlcheckuser="SELECT * FROM $tbl_name WHERE username='$username'"; 
$result1=mysql_query($sqlcheckuser); 

// Mysql_num_row is counting table row 
$count=mysql_num_rows($result1); 

//If user exists redirect back to login form 
if($count==1){ 
    header("location:adduser.php?userexist"); 
} 

// To protect MySQL injection (more detail about MySQL injection) 
$username = stripslashes($myusername); 
$password1 = stripslashes($mypassword); 
$emailadd = stripslashes($emailladd); 
$myusername = mysql_real_escape_string($myusername); 
$mypassword = mysql_real_escape_string($mypassword); 
$emailadd = mysql_real_escape_string($emailladd); 
$sqlinsertuser="INSERT INTO $tbl_name ('username', 'password', 'emailaddress' VALUES ($username, $password1, $emailadd)"; 
mysql_query($sqlinsertuser); 

// Mysql_num_row is counting table row 
$count=mysql_num_rows($result2); 

// Register user then redirect to "viewuser.php" with success parameter 
header("location:viewuser.php?success"); 

ob_end_flush(); 
?> 
+1

SQL注入,我来了。 :) – hjpotter92 2013-03-23 11:46:24

回答

3
INSERT INTO $tbl_name ('username', 'password', 'emailaddress' VALUES ($username, $password1, $emailadd) 

您还没有关闭了支架上的列名。因此,您的查询应该是这样的:

INSERT INTO $tbl_name (`username`, `password`, `emailaddress`) VALUES ($username, $password1, $emailadd) 

还有一点我没有在我原来的职位通知;您使用了引号而不是反引号。

行情中查询通常代表一个字符串,反引号进行了说明:

Using backticks around field names

+0

downvote的原因是什么? – 2013-03-23 11:46:06

+2

我没有downvote,但如果我有,这将是因为引号不是反引号 – Strawberry 2013-03-23 11:49:13

+0

@Strawberry排序 – 2013-03-23 12:00:41

1

您的查询字符串了很多错误。它应该是

$sqlinsertuser="INSERT INTO $tbl_name (`username`, `password`, `emailaddress`) 
     VALUES('$myusername', '$mypassword', '$emailadd')"; 

通知传递的字段名称使用反引号,而不是单引号的。并且在VALUES内使用引号。


您在查询中使用了错误的变量。