2017-06-02 79 views
1

我想用Python语言编写一个函数,它告诉,如果我给数是素数,到目前为止我的代码是:FUNCTION_NAME没有定义错误

def enter_input(): 
    n=input("Enter the number to be checked\n") 
    return n 

def check(): 
    o=int(enter_input()) 
    r=o 
    print(type(o)) 
    print(type(r)) 
    bool=True 
    for i in range(2,r,1): 
     if(o%i==0): 
      return False 
    return True 

def display(): 
    print("Entered Number Is {0}".format(p)) 
    print("The Number is a Prime:{0}".format(check())) 


enter_input() 
check() 
display() 

但我输入后得到这个错误NUMER:

运行时间: -

Enter the number to be checked 
23 
Traceback (most recent call last): 
    File "Chech_Prime.py", line 8, in check 
    o=int(enter_input()) 
    NameError: name 'enter_input' is not defined 

REPL封闭

我哪里错了?这是我第一次尝试函数调用,看起来像我称为enter_input()函数的地方找不到它。感谢您的帮助

+0

“p”变量的定义在哪里? –

+0

对于'p'我很抱歉,应该是'o'。但问题仍然存在。 –

+0

Okey,我修改了一下你的代码尝试它,在中间时间,我会写一个解释给你 –

回答

1

你写出头有点奇怪,所以我会解释为什么这应该做你specting什么:

这是你的代码,我会字里行间评论:

def enter_input(): 
    n=input("Enter the number to be checked\n") 
    return n 

def check(): # you create the check function, and then a display function, and is not necesary, because you want to do both thinks in the same function 
    o=int(enter_input()) # you call this function a lot of times, and you only want to input the value once, so, is better to call the input method inside the function 
    r=o # is better to name variables more descriptive, I mean, check() as a function, what checks? maybe you want to call it is_prime(), more descriptive, o and p... doesn't say anything, but input sounds better 
    print(type(o)) 
    print(type(r)) #this auxiliar variable is not needed 
    bool=True 
    for i in range(2,r,1): 
     if(o%i==0): 
      return False 
    return True 

def display(): 
    print("Entered Number Is {0}".format(p)) 
    print("The Number is a Prime:{0}".format(check()))# here you again call the function, and again it ask to you to add a input... not good 


enter_input() 
check() # and again.. three times, that's so confusing even to follow when you are adding the inputs 
display() 

我的做法是:

def print_is_prime(): 
    value_to_eval=int(input("Enter the number to be checked\n")) 

    print("the type of the value is " + str(value_to_eval.__class__.__name__)) 

    is_prime =True #initial value is correct 
    for i in range(2,value_to_eval,1): 
     if(value_to_eval%i==0): 
      is_prime = False #here, you detect is not prime 
      break # so with break you can avoid to execute innecesary all the loop 

    is_prime = True and is_prime # with and operator, true is the neutral, so the value will be always the other value, in this case, is_prime, this like 0 + x, the value will be always x 

    print("Entered Number Is {0}".format(value_to_eval)) 
    print("The Number is a Prime:{0}".format(is_prime)) 

print_is_prime() 
+0

感谢达米安,修改过的代码工作。我试图学习功能和他们互相呼叫的方式,所以我做了3个不同的功能,而不是一个。我将通过新代码并解决问题。 –

+0

@Ritesh_BM我一直都很喜欢帮忙,如果你喜欢,不要忘记接受(✓)和投票:) –