2016-11-08 218 views
1

我编码在吃豆子僵尸一些RL的行为和我在我的函数arg_allmax一个把事情搞乱我的列表中的一个chooseActionArrayIndexOutOfBoundsException异常:-1

这里的代码我类:

package rl; 

import java.util.ArrayList; 
import java.util.Hashtable; 

public class Qlearn { 
    private double epsilon = 0.1; // Epsilon parameter for the Epsilon Greedy Strategy 
    private double alpha = 0.2; // Alpha parameter: used to influence o the refresh of Q 
    private double gamma = 0.9; // used to notice or not the feedback of the next action ; if =0 -> no feed back 

private int actions[]; 
private Hashtable< Tuple<Integer,Integer>, Double> q; // Q(s,a) : hashTable : <state,action> -> value of q 


public Qlearn(int[] actions) { 
    this.actions = actions; 
    q = new Hashtable< Tuple<Integer,Integer>, Double>(); 
} 

public Qlearn(int[] actions, double epsilon, double alpha, double gamma) { 
    this.actions = actions; 
    this.epsilon = epsilon; 
    this.alpha = alpha; 
    this.gamma = gamma; 
    q = new Hashtable< Tuple<Integer,Integer>, Double>(); 
} 

public Double getQ(int id_state, int id_action) { 
    // get the value of Q for the state of id_state and the action id_action (return 0 if the value is not in the hashtable) 
    Tuple<Integer,Integer> t = new Tuple<Integer,Integer> (id_state, id_action); // we creatte a new integer object Tubple with the value of id_state and id_action 
    Double v = q.get(t); 
    if(v != null) return v; 
    else return 0.0; 
} 

// get the argmax of a list 
public int argmax(double[] list) { 
    int arg=-1; 
    double max= 0; 
    for (int i = 0; i<list.length; i++){ 
     if (list[i]>max){ 
      max = list[i]; 
      arg = i; 
     } 
    } 
    return arg; 
} 

// get all the argmax if the argmax has several iterations 
public ArrayList<Integer> arg_allmax(double[] list) { 
    ArrayList<Integer> args = new ArrayList<Integer>(); 
    int a = argmax(list); 
    for (int i = 0; i< list.length; i++){ 
     if (list[i] == list[a]){ 
      args.add(i); 
     } 
    } 
    return args; 
} 

// get the max of the list 
public double max(double[] list) { 
    double max_ = -1e20; 
    int a = argmax(list); 
    max_ = list[a]; 
    return max_; 
} 


/* 
* Fonction that updates the hashtable 
*  for the action id_action and the state id_state 
*  if Q(s,a) had an old value, we allocate it the new value+ alpha(value - old_value) 
*  if Q(s,a) had not an old value : we allocate reward 
*/ 
public void learnQ(int id_state, int id_action, double reward, double value) { 
    Tuple<Integer,Integer> t = new Tuple<Integer,Integer>(id_state,id_action); 
    Double oldv = q.get(t); 

    if(oldv == null) { 

     q.put(t, reward); 
    } else { 

     q.put(t, oldv+alpha*(value-oldv)); 
    } 
} 

/* 
* Here is the Epsilon Greedy strategy 
*  with proba epsilon :we choose a random action 
*  avec proba 1-eps : we choose the most favorable action in fonction of Q(s,a) 
*/ 
public int chooseAction(int id_state) { 
    int action = -1; 
    if(Math.random() < epsilon) { 

     int i = (int)(Math.random()*actions.length); 
     action = actions[i]; 

    } else { 
     double[] tab = new double[actions.length]; 
     ArrayList<Integer> argmaxarray = new ArrayList<Integer>(); 
     for (int i=0; i>actions.length; i++){ 
      tab[i]=actions[i]; 
     } 
     argmaxarray=arg_allmax(tab); 
     int i=(int)(Math.random()*argmaxarray.size()); 
     action=argmaxarray.get(i); 

    } 

    return action; 
} 


/* 
* Learning after the occurence of a move 
*  1) get the most profitable potential action from Q(s',a) 
*  2) call learnQ 
*/ 
public void learn(int id_state1, int id_action1, double reward, int id_state2) { 
    int futureAction = 0; 
    futureAction = chooseAction(id_state2); 
    double maxqnew = 0; // REMPLIR 
    maxqnew = getQ(futureAction, id_state2); 


    learnQ(id_state1, id_action1, reward, reward + gamma*maxqnew); 

} 

// Affiche Q(s,a) 
private void printQvalue(int id_state) { 
    for(int action : actions) { 
     Tuple<Integer,Integer> t = new Tuple<Integer,Integer>(id_state,action); 
     Double v = q.get(t); 
     System.out.print(v+" "); 
    } 
    System.out.println(); 
} 

这里是日食告诉我:

Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: -1 
    at rl.Qlearn.arg_allmax(Qlearn.java:54) 
    at rl.Qlearn.chooseAction(Qlearn.java:108) 
    at rl.Qlearn.learn(Qlearn.java:138) 

我认为它是在使用all_argmax函数的chooseAction方法的其他地方出现的,但我无法找到确切的错误!

下面是两种参与方式(所以它更便于你阅读):

all_argmax:

public ArrayList<Integer> arg_allmax(double[] list) { 
    ArrayList<Integer> args = new ArrayList<Integer>(); 
    int a = argmax(list); 
    for (int i = 0; i< list.length; i++){ 
     if (list[i] == list[a]){ 
      args.add(i); 
     } 
    } 
    return args; 
} 

chooseAction:

public int chooseAction(int id_state) { 
    int action = -1; 
    if(Math.random() < epsilon) { 

     int i = (int)(Math.random()*actions.length); 
     action = actions[i]; 

    } else { 
     double[] tab = new double[actions.length]; 
     ArrayList<Integer> argmaxarray = new ArrayList<Integer>(); 
     for (int i=0; i>actions.length; i++){ 
      tab[i]=actions[i]; 
     } 
     argmaxarray=arg_allmax(tab); 
     int i=(int)(Math.random()*argmaxarray.size()); 
     action=argmaxarray.get(i); 

    } 

    return action; 
} 
+1

如果您希望:a)将所有评论翻译为英文; b)格式化您的代码; c)遵循示例代码中的Java命名约定; d)将问题简化为[mcve](既最小也最完整,目前都不是这种情况)。 –

+1

我现在已经删除了“堆栈溢出的第一篇文章,感谢您阅读我的小问题。我在代码中遇到了一个问题,我无法解决”部分两次。这与问题无关 - 更糟糕的是,因为它在问题的开始处,这就是主要问题页面上显示的内容。 –

+0

好的Jon Skeet我会尽力去做你问我的,对不起,如果我组织我的文章的方式很笨拙。 'arg_allmax()'中的 – drheinrich940

回答

2

IndexOutOfBoundsException发生,因为你的argmax([])方法,要么是因为数组是空的,要么是因为列表中的所有双精度都是负数。

在任一这些情况下,int arg = -1变量从未被设置为另一个值比-1,这显然是列于自-1任何场景边界的不是一个有效的阵列位置。

最好的方法是在将数组传递到argmax之前检查数组是否为空,或者在执行任何操作之前检查返回值是否有效(不是-1)。并且还将double max = 0更改为double max = Double.NEGATIVE_INFINITY

+1

Double.MIN_VALUE'会导致意外的行为(请参阅http://stackoverflow.com/问题/ 3884793/why-is-double-min-value-in-not-negative),我会在这个用例中使用'Double.NEGATIVE_INFINITY'。 –

+1

@ d.j.brown巧合的是,我刚刚在评论前阅读了同样的答案。良好的反馈tho,我已经更新了我的回答 – Gelunox

+0

@Gelunox谢谢你,我只是改变了双倍最大值,因为你显示并添加了一点allert消息,以防空列表和事情现在再次工作! – drheinrich940

相关问题