2016-11-12 157 views
3

我是golang和编程的新手。Golang段落错误(核心转储)

我写了一个小程序,将匹配正则表达式的文件从一个目录移动到另一个目录。

该程序成功运行在Ubuntu 16.04和一个CentOS 6.8(决赛)

在一定的Centos机器(我不知道一个确切的版本。我不知道这是6?和它是低于6.8),我得到:

分割故障(核心转储)

我的研究表明,当OS不允许我访问内存发生此错误。

有人可以告诉我在我的代码中哪里出了问题。如果您看到任何问题,请指出不良做法。

package main 

import (
    "flag" 
    "fmt" 
    "log" 
    "os" 
    "regexp" 
    "strings" 
) 

func main() { 

    batch := flag.Int("batch", 0, "the amount of files to be processed") 
    pattern := flag.String("pattern", "", "string pattern to be matched") 
    dir := flag.Int("dir", 0, "key from strings.Split(pattern, '')") 
    confirm := flag.String("move", "no", "flags if program should move files") 

    flag.Parse() 

    d, err := os.Open(".") 
    if err != nil { 
     log.Fatal("Could not open directory. ", err) 
    } 

    files, err := d.Readdir(*batch) 
    if err != nil { 
     log.Fatal("Could not read directory. ", err) 
    } 

    for _, file := range files { 
     fname := file.Name() 
     match, err := regexp.Match(*pattern, []byte(fname)) 
     if err != nil { 
      log.Fatal(err) 
     } 
     if match == true { 

      s := strings.Split(fname, "_") 
      dest := s[*dir] 

      switch *confirm { 
      case "no": 
       fmt.Printf(" %s matches %s\n Dir name = %s\n -----------------------\n", fname, *pattern, dest) 

      case "yes": 
       //all directories are expected to be a number. 
       //terminate execution if directory doesn't match regex 
       if match, err := regexp.Match("[0-9]", []byte(dest)); match == false { 
        log.Fatalf("Expected directory name does not match prepared directory.\n Expected dir name must be a number (regex [0-9]) | Current dir name is: %s\n", dest) 
        if err != nil { 
         log.Fatal(err) 
        } 
       } 

       //check if direcotry exists. create it if it doesn't 
       if _, err := os.Stat(dest); os.IsNotExist(err) { 
        err = os.Mkdir(dest, 0777) 
        if err != nil { 
         log.Fatal("Could not create directory. ", err) 
        } 
       } 
       err = os.Rename(fname, fmt.Sprintf("%s/%s", dest, fname)) 
       if err != nil { 
        log.Fatal("Could not move file. ", err) 
       } 
       fmt.Printf("Moved %s to %s\n", fname, dest) 
      } 
     } 
    } 
    fmt.Println("Exit") 
} 
+0

有一个[类似的情况](https://github.com/mhausenblas/cinf/issues/1),从来没有弄清楚它是什么。一个假设是交叉编译是根本原因(因为我建立在MacOS上)。 –

+1

请使用选项-ldflags“-w”编译程序(例如,编译-ldflags“-w”prog.go)并尝试将其解压缩到gdb(gdb prog)中并运行它(运行)。如果问题出现,请在此时向我们回溯(bt)。 – lofcek

+0

我在有问题的机器上构建了程序,现在它工作。 – user3017869

回答

0

我的第一个猜测是,你正在超速运转的 'S' 数组的边界:

dest := s[*dir] 

我加了一些安全检查(见[新增]):

package main 

import (
    "flag" 
    "fmt" 
    "log" 
    "os" 
    "regexp" 
    "strings" 
) 

func main() { 
    batch := flag.Int("batch", 0, "the amount of files to be processed") 
    pattern := flag.String("pattern", "", "string pattern to be matched") 
    dir := flag.Int("dir", 0, "key from strings.Split(pattern, '')") 
    confirm := flag.String("move", "no", "flags if program should move files") 

    flag.Parse() 

    d, err := os.Open(".") 
    if err != nil { 
     log.Fatal("Could not open directory. ", err) 
    } 
    defer d.Close() // [Added] probably not needed if a directory but doesn't hurt 

    files, err := d.Readdir(*batch) 
    if err != nil { 
     log.Fatal("Could not read directory. ", err) 
    } 

    for _, file := range files { 
     fname := file.Name() 
     match, err := regexp.Match(*pattern, []byte(fname)) 
     if err != nil { 
      log.Fatal(err) 
     } 
     if match == true { 
      s := strings.Split(fname, "_") 

      // [Added] Sanity check *dir index before using 
      if *dir >= len(s) { 
       log.Fatalf("dir is out of range: dir=%d len(s)=%d\n", *dir, len(s)) 
      } 

      dest := s[*dir] 

      switch *confirm { 
      case "no": 
       fmt.Printf(" %s matches %s\n Dir name = %s\n -----------------------\n", fname, *pattern, dest) 

      case "yes": 
       //all directories are expected to be a number. 
       //terminate execution if directory doesn't match regex 
       if match, err := regexp.Match("[0-9]", []byte(dest)); match == false { 
        log.Fatalf("Expected directory name does not match prepared directory.\n Expected dir name must be a number (regex [0-9]) | Current dir name is: %s\n", dest) 
        if err != nil { 
         log.Fatal(err) 
        } 
       } 

       //check if direcotry exists. create it if it doesn't 
       if _, err := os.Stat(dest); os.IsNotExist(err) { 
        err = os.Mkdir(dest, 0777) 
        if err != nil { 
         log.Fatal("Could not create directory. ", err) 
        } 
       } 
       err = os.Rename(fname, fmt.Sprintf("%s/%s", dest, fname)) 
       if err != nil { 
        log.Fatal("Could not move file. ", err) 
       } 
       fmt.Printf("Moved %s to %s\n", fname, dest) 

       // [Added]: Make sure to handle non 'yes/no' answers 
      default: 
       log.Fatalf("confirm is invalid '%s'\n", *confirm) 
      } 
     } 
    } 
    fmt.Println("Exit") 
} 

不知道你输入的程序是什么,但没有别的我能看到会导致分段错误。