使用存储过程在数据库中插入列表记录

Question

我有使用存储过程插入SQL Server数据库的记录列表。目前我正在这样做，但有没有更好的办法？

我在应用程序的高峰时段插入100-200行/秒。该存储过程只得到了价值和插入新行，你可以做

public void InsertRecords(List<stRecord> records) 
    { 
     foreach (var item in records) 
     { 
      if (CheckforDuplicateRecord(item) == false) 
      { 
       using (con = new SqlConnection(connectionString)) 
       { 
        con.Open(); 

        SqlCommand cmd = new SqlCommand(StoredProcedures.Service_Insert_record.ToString(), con); 
        cmd.CommandType = CommandType.StoredProcedure; 

        cmd.Parameters.Add("@item1", SqlDbType.NChar); 
        cmd.Parameters.Add("@item2", SqlDbType.NChar); 

        cmd.Parameters[0].Value = item.localUsername; 
        cmd.Parameters[1].Value = item.BetfairUsername; 


        try 
        { 
         cmd.ExecuteNonQuery(); 
        } 
        catch (Exception exp) 
        { 
         throw exp; 
        } 
       } 
      } 
     } 
    } 

Answer 1

这正是表值参数的用途 - 您可以一次性传递列表。

在SQL Server：

CREATE TYPE dbo.Usernames AS TABLE 
(
    localUsername NVARCHAR(32), 
    BetfairUsername NVARCHAR(32) 
); 
GO 

CREATE PROCEDURE dbo.Service_Insert_MultipleRows 
    @u AS dbo.Usernames READONLY 
AS 
BEGIN 
    SET NOCOUNT ON; 

    INSERT INTO dbo.DestinationTable(localUsername, BetfairUsername) 
    SELECT localUsername, BetfairUsername FROM @u; 
END 
GO 

现在，在C＃：

DataTable tvp = new DataTable(); 
tvp.Columns.Add(new DataColumn("localUsername")); 
tvp.Columns.Add(new DataColumn("BetfairUsername")); 

foreach(var item in records) 
{ 
    tvp.Rows.Add(item.localUsername, item.BetfairUsername); 
} 

using (con) 
{ 
    SqlCommand cmd = new SqlCommand("Service_Insert_MultipleRows", con); 
    cmd.CommandType = CommandType.StoredProcedure; 
    SqlParameter tvparam = cmd.Parameters.AddWithValue("@u", tvp); 
    tvparam.SqlDbType = SqlDbType.Structured; 
    con.Open(); 
    cmd.ExecuteNonQuery(); 
} 

Answer 2

一个显而易见的事情：创建SqlCommand只一次在方法的开始 - 没有任何意义了一遍又一遍又一遍创造它再次！

public void InsertRecords(List<stRecord> records) 
{ 
    using (con = new SqlConnection(connectionString)) 
    using (SqlCommand cmd = new SqlCommand(StoredProcedures.Service_Insert_record.ToString(), con)) 
    { 
     cmd.CommandType = CommandType.StoredProcedure; 

     // are those paramters *REALLY* just 1 character long?? 
     // that's what you have now, with the way you define it! 
     cmd.Parameters.Add("@item1", SqlDbType.NChar); 
     cmd.Parameters.Add("@item2", SqlDbType.NChar); 

     // otherwise, you need to define the LENGTH of the NCHAR parameter! 
     // cmd.Parameters.Add("@item2", SqlDbType.NChar, 15); 

     foreach (var item in records) 
     { 
      if (CheckforDuplicateRecord(item) == false) 
      { 
       cmd.Parameters["@item1"].Value = item.localUsername; 
       cmd.Parameters["@item2"].Value = item.BetfairUsername; 

       try 
       { 
       con.Open(); 
       cmd.ExecuteNonQuery(); 
       con.Close(); 
       } 
       catch (Exception exp) 
       { 
       throw; 
       } 
      } 
     } 
    }