重写多个if语句

Question

我觉得这是一堆你明白我的意思。它的工作原理，但我觉得我在页面生命周期（加载和回发）方面超越了这一点，甚至在我的每个if语句中都有冗余。

什么情况是这样的：

1. 这种方法被称为上非常 页面加载（无论任何回发或 ）
2. 如果用户提交 形式，它减少了他们totalPoints（有一个这些单选按钮下面的按钮，允许他们提交和声明积分）。

所以我把这种方法也从他们的总周边的下一次下降 这些点之后的 用户索赔点（的提交）。所以 基于其 帐户的总积分上，我需要启用/禁用这些 单选按钮的页面从上次刷新后提交

private void SetPointsOptions() 
{ 
    int totalPoints = customer.TotalPoints; 

    rbn200Points.Text = "200 pts"; 
    rbn250Points.Text = "250 pts"; 
    rbn400Points.Text = "400 pts"; 
    rbn500Points.Text = "500 pts"; 
    rbn600Points.Text = "600 pts"; 

    // clear state of radio buttons & disable submit 
    if (totalPoints < 200) 
    { 
     rbn200Points.Enabled = false; 
     rbn250Points.Enabled = false; 
     rbn400Points.Enabled = false; 
     rbn500Points.Enabled = false; 
     rbn600Points.Enabled = false; 

     rbn200Points.Checked = false; 
     rbn250Points.Checked = false; 
     rbn400Points.Checked = false; 
     rbn500Points.Checked = false; 
     rbn600Points.Checked = false; 

     btnClaimRewardPoints.Enabled = false; 
     return; 
    } 

    if(totalPoints >= 200 && totalPoints < 250) 
    { 
     rbn200Points.Enabled = true; 
    } 
    else if(totalPoints >= 250 && totalPoints < 400) 
    { 
     rbn200Points.Enabled = true; 
     rbn250Points.Enabled = true; 
    } 
    else if(totalPoints >= 400 && totalPoints < 500) 
    { 
     rbn200Points.Enabled = true; 
     rbn250Points.Enabled = true; 
     rbn400Points.Enabled = true; 
    } 
    else if(totalPoints >= 500 && totalPoints < 600) 
    { 
     rbn200Points.Enabled = true; 
     rbn250Points.Enabled = true; 
     rbn400Points.Enabled = true; 
     rbn500Points.Enabled = true; 
    } 
    else if(totalPoints >= 600) 
    { 
     rbn200Points.Enabled = true; 
     rbn250Points.Enabled = true; 
     rbn400Points.Enabled = true; 
     rbn500Points.Enabled = true; 
     rbn600Points.Enabled = true; 
    } 
} 

Answer 1

由于我没有错过任何重要的在你的代码：

private void SetPointsOptions() 
{ 
    int totalPoints = customer.TotalPoints; 
    rbn200Points.Enabled = totalPoints >= 200; 
    rbn250Points.Enabled = totalPoints >= 250; 
    rbn400Points.Enabled = totalPoints >= 400; 
    rbn500Points.Enabled = totalPoints >= 500; 
    rbn600Points.Enabled = totalPoints >= 600; 
} 

Answer 2

那么，你可以用别的，如果不检查启动，并使用

if (totalpoints >= val) control.enable 

其中W生病让你少但却难免重复使

Answer 3

您可以在C＃如下分配多个属性：

if (some condition) 
{ 
    rbnA.Enabled = rbnB.Enabled = rbnC.Enabled = rbnD.Enabled = true; 
} else { 
    rbnA.Enabled = rbnB.Enabled = rbnC.Enabled = rbnD.Enabled = false; 
} 

Answer 4

我不能怎样/如果/当你要启动一切，但有一定的冗长发言说可以减少。例如，您启用各种按钮的最后一位可以简化为：

if(totalPoints > 200) 
{ 
    rbn200Points.Enabled = true; 
} 
if(totalPoints > 250) 
{ 
    rbn250Points.Enabled = true; 
} 
if(totalPoints > 400) 
{ 
    rbn400Points.Enabled = true; 
} 
if(totalPoints > 500) 
{ 
    rbn500Points.Enabled = true; 
} 
if(totalPoints > 600) 
{ 
    rbn600Points.Enabled = true; 
} 

Answer 5

OMG，伙计。这是一个疯狂的代码重复量。

我还没有碰过C＃一段时间，手头没有VS，但它应该像这样。

var points2buttons = new Dictionary<int, RadioButton>(); 
points2buttons[200] = rbn200Points; 
points2buttons[250] = rbn250Points; 
... 
foreach (var pointsButton in points2buttons) { 
    var button = pointsButton.Value; 
    var pts = pointsButton.Key; 
    button.Text = pts + " pts"; 
    button.Checked = totalPoints>pts; 
} 
... 

使用反射，你甚至可以自动填充字典。

Answer 6

投入字典单选按钮和它们相关联的点值可以帮助：

// Untested. 

int totalPoints = customer.TotalRewardPoints; 

var radioButtons = new Dictionary<RadioButton, Int32>(); 
radioButtons.Add(rbn200Points, 200); 
radioButtons.Add(rbn250Points, 250); 
radioButtons.Add(rbn400Points, 400); 
radioButtons.Add(rbn500Points, 500); 
radioButtons.Add(rbn600Points, 600); 

foreach (var keyValuePair in radioButtons) 
{ 
    keyValuePair.Key.Text = String.Format("{0} pts", keyValuePair.Value); 
    keyValuePair.Key.Enabled = (keyValuePair.Value < totalPoints); 
    keyValuePair.Key.Checked = false; 
}