2011-01-05 51 views
9

我们希望将我们的项目从ASP.NET MVC 2升级到3.我们的大多数测试都成功了,但有一些失败,在ValueProviderFactories.Factories.GetValueProvider(context)如何在ASP.NET MVC3中测试ValueProviderFactories?

下面是一个简单的测试类,用于说明问题。

[TestFixture] 
public class FailingTest 
{ 
    [Test] 
    public void Test() 
    { 
    var type = typeof(string); 
    // any controller 
    AuthenticationController c = new AuthenticationController(); 
    var httpContext = new Mock<HttpContextBase>(); 
    var context = c.ControllerContext = new ControllerContext(httpContext.Object, new RouteData(), c); 

    IModelBinder converter = ModelBinders.Binders.GetBinder(type); 
    var bc = new ModelBindingContext 
    { 
     ModelName = "testparam", 
     ModelMetadata = ModelMetadataProviders.Current.GetMetadataForType(null, type), 
     ValueProvider = ValueProviderFactories.Factories.GetValueProvider(context) 
    }; 
    Console.WriteLine(converter.BindModel(context, bc)); 
    } 
} 

异常“对象引用未设置为对象的实例”。在调用ValueProviderFactories.Factories.GetValueProvider(context)时抛出。堆栈跟踪看起来是这样的:

Microsoft.Web.Infrastructure.dll!Microsoft.Web.Infrastructure.DynamicValidationHelper.ValidationUtility.CollectionReplacer.GetUnvalidatedCollections(System.Web.HttpContext context) + 0x23 bytes 
Microsoft.Web.Infrastructure.dll!Microsoft.Web.Infrastructure.DynamicValidationHelper.ValidationUtility.GetUnvalidatedCollections(System.Web.HttpContext context, out System.Collections.Specialized.NameValueCollection form, out System.Collections.Specialized.NameValueCollection queryString, out System.Collections.Specialized.NameValueCollection headers, out System.Web.HttpCookieCollection cookies) + 0xbe bytes  
System.Web.WebPages.dll!System.Web.Helpers.Validation.Unvalidated(System.Web.HttpRequest request) + 0x73 bytes 
System.Web.WebPages.dll!System.Web.Helpers.Validation.Unvalidated(System.Web.HttpRequestBase request) + 0x25 bytes 
System.Web.Mvc.DLL!System.Web.Mvc.FormValueProviderFactory..ctor.AnonymousMethod__0(System.Web.Mvc.ControllerContext cc) + 0x5a bytes 
System.Web.Mvc.DLL!System.Web.Mvc.FormValueProviderFactory.GetValueProvider(System.Web.Mvc.ControllerContext controllerContext) + 0xa0 bytes  
System.Web.Mvc.DLL!System.Web.Mvc.ValueProviderFactoryCollection.GetValueProvider.AnonymousMethod__7(System.Web.Mvc.ValueProviderFactory factory) + 0x4a bytes 
System.Core.dll!System.Linq.Enumerable.WhereSelectEnumerableIterator<System.Web.Mvc.ValueProviderFactory,<>f__AnonymousType2<System.Web.Mvc.ValueProviderFactory,System.Web.Mvc.IValueProvider>>.MoveNext() + 0x24d bytes 
System.Core.dll!System.Linq.Enumerable.WhereSelectEnumerableIterator<<>f__AnonymousType2<System.Web.Mvc.ValueProviderFactory,System.Web.Mvc.IValueProvider>,System.Web.Mvc.IValueProvider>.MoveNext() + 0x2ba bytes 
mscorlib.dll!System.Collections.Generic.List<System.Web.Mvc.IValueProvider>.List(System.Collections.Generic.IEnumerable<System.Web.Mvc.IValueProvider> collection) + 0x1d8 bytes  
System.Core.dll!System.Linq.Enumerable.ToList<System.Web.Mvc.IValueProvider>(System.Collections.Generic.IEnumerable<System.Web.Mvc.IValueProvider> source) + 0xb5 bytes 
System.Web.Mvc.DLL!System.Web.Mvc.ValueProviderFactoryCollection.GetValueProvider(System.Web.Mvc.ControllerContext controllerContext) + 0x24d bytes 
test.DLL!FailingTest.Test() Line 31 + 0xf9 bytes C# 

我想知道为什么它会抛出异常,只见原因:

public static ValidationUtility.UnvalidatedCollections GetUnvalidatedCollections(HttpContext context) 
{ 
    return (ValidationUtility.UnvalidatedCollections) context.Items[_unvalidatedCollectionsKey]; 
} 

那么,我们回到过去,当我们依赖于HttpContext.Current?如何解决它?

+0

我有同样的问题。 +1是一个很好的问题。 – 2011-03-17 05:34:10

+0

我有同样的需要,所以谢谢。有一点需要提及,只需设置新的RouteData()仍然可以引发错误。为了解决这个问题,我必须在喂食之前在路由数据中添加一个“控制器”和“动作”键/值。 – uadrive 2011-10-25 21:00:42

回答

8

这可以很容易地通过代理访问HttpContext的ValueProviders来解决,忽略它。

我已经在我的博客文章中解释了所有内容:Unit test actions with ValueProviderFactories in ASP.NET MVC3

的关键是这段代码:

public static class ValueProviderFactoresExtensions { 
    public static ValueProviderFactoryCollection ReplaceWith<TOriginal>(this ValueProviderFactoryCollection factories, Func<ControllerContext, NameValueCollection> sourceAccessor) { 
     var original = factories.FirstOrDefault(x => typeof(TOriginal) == x.GetType()); 
     if (original != null) { 
      var index = factories.IndexOf(original); 
      factories[index] = new TestValueProviderFactory(sourceAccessor); 
     } 
     return factories; 
    } 

    class TestValueProviderFactory : ValueProviderFactory { 
     private readonly Func<ControllerContext, NameValueCollection> sourceAccessor; 


     public TestValueProviderFactory(Func<ControllerContext, NameValueCollection> sourceAccessor) { 
      this.sourceAccessor = sourceAccessor; 
     } 


     public override IValueProvider GetValueProvider(ControllerContext controllerContext) { 
      return new NameValueCollectionValueProvider(sourceAccessor(controllerContext), CultureInfo.CurrentCulture); 
     } 
    }   
} 

因此,它可以作为:

ValueProviderFactories.Factories 
    .ReplaceWith<FormValueProviderFactory>(ctx => ctx.HttpContext.Request.Form) 
    .ReplaceWith<QueryStringValueProviderFactory>(ctx => ctx.HttpContext.Request.QueryString); 

它实际上是很容易的:)

UPDATE:正如在评论中提到你应该记住:

  1. 设置属性为一些非空值,否则JsonValueProviderFactory会抛出异常。我更喜欢在那里创建一个模拟并设置默认值。
  2. 取代HttpFileCollectionValueProviderFactory,因为它可以在绑定过程中使用。
  3. 注意您可能在项目中存在的其他依赖关系。
+1

干得好!注意:您必须将ctx.HttpContext.Request.ContentType属性设置为某个非空值,否则JsonValueProviderFactory将引发异常。 – dkl 2011-03-18 11:57:01

+0

问题解决了,谢谢:) – stej 2011-03-18 12:17:14

+1

我也必须替换'HttpFileCollectionValueProviderFactory'才能使它工作。 – 2011-03-29 11:02:45

0

您不应该在单元测试中调用ValueProviderFactories.Factories,ModelBinders.Binders或任何其他静态访问器。这就是为什么ModelBindingContext.ValueProvider存在的原因 - 这样您就可以提供自己创建的模拟IValueProvider,而不是依赖静态默认值(假定MVC管道正在运行)。

+4

嘲笑'IValueProvider'是一个荒谬的工作量。它需要重新实现几十个ASP.NET MVC功能。它曾经是可测试的,但它现在不是。 – 2011-03-17 05:45:37