2017-02-26 132 views
2

我试图编码将加密/解密邮件的加密和解密方法。加密/解密:HMAC标签在解密方法中不匹配

在加密方法中,它将采用一个字符串。它将读取公钥并用于RSA密码。然后,将使用具有AES密钥和IV的AES密码对消息进行加密。然后,通过使用HMAC密钥,利用密文加密的AES生成HMAC标签。 AES密钥和HMAC密钥连接在一起并通过RSA密码加密。该方法将返回一个JSONObject,其中包含:RSA密文,AES密文,AES IV和HMAC标记。它们是转换为十六进制字符串的字节数组。

在解密方法中,它将采用将被解析的JSON对象。它将读取将在RSA密码中使用的私钥。 RSA密码将用于解密连接的密钥。一旦解密,密钥将被分离为AES密钥和HMAC密钥。然后,将在AES密文上生成新的HMAC标签。比较加密标签和新标签。如果它们相同,则解密AES密文并获得消息。

当我运行我的代码,没有错误,但它不解密,因为2个标签不匹配。我不知道为什么。

公钥和私钥是从.pem文件转换而来的.der文件。

请帮帮我。谢谢!

import java.security.*; 
import java.security.spec.*; 
import javax.crypto.*; 
import java.io.*; 
import java.nio.file.Files; 
import java.nio.file.Paths; 
import javax.crypto.spec.SecretKeySpec; 
import javax.crypto.spec.IvParameterSpec; 
import org.json.*; 
import javax.xml.bind.DatatypeConverter; 

public class CryptographicTools 
{ 
    /** 
    * This method encrypts a message 
    * @param message String message to be encrypted 
    * @return a JSONObject 
    */ 
    public JSONObject encryptMessage(String message) 
    { 
     JSONObject output = new JSONObject(); // instantiate JSONObject 

     try 
     { 
      //read in public key 
      byte[] publicKeyBytes = readKeyFromFile("public.der");//pem convert to der 

      //turn bytes into public key 
      X509EncodedKeySpec publicSpec = new X509EncodedKeySpec(publicKeyBytes); //encodes the bytes 
      KeyFactory keyFactory = KeyFactory.getInstance("RSA"); //make the key a RSA instance 

      //initialize RSA object and public key 
      Cipher RSAObject = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding"); //with OAEP 
      RSAObject.init(Cipher.ENCRYPT_MODE, keyFactory.generatePublic(publicSpec)); //create RSA encryption cipher with a generated public key 

      //generate 256-bit AES key 
      KeyGenerator keyGen = KeyGenerator.getInstance("AES");//generate AES Key 
      keyGen.init(256); //generate a key with 256 bits 
      SecretKey AESKey = keyGen.generateKey(); //generate AES key with 256 bits 

      //Create AES IV 
      SecureRandom randomByteGenerator = new SecureRandom();//secure generator to generate random byes for IV 
      byte[] AESKeyIVArray = new byte[16]; 
      randomByteGenerator.nextBytes(AESKeyIVArray);//get random bytes for iv 
      IvParameterSpec AES_IV = new IvParameterSpec(AESKeyIVArray); //iv object for AES object 

      //initialize AES object 
      Cipher AESObject = Cipher.getInstance("AES/CBC/PKCS5Padding"); 
      AESObject.init(Cipher.ENCRYPT_MODE, AESKey, AES_IV); //tell the AES object to encrypt 

      //encrypt message with AES 
      byte[] AESciphertext = AESObject.doFinal(message.getBytes()); 

      //generate 256-bit HMAC key 
      byte[] SHA256KeyArray = new byte[32];//256 bits 
      randomByteGenerator.nextBytes(SHA256KeyArray);//generate random bits for key 
      SecretKeySpec HMACKeySpec = new SecretKeySpec (SHA256KeyArray,"HmacSHA256"); //make the key 
      Mac HMAC = Mac.getInstance("HmacSHA256"); //initialize HMAC 
      HMAC.init(HMACKeySpec);//put key in cipher 
      byte [] HMACTag = HMAC.doFinal(AESciphertext);//generate HMAC tag 

      //concatenate AES and HMAC keys 
      byte[] AESKeyByte = AESKey.getEncoded();///turn AESKey to byte array 
      byte[] HMACKeySpecByte = HMACKeySpec.getEncoded();///turn HMAXKey to byte array 
      byte[] concatenatedKeys = new byte[AESKeyByte.length + HMACKeySpecByte.length];//new array for concatenated keys 

      //combine keys in new array 
      System.arraycopy(AESKeyByte, 0, concatenatedKeys, 0, AESKeyByte.length); 
      System.arraycopy(HMACKeySpecByte, 0, concatenatedKeys, AESKeyByte.length, HMACKeySpecByte.length); 

      //encrypt keys with RSA object 
      byte[] RSAciphertext = RSAObject.doFinal(concatenatedKeys); 

      //put RSA ciphertext, AES ciphertext, AES_IV and HMAC tag in JSon 
      //save byte[] as Strings in hex 
      output.put("RSAciphertext", DatatypeConverter.printHexBinary(RSAciphertext)); 
      output.put("AESciphertext", DatatypeConverter.printHexBinary(AESciphertext)); 
      output.put("AES_IV", DatatypeConverter.printHexBinary(AES_IV.getIV())); 
      output.put("HMACTag", DatatypeConverter.printHexBinary(HMACTag)); 
     } 
     catch (Exception e) 
     { 
      System.out.println("Error: " + e.toString() +e.getMessage()); //error message 
     } 

     return output; //return as JSON Object 
    } 

    /** 
    * This method decrypts a message 
    * @param jsonObjectEncrypted 
    * @return message as string 
    */ 
    public String decrypt (JSONObject jsonObjectEncrypted) 
    { 
     String message=""; 
     try 
     { 
      //recover RSA ciphertext from JSON 
      String RSACiphertextString=jsonObjectEncrypted.getString("RSAciphertext"); 
      byte[] recoveredRSAciphertext = DatatypeConverter.parseHexBinary(RSACiphertextString); //convert hex string to byte array 

      //recover AES ciphertext from JSON 
      String AESCiphertextString=jsonObjectEncrypted.getString("AESciphertext"); 
      byte[] recoveredAESciphertext = DatatypeConverter.parseHexBinary(AESCiphertextString); //convert hex string to byte array 

      //recover AES IV from JSON 
      String AES_IVString=jsonObjectEncrypted.get("AES_IV").toString(); 
      byte[] recoveredAES_IV = DatatypeConverter.parseHexBinary(AES_IVString); //convert hex string to byte array 
      //recover HMACTag from JSON 
      String HMACTagString=jsonObjectEncrypted.getString("HMACTag"); 
      byte[] recoveredHMACTag = DatatypeConverter.parseHexBinary(HMACTagString); //convert hex string to byte array 

      //read in private key 
      byte[] privateKeyBytes = readKeyFromFile("private.der");//pem convert to der 

      //turn bytes into private key 
      PKCS8EncodedKeySpec privateSpec = new PKCS8EncodedKeySpec(privateKeyBytes); 
      KeyFactory keyFactory = KeyFactory.getInstance("RSA"); 

      //initialize RSA object and private key 
      Cipher RSAObject = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding"); //with OAEP 
      RSAObject.init(Cipher.DECRYPT_MODE, keyFactory.generatePrivate(privateSpec)); //create RSA encryption cipher with a generated private key 

      //Decrypt concatenated keys with RSA object 
      byte[] concatenatedKeys = RSAObject.doFinal(recoveredRSAciphertext); 

      //split the concatenated keys 
      byte[] AESKey = new byte[concatenatedKeys.length/2]; 
      byte[] HMACKey = new byte[concatenatedKeys.length/2]; 
      System.arraycopy(concatenatedKeys, 0,AESKey,0,AESKey.length); //Copy half into AESKey 
      System.arraycopy(concatenatedKeys, AESKey.length,HMACKey,0,HMACKey.length); //Copy Other half into HMACKey 

      //generate HMACTag 
      SecretKeySpec HMACKeySpec = new SecretKeySpec (HMACKey,"HmacSHA256"); //make the key 
      Mac HMAC = Mac.getInstance("HmacSHA256"); 
      HMAC.init(HMACKeySpec);//initialize with HMAC Key 
      byte [] newHMACTag = HMAC.doFinal(recoveredAESciphertext); //generate HMACTag with AES Ciphertext 

      if(recoveredHMACTag.equals(newHMACTag)) //encrypt message if tags are equal 
      { 
       //initialize AES object 
       Cipher AESObject = Cipher.getInstance("AES/CBC/PKCS5Padding"); 
       AESObject.init(Cipher.DECRYPT_MODE, new SecretKeySpec (AESKey,"AES"), new IvParameterSpec(recoveredAES_IV)); //tell the AES object to encrypt 
       message = new String (AESObject.doFinal(recoveredAESciphertext), "US-ASCII");//encrypt AES ciphertext and save as string 

      } 
      else 
      { 
       System.out.println("Message cannot be decrypted."); 
      } 


     } 
     catch (Exception e) 
     { 
      System.out.println("Error: "+e.toString()+": "+e.getMessage()); //error message 
     } 

     return message; //return plaintext 
    } 

    /** 
    * This method reads bytes of a key from a file into a byte array 
    * @param fileName type of key 
    * @return byte array 
    * @throws IOException 
    */ 
    public byte[] readKeyFromFile(String fileName) throws IOException 
    { 
     return Files.readAllBytes(Paths.get(fileName)); 
    } 

} 

回答

4

的Java数组没有实现.equals()你想让它(info)的方式。尝试更换此检查:

recoveredHMACTag.equals(newHMACTag) 

通过这一个:

java.util.Arrays.equals(recoveredHMACTag, newHMACTag) 

我不能说这是所有可能会造成它出问题,但它是我会检查的第一件事。

+2

最好使用如下所示的恒定时间比较函数:http://stackoverflow.com/a/30981412/1816580 –

+1

比较散列值时,常量时间比较是很少需要的,这似乎不是这样的一个案例。我希望在这里看到这种攻击的概念。 – zaph

+0

@zaph如果攻击者知道(或可以猜测),他们可以做一些翻转攻击改变它(错乱与CBC过程中的块)的消息的内容。然后他们使用这条新消息进行定时攻击以获得有效的HMAC。最终的结果是他们有一个被认为有效的伪造消息。棘手的问题,可能不适用于所有情况,但这就是攻击。 (在这种情况下,情况更糟 - IV没有被MAC覆盖,因此攻击者可以随意更改第一个区块的内容)。 – matt