2010-06-14 79 views
7

我分配了一个2d数组,并使用memset用零填充。尽管存在memset,但“使用未初始化的值”

#include<stdio.h> 
#include<string.h> 
#include<stdlib.h> 

void main() { 
    int m=10; 
    int n =10; 
    int **array_2d; 
    array_2d = (int**) malloc(m*sizeof(int*)); 
    if(array_2d==NULL) { 
     printf("\n Could not malloc 2d array \n"); 
     exit(1); 
    } 
    for(int i=0;i<m;i++) { 
     ((array_2d)[i])=malloc(n*sizeof(int)); 
     memset(((array_2d)[i]),0,sizeof(n*sizeof(int))); 
    } 


    for(int i=0; i<10;i++){ 
     for(int j=0; j<10;j++){ 
      printf("(%i,%i)=",i,j); 
      fflush(stdout); 
      printf("%i ", array_2d[i][j]); 
     } 
     printf("\n"); 
    } 
} 

之后我用valgrind [1]检查内存错误。我得到以下错误:行24(printf("%i ", array_2d[i][j]);Conditional jump or move depends on uninitialised value(s)。我一直认为memset是初始化数组的函数。我怎样才能摆脱这个错误?

谢谢!

Valgrind的输出:

==3485== Memcheck, a memory error detector 
==3485== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al. 
==3485== Using Valgrind-3.5.0-Debian and LibVEX; rerun with -h for copyright info 
==3485== Command: ./a.out 
==3485== 
(0,0)=0 (0,1)===3485== Use of uninitialised value of size 4 
==3485== at 0x409E186: _itoa_word (_itoa.c:195) 
==3485== by 0x40A1AD1: vfprintf (vfprintf.c:1613) 
==3485== by 0x40A8FFF: printf (printf.c:35) 
==3485== by 0x8048724: main (playing_with_valgrind.c:39) 
==3485== 
==3485== 
==3485== ---- Attach to debugger ? --- [Return/N/n/Y/y/C/c] ---- 
==3485== Conditional jump or move depends on uninitialised value(s) 
==3485== at 0x409E18E: _itoa_word (_itoa.c:195) 
==3485== by 0x40A1AD1: vfprintf (vfprintf.c:1613) 
==3485== by 0x40A8FFF: printf (printf.c:35) 
==3485== by 0x8048724: main (playing_with_valgrind.c:39) 

[1] valgrind --tool=memcheck --leak-check=yes --show-reachable=yes --num-callers=20 --track-fds=yes --db-attach=yes ./a.out

[GCC-CMD] gcc -std=c99 -lm -Wall -g3 playing_with_valgrind.c

回答

14

在该行:

/* sizeof(n*sizeof(int)) retuns a value of type size_t. 
    This means you are initializing only sizeof(size_t) of the array. */ 
memset(((array_2d)[i]),0,sizeof(n*sizeof(int))); 

它应该是:

memset(((array_2d)[i]),0, n*sizeof(int)); 
+0

确实好眼睛! – 2010-06-14 13:41:03

+0

啊!非常感谢你。我会尽快接受你的回答。 – Framester 2010-06-14 13:41:26

+0

斑点......很难看 – Spudd86 2010-06-15 18:32:45

4

更改声明:

memset(((array_2d)[i]),0,sizeof(n*sizeof(int))); 

到:

memset(((array_2d)[i]),0,n*sizeof(int)); 

你不应该做一个sizeof那里。它只会返回变量类型的大小,这不是你想要的。