当运行Valgrind的的memcheck
工具,我经常收到几十万(或更多,因为Valgrind的在100K切断)的小无效读语句,如:我是否需要担心Valgrind在我的应用程序范围之外报告错误?
==32027== Invalid read of size 1
==32027== at 0x3AB426E26A: _IO_default_xsputn (in /lib64/libc-2.5.so)
==32027== by 0x3AB426CF70: [email protected]@GLIBC_2.2.5 (in /lib64/libc-2.5.so)
==32027== by 0x3AB42621FA: fwrite (in /lib64/libc-2.5.so)
==32027== by 0x4018CA: STARCH_gzip_deflate (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32027== by 0x401F48: compressFileWithGzip (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32027== by 0x4028B5: transformInput (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32027== by 0x402F12: main (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32027== Address 0x7febb9b3c is on thread 1's stack
这些陈述是指函数调用外我的申请(“starch
”)和似乎是libc
的一部分。这是我需要关心的吗?
编辑
如果我修改fwrite
调用删除一个字节,然后我的gzip流被破坏。这里是原代码:
int STARCH_gzip_deflate(FILE *source, FILE *dest, int level) {
int ret, flush;
unsigned have;
z_stream strm;
unsigned char in[STARCH_Z_CHUNK];
unsigned char out[STARCH_Z_CHUNK];
/* initialize deflate state */
strm.zalloc = Z_NULL;
strm.zfree = Z_NULL;
strm.opaque = Z_NULL;
/* deflateInit2 allows creation of archive with gzip header, i.e. a gzip file */
/* cf. http://www.zlib.net/manual.html */
ret = deflateInit2(&strm, level, Z_DEFLATED, (15+16), 8, Z_DEFAULT_STRATEGY);
if (ret != Z_OK)
return ret;
/* compress until end of file */
do {
strm.avail_in = fread(in, 1, STARCH_Z_CHUNK, source);
if (ferror(source)) {
(void)deflateEnd(&strm);
return Z_ERRNO;
}
flush = feof(source) ? Z_FINISH : Z_NO_FLUSH;
strm.next_in = in;
do {
strm.avail_out = STARCH_Z_CHUNK;
strm.next_out = out;
ret = deflate(&strm, flush);
assert(ret != Z_STREAM_ERROR);
have = STARCH_Z_CHUNK - strm.avail_out;
/* invalid read happens here */
if (fwrite(out, 1, have, dest) != have || ferror(dest)) {
(void)deflateEnd(&strm);
return Z_ERRNO;
}
} while (strm.avail_out == 0);
assert(strm.avail_in == 0);
} while (flush != Z_FINISH);
assert(ret == Z_STREAM_END);
/* clean up and return */
(void)deflateEnd(&strm);
return Z_OK;
}
EDIT 2
我想我看到的问题。我有in[STARCH_Z_CHUNK]
而不是in[STARCH_Z_CHUNK + 1]
(同样对于out[]
)。如果我通过-1
同时调整fread
和fwrite
声明,我似乎并没有得到那些Invalid read of size 1
陈述,尽管我仍然看到了大量的Invalid read of size 4
和8
所特有的zlib
:
==32624== Invalid read of size 4
==32624== at 0x3AB5206455: deflateInit2_ (in /usr/lib64/libz.so.1.2.3)
==32624== by 0x40180E: STARCH_gzip_deflate (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32624== by 0x401F48: compressFileWithGzip (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32624== by 0x402C03: transformInput (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32624== by 0x402F12: main (in /home/areynolds/trunk/utility/applications/bed/starch/bin/starch)
==32624== Address 0x7feafde38 is on thread 1's stack
编辑3
我正在用-g
重新编译,如前所述,它将行号与错误关联起来。
但我只是在做argv[]
的strncpy
一个简单的变量,例如:
strncpy(uniqTag, argv[2], strlen(argv[2]) + 1);
这应在空值终止字符串argv[2]
复制到uniqTag
,但仍valgrind
标志着这是一个错误。
EDIT 4
这里的错误消息:
==3682== Invalid read of size 1
==3682== at 0x4A081C1: strncpy (mc_replace_strmem.c:329)
==3682== by 0x4022F1: parseCommandLineInputs (starch.c:589)
==3682== by 0x402F20: main (starch.c:46)
==3682== Address 0x7fedffe11 is on thread 1's stac
下面是两个相关线; Valgrind是说,第二行是无效读:
uniqTag = (char *)malloc(strlen(argv[2]) + 1);
strncpy(uniqTag, argv[2], strlen(argv[2]) + 1);
因为strlen(argv[2]) + 1 > strlen(argv[2])
,这将导致一个空值终止uniqTag
。
其实它可能是你的缓冲区,需要得到大一点,而不是fwrite(),需要克制自己... – thkala 2010-11-16 22:09:27
尝试增加缓冲区的大小1,看看会发生什么 – thkala 2010-11-16 22:19:18
顺便说一句,你是用调试符号编译你的代码?如果在编译器选项中使用-g(假设你使用gcc),valgrind会发出更精确和有用的消息。 – thkala 2010-11-16 22:21:01