c＃测试异步任务 - 测试用例忽略等待 - NullReferenceException

Question

我正在使用NUnit，应该和实体框架内存SQLite数据库进行集成测试，并卡住了我的两个测试用例不执行任何数据库调用， （不等待执行）。

控制器：

[HttpPost("DeleteOrganisations")] 
public async Task<IActionResult> DeleteOrganisations([FromBody] DeleteOrganisationsModel model) 
{ 
    //Test case 2 fails here 
    if (model == null || !ModelState.IsValid) 
    { 
     return Ok(new GenericResultModel(_localizer["An_unexpected_error_has_occurred_Please_try_again"])); 
    } 

    List<OrganisationModel> organisations = (await _organisationService.GetOrganisations(model.OrganisationIds)).ToList(); 

    //Test case 3 fails here 
    if (organisations == null || organisations.Count == 0) 
    { 
     return Ok(new GenericResultModel(_localizer["Could_not_find_organisations"])); 
    } 

    StatusModel status = await _statusService.GetStatus(StatusTypeEnum.StatusType.Organisation, StatusEnum.Status.Removed); 

    if (status == null) 
    { 
     return Ok(new GenericResultModel(_localizer["Could_not_find_status"])); 
    } 

    foreach (OrganisationModel organisation in organisations) 
    { 
     organisation.StatusId = status.Id; 
    } 

    List<OrganisationModel> updatedOrganisations = (await _organisationService.UpdateOrganisations(organisations)).ToList(); 

    if (updatedOrganisations == null || updatedOrganisations.Count == 0) 
    { 
     return Ok(new GenericResultModel(_localizer["Could_not_remove_organisations"])); 
    } 

    if (updatedOrganisations.Count == 1) 
    { 
     return Ok(new GenericResultModel { Id = updatedOrganisations[0].Id }); 
    } 

    return Ok(new GenericResultModel { Count = updatedOrganisations.Count }); 
} 

测试：

[TestFixture] 
public class DeleteOrganisations : TestBase 
{ 
    private OrganisationController _organisationController; 

    [OneTimeSetUp] 
    public void OneTimeSetUp() 
    { 
     //Controller 
     _organisationController = new OrganisationController(null, Mapper, OrganisationService, StatusService, AuthenticationService); 

     //Object Mother 
     ObjectMother.InsertTestData(); 
    } 

    public static IEnumerable TestCases 
    { 
     get 
     { 
      yield return new TestCaseData(new DeleteOrganisationsModel { OrganisationIds = new List<int>() { 1 } }, 0, 1).SetName("DeleteOrganisations_Should_Delete_Data_When_OrganisationId_Exist"); 

      yield return new TestCaseData(new DeleteOrganisationsModel { OrganisationIds = null }, 0, 0).SetName("DeleteOrganisations_Should_Not_Delete_Data_When_Null"); 
      yield return new TestCaseData(new DeleteOrganisationsModel { OrganisationIds = new List<int>() { 2 } }, 0, 0).SetName("DeleteOrganisations_Should_Not_Delete_Data_When_OrganisationId_Not_Exist"); 
     } 
    } 

    [Test, TestCaseSource(nameof(TestCases))] 
    public async Task Test(DeleteOrganisationsModel model, int removedOrganisationCountBefore, int removedOrganisationCountAfter) 
    { 
     //Before 
     int resultBefore = Database.Organisation.Include(o => o.Status).Count(o => o.Status.Name == StatusEnum.Status.Removed.ToString()); 

     resultBefore.ShouldBe(removedOrganisationCountBefore); 

     //Delete 
     await _organisationController.DeleteOrganisations(model); 

     //After 
     int resultAfter = Database.Organisation.Include(o => o.Status).Count(o => o.Status.Name == StatusEnum.Status.Removed.ToString()); 

     resultAfter.ShouldBe(removedOrganisationCountAfter); 
    } 
} 

测试用例1名经过因为

StatusModel status = await _statusService.GetStatus(StatusTypeEnum.StatusType.Organisation, StatusEnum.Status.Removed); 

被称为并且结果被期待已久的。

测试用例2和3失败，因为函数中没有等待（if语句）。

消息：System.NullReferenceException：对象引用未设置为 对象的实例。

我也许可以创建另一个测试为不执行任何等待语句，并跳过了新的测试功能异步任务的结果，但我会得到的消息说：

因为这呼叫未被等待，在呼叫完成之前继续执行当前方法 。考虑将“await” 运算符应用于调用的结果。

该测试可能会通过，但我不喜欢两个测试加上语法错误的想法。

你会怎么做？

编辑

例外：

Message: System.NullReferenceException : Object reference not set to an instance of an object. 

堆栈跟踪：

Test Name: DeleteOrganisations_Should_Not_Delete_Data_When_OrganisationId_Not_Exist 
Test FullName: MyProject.Test.Api.Administration.Organisation.DeleteOrganisations.DeleteOrganisations_Should_Not_Delete_Data_When_OrganisationId_Not_Exist 
Test Source: C:\Users\User\Documents\Visual Studio 2017\Projects\MyProject\MyProject.Test\Api\Administration\Organisation\DeleteOrganisations.cs : line 42 
Test Outcome: Failed 
Test Duration: 0:00:02.48 

Result StackTrace: at MyProject.Api.Controllers.Administration.OrganisationController.<DeleteOrganisations>d__8.MoveNext() in C:\Users\User\Documents\Visual Studio 2017\Projects\MyProject\MyProject.Api\Controllers\Administration\OrganisationController.cs:line 114 
--- End of stack trace from previous location where exception was thrown --- 
    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() 
    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 
    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() 
    at MyProject.Test.Api.Administration.Organisation.DeleteOrganisations.<Test>d__4.MoveNext() in C:\Users\User\Documents\Visual Studio 2017\Projects\MyProject\MyProjectTest\Api\Administration\Organisation\DeleteOrganisations.cs:line 49 
--- End of stack trace from previous location where exception was thrown --- 
    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() 
    at NUnit.Framework.Internal.AsyncInvocationRegion.AsyncTaskInvocationRegion.WaitForPendingOperationsToComplete(Object invocationResult) 
    at NUnit.Framework.Internal.Commands.TestMethodCommand.RunAsyncTestMethod(TestExecutionContext context) 
Result Message: System.NullReferenceException : Object reference not set to an instance of an object. 

Answer 1

捂脸 - 我忘了注入的testbase定位器类。对不起我的坏人。

这条线就在这里：

if (organisations == null || organisations.Count == 0) 
{ 
    return Ok(new GenericResultModel(_localizer["Could_not_find_organisations"])); 
}