2015-10-15 84 views
0

这段代码产生它下面的堆栈跟踪:的RangeError:超过(巴贝尔Ramda)最大调用堆栈大小

import R from 'ramda'; 

function quicksort(list) { 
    if (R.isEmpty(list)) return list; 
    let pivot = R.head(list); 
    let lesser = R.filter(e => e < pivot , list); 
    let greater = R.filter(e => e >= pivot, list); 
    return R.concat(quicksort(lesser), pivot, quicksort(greater)); 
} 

var sorted = quicksort([2,3,1]); 
console.log(sorted); 

堆栈跟踪:

$ babel-node quicksort2015.js 
/Users/ivan/.nvm/versions/node/v4.1.2/lib/node_modules/babel/node_modules/babel-core/node_modules/core-js/modules/es6.object.to-string.js:3 
var classof = require('./$.classof') 
        ^
RangeError: Maximum call stack size exceeded 
at Array.toString (native) 
at module.exports  
(/Users/ivan/.nvm/versions/node/v4.1.2/lib/node_modules/babel/node_modules/babel-core/node_modules/core-js/modules/$.cof.js:4:19) 
at module.exports  
(/Users/ivan/.nvm/versions/node/v4.1.2/lib/node_modules/babel/node_modules/babel-core/node_modules/core-js/modules/$.classof.js:13:13) 
at Array.toString (/Users/ivan/.nvm/versions/node/v4.1.2/lib/node_modules/babel/node_modules/babel-core/node_modules/core-js/modules/es6.object.to-string.js:8:25) 
at type (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:3345:100) 
at f1 (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:166:27) 
at _equals (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:4038:13) 
at equals (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:4664:16) 
at f2 (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:201:24) 
at Object.isEmpty (/Users/ivan/dev/quicksort/node_modules/ramda/dist/ramda.js:5220:29) 

我虽然是巴贝尔将处理尾调用优化?无论如何,这是一个很短的名单,它不应该那么深,对吗?

+0

感谢Scott下面的最终修正的代码。 http://codepen.io/ivanoats/pen/ojGYxL?editors=001 – Ivan

回答

2

这可能是由于过滤了整个列表,而不是lessergreater的列表的尾部。

例如你可以尝试像以下:

function quicksort(list) { 
    if (list.length <= 1) return list; 
    var x = R.head(list); 
    var xs = R.tail(list); 
    var lesser = R.filter(R.lt(R.__, x), xs); 
    var greater = R.filter(R.gte(R.__, x), xs); 
    return R.concat(quicksort(lesser), R.prepend(x, quicksort(greater))); 
} 

不幸的是这并没有从尾部调用优化要么受益,为quicksort递归调用不是尾部调用位置。

+0

谢谢Scott!好的解决方案 – Ivan

相关问题