2014-10-19 136 views
3

我被分配用我的名字来演示自己创建的strcpy函数。我使用的是CodeBlocks,我遇到的问题是对于我输入的一些随机组合字符,它会在大部分时间复制和打印相同的字符。但是,例如,如果我输入了我的名字Mark,则打印的语句将显示string1 =标记(我的输入),对于string2它将打印utring2 =MarkH▀。直到现在,我还没有意识到它正在打印utring2而不是string2,所以现在我也在想这个。C strcpy复制字符串并添加另一个字符

#include <stdio.h> 
char* mystrcpy(char* s1, char* s2); 

main() 
{ 
    char string1[100], string2[100]; //declaring two strings with buffer sizes of 100 
    gets(string1);     //takes input from user for string1 
    mystrcpy(string2, string1);  //calls string copy function 
    printf("string1 = "); 
    puts(string1);   //prints string1 
    printf("string2 = "); 
    puts(string2);   //prints new string2 which should be the same as string1 
    return 0;   //ends main program 
} 

char* mystrcpy(char* s1, char* s2) 
{ 
    int i=0; //initializes element counter at 0 for first element 
    while(s2[i] != '\0') //loops until null is reached 
    { 
     s1[i] = s2[i];  //copies the i-th element of string1 to the corresponding element of string2 
     i++;   //increments element counter 
    } 
    return s1; 
} 

我的完整输出如下:

Mark 
string1 = Mark 
utring2 = MarkH▀ 

回答

3

当测试s2[i] != '\0'失败,你不进入循环,这意味着你忽略字符串结束'\0'

所以你需要做s1[i]='\0'之后的周期来确保字符串s1的终止。然后你可以返回你复制的字符串。

+1

啊这个解释说清楚了。没有意识到我也必须复制它。第一次用字符串。万分感谢。 – 2014-10-19 00:36:51

2

您需要将0复制过,在返回前做s1[i] = 0

或做

int i=0; //initializes element counter at 0 for first element 
    do 
    { 
     s1[i] = s2[i];  //copies the i-th element of string1 to the corresponding element of string2 
     i++;   //increments element counter 
    } while(s2[i] != '\0') //loops until null is reached 
    return s1; 
相关问题