以php表格形式从mysql数据库以php的形式显示数据

Question

需要以表格形式显示mysql表格中检索到的数据，但没有得到我计划的正确显示。这是我希望它看起来像 Target display

但是，这是我根据我的代码是什么得到 Current display

这是HTML代码

<div> 
     <table class="table table-striped table-hover"> 
      <thead> 
       <tr> 
        <th>First Name</th> 
        <th>Last Name</th> 
        <th>Department</th> 
        <th>Action</th> 
       </tr> 
      </thead> 
      <tbody> 

       <?php 
        $staff_set = find_all_employee(); 
        while ($staff = mysqli_fetch_assoc($staff_set)) { 
         //display staff first name, last name, department and action (edit and delete links) 
       ?> 
       <tr> 
        <td> 
         <?php 
          echo $staff["first_name"]; 
          } 
         ?> 
        </td> 

        <?php 
         $staff_set = find_all_employee(); 
         while ($staff = mysqli_fetch_assoc($staff_set)) { 
          //display staff last name 
        ?> 
        <td> 
         <?php 
          echo $staff["last_name"]; 
          } 
         ?> 
        </td> 

        <?php 
         $staff_set = find_all_employee(); 
         while ($staff = mysqli_fetch_assoc($staff_set)) { 
          //display staff department 
        ?> 
        <td> 
         <?php 
          echo $staff["department"]; 
          } 
         ?> 
        </td> 

        <td> 
         <a href="edit_admin.php"><span class="glyphicon glyphicon-pencil"> Edit</span></a> 
         &nbsp 
         <a href=""><span class="glyphicon glyphicon-trash"> Delete</span></a> 
        </td> 
       </tr> 

      </tbody> 
     </table> 
    </div> 

下面是使用我的功能从我的员工列表中找到所有员工的列表

function find_all_employee() { 
    global $connection; 

    $query = "select * from staff"; 
    $staff_set = mysqli_query($connection, $query); 
    confirm_query($staff_set); 
    return $staff_set; 
} 

Is there一个更好的方式来编写循环并以正确的方式显示我的数据？我查了类似的线程，但仍然无法掌握。

Answer 1

我不明白你为什么调用这么多的领带功能，以及为什么做这么多循环。让我尝试科幻代码：

<div> 
    <table class="table table-striped table-hover"> 
     <thead> 
      <tr> 
       <th>First Name</th> 
       <th>Last Name</th> 
       <th>Department</th> 
       <th>Action</th> 
      </tr> 
     </thead> 
     <tbody> 
     <?php 
      $staff_set = find_all_employee(); 
      while ($staff = mysqli_fetch_assoc($staff_set)) { 
       //display staff first name, last name, department and action (edit and delete links) 
     ?> 
      <tr> 
       <td> 
        <?php echo $staff["first_name"]; ?> 
       </td>    
       <td> 
        <?php echo $staff["last_name"]; ?> 
       </td> 
       <td> 
        <?php echo $staff["department"]; ?> 
       </td> 
       <td> 
        <a href="edit_admin.php"><span class="glyphicon glyphicon-pencil"> Edit</span></a> 
         &nbsp 
        <a href=""><span class="glyphicon glyphicon-trash"> Delete</span></a> 
       </td> 
      </tr> 
     <?php 
     } 
     ?> 
     </tbody> 
    </table> 
</div> 

Answer 2

由于OP要求在评论一个改变技术：

<?php 
// Select all staff first name, last name, and department info 
$staff_set  = find_all_employee(); 
$staff_results = array(); 
while ($staff = mysqli_fetch_assoc($staff_set)) { 
    $staff_results[] = $staff; 
} 
?> 

<div> 
    <table class="table table-striped table-hover"> 
     <thead> 
      <tr> 
       <th>First Name</th> 
       <th>Last Name</th> 
       <th>Department</th> 
       <th>Action</th> 
      </tr> 
     </thead> 
     <tbody> 
     <?php if (!empty($staff_results)): ?> 
      <?php foreach($staff_results as $staff_member): ?> 
      <tr> 
       <td> 
        <?= $staff_member["first_name"]; ?> 
       </td>    
       <td> 
        <?= $staff_member["last_name"]; ?> 
       </td> 
       <td> 
        <?= $staff_member["department"]; ?> 
       </td> 
       <td> 
        <a href="edit_admin.php"><span class="glyphicon glyphicon-pencil"> Edit</span></a> 
         &nbsp 
        <a href=""><span class="glyphicon glyphicon-trash"> Delete</span></a> 
       </td> 
      </tr> 
      <?php endforeach; ?> 
     <?php else: ?> 
      <tr><td colspan="4">No Staff Members Found.</td></tr> 
     <?php endif; ?> 
     </tbody> 
    </table> 
</div> 

这还引入了更换呼叫echo的short tag语法（<?=）。如果您的PHP版本是< 5.4，请阅读this thread。这也引入了control structure alternate syntax，为了更好的阅读HTML。上述方法分离了从HTML表示中选择数据的关注点。这样可以更轻松地进行调试，以及将来的适应和模块化应用程序。